Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Date:   Sun, 26 Nov 2023 15:30:14 +0100
From:   Andi Shyti <andi.shyti@kernel.org>
To:     Heiner Kallweit <hkallweit1@gmail.com>
Cc:     Wolfram Sang <wsa@kernel.org>, Jim Cromie <jim.cromie@gmail.com>,
        linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 10/10] i2c: scx200_acb: Don't let i2c adapters declare
 I2C_CLASS_SPD support if they support I2C_CLASS_HWMON
Message-ID: <20231126143014.sz4jjwuqcl5biz5p@zenone.zhora.eu>
References: <20231124101619.6470-1-hkallweit1@gmail.com>
 <20231124101619.6470-11-hkallweit1@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231124101619.6470-11-hkallweit1@gmail.com>
Precedence: bulk

Hi Heiner,

in this last patch I will add a couple of minor comments valid
for the previous, as well.

On Fri, Nov 24, 2023 at 11:16:19AM +0100, Heiner Kallweit wrote:
> After removal of the legacy eeprom driver the only remaining I2C
> client device driver supporting I2C_CLASS_SPD is jc42. Because this
> driver also supports I2C_CLASS_HWMON, adapters don't have to
> declare support for I2C_CLASS_SPD if they support I2C_CLASS_HWMON.
> It's one step towards getting rid of I2C_CLASS_SPD mid-term.
> 
> Series was created supported by Coccinelle and its splitpatch.

this sentence is grammatically incorrect, I guess you meant:

"The series was created with support from Coccinelle and its
splitpatch feature."

Please fix it if you are going to resend it.

> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> 

Just for you to know, all your patches have a blank line after
your SoB, it doesn't really matter as I guess git removes it.

In any case, as before:

Acked-by: Andi Shyti <andi.shyti@kernel.org>                     
                                                                 
and I believe:                                                   
                                                                 
Acked-by: Jim Cromie <jim.cromie@gmail.com>                      
                                                                 
so that patchwork takes it.

Thanks,
Andi