Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp2532000rdh; Sun, 26 Nov 2023 09:30:35 -0800 (PST) X-Google-Smtp-Source: AGHT+IEoD+ioASNwzzymUEulIyDrwPk6sjX0FFteoSP3hOQOQZ7ELmwiXAFcVqNHUXn1GwtR/D5n X-Received: by 2002:a17:903:2593:b0:1cc:1106:cf5b with SMTP id jb19-20020a170903259300b001cc1106cf5bmr8110954plb.19.1701019835260; Sun, 26 Nov 2023 09:30:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701019835; cv=none; d=google.com; s=arc-20160816; b=dNGKagDo9+cMf6/zKkS/gXz4wZn3YcsRbphikfE+aoieVx4EHytKLzJyllrEU8mBhT GoVsS0L28oyC6ICvIrhj3XYxMm/1J3Qpen5Bm2SzVABq77cU4QdiunnK70YPsgDpYWep B1++pYiQMb0iLttl4HZHkoGy3nFzmFCyhZcXm/3cirzeTJeB1tc0eTGAXfZSjrA13+6J tPJyopenGjWrH6suqp+TY2WaCj+xcX9x0J/1sFCISpGxjehl8B9/AseK2Y/Gt67Wlo3Q WtlxGBaNvZW+WLUFte3n8D6BZ6ajOGtcADoWlxLUMutL9/QDgb7gn6bJ7djLTshOAlib lpag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=LvAkqB/v8fEvtKpeF1o4i/FW6JbG8o135tosDUmh+Mo=; fh=iQObdIAwFf8wCW48TcSP5cyqbZd5RncORi9xo6N5f3o=; b=ZMqbV4/1xSUTlZEQytgCsmmYnqXM+XcTyJL4+cN6TE/12NYt7hQe4eK+8w75XKty8X /npCLCJX7jU6PK42UEbhoamMi/InAXnNeUnB/pEn8y5+XjEYYnqccolbA9OvFGHbB+NU DPMH1tRHaV8ETH73ZM1OU1tT8hDO/6/KOvNj/++HX0QU5mCP+hlB36NJhyHJA5xrlEhJ 9ZraYxcv5XJ21dp0AD0COcbhAjQVQaPIVbIG9DNh/6EV0thSxY8qyv5rsvqCAPh8EBF9 ICTgzTvOnuXJ7d5GpDLKV5imOsJc5sjzvLEIkPtIkcfcYydKX0GgBNoz34CARnLA8+L3 vOgA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=qYz3M403; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id lk14-20020a17090308ce00b001c427a74e31si8128045plb.628.2023.11.26.09.30.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Nov 2023 09:30:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=qYz3M403; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id BAE48806BC14; Sun, 26 Nov 2023 09:30:20 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230304AbjKZRaF (ORCPT + 99 others); Sun, 26 Nov 2023 12:30:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42426 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229436AbjKZRaE (ORCPT ); Sun, 26 Nov 2023 12:30:04 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D69AECB for ; Sun, 26 Nov 2023 09:30:10 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 52783C433C7; Sun, 26 Nov 2023 17:30:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701019810; bh=8ojV6a7cA9LYv/jr195EjbCuO3ivVg0awU0eg229aNI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=qYz3M403eaUTi/hMjdpYXhdNYCNb5yjIPB3zQQdo5E8BaOBKrnaS1wIYN47e3De9O /KToXdsYSF6P+RY3Rcx50jgCbrFsdkdRhGwRMkEkjUHbTg9LU499lCaZTWv2sN0llK ohDzK856p14I8nseZEFqyVOQx/Z2SAkWVHmHpuAkCPlBSBle7ZXBystWWT5ac7+x+P bllmXWNG+hrbPGc6yHy/5qzi+pZd7PZfgSyegv8LyXgrgbfLg4xKqWGb7wsxWAKAJs yK6AV7Cuh9Y41aZUUcF9JS4b/fttd7BVohRrp/T6ghN4rJbOYqja2EchnOLXx9SYgk tSP0hOUpYy24Q== Date: Sun, 26 Nov 2023 17:30:02 +0000 From: Jonathan Cameron To: Abdel Alkuor Cc: Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] dt-bindings: iio: temperature: Add AMS AS6200 Message-ID: <20231126173002.3783271f@jic23-huawei> In-Reply-To: <7e108db19cd9ad19b6413f65099280c010325a91.1699740057.git.alkuor@gmail.com> References: <7e108db19cd9ad19b6413f65099280c010325a91.1699740057.git.alkuor@gmail.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Sun, 26 Nov 2023 09:30:20 -0800 (PST) On Sat, 11 Nov 2023 17:05:01 -0500 Abdel Alkuor wrote: > as6200 is high accuracy temperature sensor of -/+ 0.4C degree > with a range between -40C to 125C degrees > Hi Abdel, Welcome to IIO. Just one comment on specifying power supplies below. Jonathan > Signed-off-by: Abdel Alkuor > --- > .../bindings/iio/temperature/ams,as6200.yaml | 45 +++++++++++++++++++ > 1 file changed, 45 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/temperature/ams,as6200.yaml > > diff --git a/Documentation/devicetree/bindings/iio/temperature/ams,as6200.yaml b/Documentation/devicetree/bindings/iio/temperature/ams,as6200.yaml > new file mode 100644 > index 000000000000..97a73b92a789 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/temperature/ams,as6200.yaml > @@ -0,0 +1,45 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/temperature/ams,as6200.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: AMS AS6200 Temperature Sensor > + > +maintainers: > + - Abdel Alkuor > + > +description: | > + https://ams.com/documents/20143/36005/AS6200_DS000449_4-00.pdf > + > +properties: > + compatible: > + const: ams,as6200 > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 I'd like to see vdd-supply: true and it added to teh required list. The device needs power. Note there is a devm_regulator_get_enable() function that can then be used in the driver to turn on any regulator specified in DT which will provide a stub regulator if there isn't one (not unusual if a fixed power supply is used that is always on). > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + #include > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + temperature-sensor@48 { > + compatible = "ams,as6200"; > + reg = <0x48>; > + interrupt-parent = <&gpio1>; > + interrupts = <17 IRQ_TYPE_EDGE_BOTH>; > + }; > + }; > +...