Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
MIME-Version: 1.0
References: <20231126162009.17934-1-sven@svenpeter.dev>
In-Reply-To: <20231126162009.17934-1-sven@svenpeter.dev>
From:   Neal Gompa <neal@gompa.dev>
Date:   Sun, 26 Nov 2023 12:31:15 -0500
Message-ID: <CAEg-Je_v78nLMYwH4RzZPE__HDc3T9=uu4hVw4wRDDM7A+RFCw@mail.gmail.com>
Subject: Re: [PATCH] iommu: dart: Use readl instead of readl_relaxed for consistency
To:     Sven Peter <sven@svenpeter.dev>
Cc:     Hector Martin <marcan@marcan.st>, Joerg Roedel <joro@8bytes.org>,
        Will Deacon <will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>,
        Alyssa Rosenzweig <alyssa@rosenzweig.io>,
        asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
        iommu@lists.linux.dev, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Sun, Nov 26, 2023 at 11:20 AM Sven Peter <sven@svenpeter.dev> wrote:
>
> While the readl_relaxed in apple_dart_suspend is correct the rest of the
> driver uses the non-relaxed variants everywhere and the single
> readl_relaxed is inconsistent and possibly confusing.
>
> Signed-off-by: Sven Peter <sven@svenpeter.dev>
> ---
>  drivers/iommu/apple-dart.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/apple-dart.c b/drivers/iommu/apple-dart.c
> index 59cf256bf40f..c7f047ce0a7a 100644
> --- a/drivers/iommu/apple-dart.c
> +++ b/drivers/iommu/apple-dart.c
> @@ -1272,7 +1272,7 @@ static __maybe_unused int apple_dart_suspend(struct device *dev)
>         unsigned int sid, idx;
>
>         for (sid = 0; sid < dart->num_streams; sid++) {
> -               dart->save_tcr[sid] = readl_relaxed(dart->regs + DART_TCR(dart, sid));
> +               dart->save_tcr[sid] = readl(dart->regs + DART_TCR(dart, sid));
>                 for (idx = 0; idx < dart->hw->ttbr_count; idx++)
>                         dart->save_ttbr[sid][idx] =
>                                 readl(dart->regs + DART_TTBR(dart, sid, idx));
> --
> 2.34.1
>
>

Reviewed-by: Neal Gompa <neal@gompa.dev>


-- 
真実はいつも一つ！/ Always, there's only one truth!