Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
Date:   Sun, 26 Nov 2023 21:19:46 +0100
From:   Cyril Brulebois <kibi@debian.org>
To:     Jim Quinlan <james.quinlan@broadcom.com>
Cc:     linux-pci@vger.kernel.org,
        Nicolas Saenz Julienne <nsaenz@kernel.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        Phil Elwell <phil@raspberrypi.com>,
        bcm-kernel-feedback-list@broadcom.com,
        Conor Dooley <conor+dt@kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        Florian Fainelli <florian.fainelli@broadcom.com>,
        Jim Quinlan <jim2101024@gmail.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= <kw@linux.com>,
        "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" 
        <linux-arm-kernel@lists.infradead.org>,
        open list <linux-kernel@vger.kernel.org>,
        "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" 
        <linux-rpi-kernel@lists.infradead.org>,
        Lorenzo Pieralisi <lpieralisi@kernel.org>,
        Rob Herring <robh@kernel.org>
Subject: Re: [PATCH v8 0/2] PCI: brcmstb: Configure appropriate HW CLKREQ#
 mode
Message-ID: <20231126201946.ffm3bhg5du2xgztv@mraw.org>
Organization: Debian
References: <20231113185607.1756-1-james.quinlan@broadcom.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="mkmt4f6shqfnuwxf"
Content-Disposition: inline
In-Reply-To: <20231113185607.1756-1-james.quinlan@broadcom.com>
Precedence: bulk


--mkmt4f6shqfnuwxf
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Jim,

Jim Quinlan <james.quinlan@broadcom.com> (2023-11-13):
> V8 -- Un-advertise L1SS capability when in "no-l1ss" mode (Bjorn)
>    -- Squashed last two commits of v7 (Bjorn)
>    -- Fix DT binding description text wrapping (Bjorn)
>    -- Fix incorrect Spec reference (Bjorn)
>          s/PCIe Spec/PCIe Express Mini CEM 2.1 specification/
>    -- Text substitutions (Bjorn)
>          s/WRT/With respect to/=20
>          s/Tclron/T_CLRon/
>=20
> v7 -- Manivannan Sadhasivam suggested (a) making the property look like a
>       network phy-mode and (b) keeping the code simple (not counting clkr=
eq
>       signal appearances, un-advertising capabilites, etc).  This is
>       what I have done.  The property is now "brcm,clkreq-mode" and
>       the values may be one of "safe", "default", and "no-l1ss".  The
>       default setting is to employ the most capable power savings mode.

Still:

Tested-by: Cyril Brulebois <cyril@debamax.com>


I've just run my big test matrix again, and I can confirm everything is
still looking good with the updated series and the updated base commit.


Test setup:
-----------

 - using a $CM with the 20230111 EEPROM
 - on the same CM4 IO Board
 - with a $PCIE board (PCIe to multiple USB ports)
 - and the same Samsung USB flash drive + Logitech keyboard.

where $CM is one of:

 - CM4 Lite Rev 1.0
 - CM4 8/32 Rev 1.0
 - CM4 4/32 Rev 1.1

and $PCIE is one of:

 - SupaHub PCE6U1C-R02, VER 006
 - SupaHub PCE6U1C-R02, VER 006S
 - Waveshare VIA VL805/806-based


Results:
--------

 1. With an unpatched kernel, I'm getting either a successful boot
    *without* seeing the devices plugged on the PCIe-to-USB board
    or the dreaded SError in most cases, using a locally-built
    v6.4-rc7-194-g8a28a0b6f1a1d kernel.

 2. With a patched kernel (v6.6-15365-g305230142ae0 + this series),
    for all $CM/$PCIE combinations, I'm getting a system that boots,
    sees the flash drive, and gives decent read/write performance on
    it (plus a functional keyboard).


Cheers,
--=20
Cyril Brulebois (kibi@debian.org)            <https://debamax.com/>
D-I release manager -- Release team member -- Freelance Consultant

--mkmt4f6shqfnuwxf
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEtg6/KYRFPHDXTPR4/5FK8MKzVSAFAmVjqFwACgkQ/5FK8MKz
VSBgfxAAn3o2oYlRYjjFM1QJdb0L/cGkGg6stFG1Cg9G/y0SX/U9C4/RF0hYeXGg
9gKGzI2KVWFdWIMwEqBcVnM0/+m50VUyIn2ne0iHwkoOZXlJu5+5v2+lRhDKgmad
f1b86OdzqJ/JFT6AuA7f9JDzyQar/Q3TMFcN7ObOhoCfuKX/mnDrzhcWT4RFHSTA
CZrDs6y/ua4+07GxlJncR1yIlOVxwlTsTY3S0yD1Ppbva9BHZ5FP2/1o18TIipwh
vPCik5XC5c2oEeyEpP6adLJgQK9HYhMzw4eDPM7FTC27tOokr4DZkYDza6zn8XOS
xP3tMptoFfWNJHxmvXz3nS+qT6QkIvoNkysVNYM3J/HsVHjUUYHj9Wcj4tEdVOtY
ueMIuNnYF6PkPJ3erg09FMp8eBpk05ctSTdIq0U/Fg7UjSNWNDrW6JFsIQTpaenm
HxhroQzHFsBOAdHT5WFXQfXDTSUQVmNnv59cVWPhHwHlLy0ePFpjRC3doLZ0Zp65
dUQVF5VOgnnsO1WVExiyFNqm2b1JC9f1HSF0gjgbwJvnsY06uuZrodsFYKep8/np
1px/1lHTK23gvu+soe05hqmepc3Pn2HqpMdr56Lh/GZucmoCZydnn7MuykPcRLvy
seFmfpyY13qpLSXeRubFi524GtF/pc6XkIK1Wq4J5DGpTT2Y6Ts=
=ve11
-----END PGP SIGNATURE-----

--mkmt4f6shqfnuwxf--