Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Message-ID: <6563c20e.050a0220.6de54.6c62@mx.google.com>
Date:   Sun, 26 Nov 2023 23:09:15 +0100
From:   Christian Marangi <ansuelsmth@gmail.com>
To:     Linus Walleij <linus.walleij@linaro.org>
Cc:     Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vladimir Oltean <olteanv@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Tim Harvey <tharvey@gateworks.com>,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH RFC] net: dsa: mv88e6xxx: Support LED control
References: <20231123-mv88e6xxx-leds-v1-1-3c379b3d23fb@linaro.org>
 <c8c821f8-e170-44b3-a3f9-207cf7cb70e2@lunn.ch>
 <CACRpkdY+T8Rqg_irkLNvAC+o_QfwO2N+eB9X-y24t34_9Rg3ww@mail.gmail.com>
 <4bd8642c-988f-4b99-944a-da573d0ef2c3@lunn.ch>
 <CACRpkdYp76UK3uC=3JrbZ5MhPRn7CkAbO1fezrSCNfDqobjZww@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CACRpkdYp76UK3uC=3JrbZ5MhPRn7CkAbO1fezrSCNfDqobjZww@mail.gmail.com>
Precedence: bulk

On Sun, Nov 26, 2023 at 09:11:28PM +0100, Linus Walleij wrote:
> On Sun, Nov 26, 2023 at 5:45 PM Andrew Lunn <andrew@lunn.ch> wrote:
> > On Sun, Nov 26, 2023 at 12:46:03AM +0100, Linus Walleij wrote:
> > > On Thu, Nov 23, 2023 at 5:13 PM Andrew Lunn <andrew@lunn.ch> wrote:
> > >
> > > > What i would really like to see happen is that the DSA core handles
> > > > the registration of the LEDs, similar to how phylib does. The DT
> > > > binding should be identical for all DSA devices, so there is no need
> > > > for each driver to do its own parsing.
> > > >
> > > > There are some WIP patches at
> > > >
> > > > https://github.com/lunn/linux.git leds-offload-support-reduced-auto-netdev
> > > >
> > > > which implement this. Feel free to make use of them.
> > >
> > > Oh it's quite a lot of patches, I really cannot drive that because there are
> > > so many things about them that I don't understand the thinking behind...
> > > But I like what I see!
> >
> > O.K. Let me dust them off, rebase them on net-next and see what is
> > missing.
> 
> Thanks Andrew, appreciated!
> 
> I'll be happy to rebuild it on top of what you put as the baseline,
> hopefully it will help Christian with the qca8k support as well?
>

Sure thing. I can test and see if I have problem with the generic
approach.

> > You have some fibre things i don't have. I don't have a
> > machine with fibre so i cannot test that.
> 
> I can test that, the way I check for its presence is through device tree looking
> for an "sfp" phandle, AFAICT I don't see that the hardware can tell be
> when there
> is a fiber connected, but alas I don't have any datasheet.
> 
> Yours,
> Linus Walleij

-- 
	Ansuel