Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp2667412rdh; Sun, 26 Nov 2023 15:05:54 -0800 (PST) X-Google-Smtp-Source: AGHT+IFaERK1tGjaEkEjqDljiwLJHA8wICby79slShttSoCxLCnNC0K1J+8B5cSnGLO9KVxnvmy9 X-Received: by 2002:a05:6a00:1956:b0:6cb:a27f:5065 with SMTP id s22-20020a056a00195600b006cba27f5065mr10946508pfk.34.1701039954168; Sun, 26 Nov 2023 15:05:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701039954; cv=none; d=google.com; s=arc-20160816; b=Fs11tFZqmluGcrpvDsG/p5ahI2kP/Ms0lAjBMZJRG8Nr7RIu155mwSpVu+tVDLHJ+G eHf4Fgvyx3+Zs5Zpk4KVBuqyTlR/Kie/A7fgRQTogjAjy9Pf/3wpW+4db55IbtKFx/pw 505XKktuN2g4L3LFpGfWq64UqfIsr61EetZu6c1D9o+wfCNkoi2HYd1Ii8jKlON0u7pz g0bmhIyfvtKQ54qSRnQYVGVF6bpK/jb3iy3py8HSa33wIWs0SBoXuUE2C7DHP66SKL3y xUeh7rmwpCu15flcCZcvXZJ4n93MeAa6qzbZKORMpyxvbFN+PXRmDrsekpDh3rvE6GrB tOJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=geW3FrE74EiAS5Xfqym0KVVtLScmVjoydysn4lhVxoM=; fh=MjGn6Nqs5XwWQ4HL9NczhLkgEv2f7ia4xEhapUgxMVU=; b=hAXMQHdI5DleD+IKaeridrnkdj/Zpp589q/3NmnP3Y3d4cQ3EU+rO1+tBZXxoKdt3x sJZ9ijeaVzCw51nRBtp2qeBdEBLiPTrLjo/KJztwVjq4NglbaVzLmnfjW5pag5N8MKrE nB3rtGTO40HRxDt0SBDuzYVrlBE7iQXzxe55umQ5WLTpVXWULO3RJ4quUfnTsX5YQNCV BgQ3y05b07ys0HQK7kRwaRbI/O6bTEBxY70AED2UgenrT8BJE6AH/97TVNfYnbSMwZ/u MjUKC9+5p/IAdZr/EsuuuFX1RinJCfpl1HXXTgMJivu3Rf3R4tQMVaJ0k/V7dBWywEkO +w9Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=qJJu32y9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id y7-20020a62f247000000b006cd8a7b815fsi1389963pfl.401.2023.11.26.15.05.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Nov 2023 15:05:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=qJJu32y9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 2FA0C807E42E; Sun, 26 Nov 2023 15:05:51 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229502AbjKZWyx (ORCPT + 99 others); Sun, 26 Nov 2023 17:54:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42034 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229447AbjKZWyw (ORCPT ); Sun, 26 Nov 2023 17:54:52 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 74301E4 for ; Sun, 26 Nov 2023 14:54:59 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 68C52C433C7; Sun, 26 Nov 2023 22:54:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701039299; bh=ikD1IcWn7pY0Kg0l7nVoix086nkdC/HUPPp5zrf1b4o=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=qJJu32y9fKFumvgnuECyyu2TS9UMK5Ap6sAmKlCfNCIG1Ao17kQtALBfEDRHWruyO DySl8NfRpcr0kz1FfH4ylkBz9WhCBgh1+yrcz1LlzRXqi0F9fbuqKnm0Y0EkefUhBv +BlB1H8xSLp75zBwmJO7XbcyVO3eU+mrChAMiPaESALpb0qMwVpHK4if+s/SYfXFhh z5cka8YmKQ06Ep6beWWA8c//zo/sCaoGMbvkO8tsW5erj/DaDz8pZtydLkcg8wYb2O CuVWAF09Fi9PHhwx4TTHQM/mIoGXhKf0+nUBa0QWRwhdql1pBW2d92lF+pfo0q6CYZ pehRSiZD2QmSQ== Date: Sun, 26 Nov 2023 14:54:57 -0800 From: Jakub Kicinski To: Alexander Lobakin Cc: "David S. Miller" , Eric Dumazet , Paolo Abeni , Maciej Fijalkowski , Michal Kubiak , Larysa Zaremba , Alexander Duyck , Yunsheng Lin , David Christensen , Jesper Dangaard Brouer , Ilias Apalodimas , Paul Menzel , netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v5 01/14] page_pool: make sure frag API fields don't span between cachelines Message-ID: <20231126145457.400726e4@kernel.org> In-Reply-To: <20231124154732.1623518-2-aleksander.lobakin@intel.com> References: <20231124154732.1623518-1-aleksander.lobakin@intel.com> <20231124154732.1623518-2-aleksander.lobakin@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Sun, 26 Nov 2023 15:05:51 -0800 (PST) On Fri, 24 Nov 2023 16:47:19 +0100 Alexander Lobakin wrote: > - long frag_users; > + long frag_users __aligned(4 * sizeof(long)); A comment for the somewhat unusual alignment size would be good.