Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
MIME-Version: 1.0
References: <20230913084457.1638690-1-wenst@chromium.org>
In-Reply-To: <20230913084457.1638690-1-wenst@chromium.org>
From:   Chen-Yu Tsai <wenst@chromium.org>
Date:   Mon, 27 Nov 2023 11:07:27 +0800
Message-ID: <CAGXv+5E5BWzMP981Agn01XVAO=KC5CE04oOi8xWwx=DT=N61dw@mail.gmail.com>
Subject: Re: [PATCH v3] arm64: dts: mediatek: mt6358: Merge ldo_vcn33_* regulators
To:     Matthias Brugger <matthias.bgg@gmail.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>
Cc:     devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Matthias, Angelo,

On Wed, Sep 13, 2023 at 4:45=E2=80=AFPM Chen-Yu Tsai <wenst@chromium.org> w=
rote:
>
> The ldo_vcn33_bt and ldo_vcn33_wifi regulators are actually the same
> regulator, having the same voltage setting and output pin. There are
> simply two enable bits that are ORed together to enable the regulator.
>
> Having two regulators representing the same output pin is misleading
> from a design matching standpoint, and also error-prone in driver
> implementations.
>
> Now that the bindings have these two merged, merge them in the device
> tree as well. Neither vcn33 regulators are referenced in upstream
> device trees. As far as hardware designs go, none of the Chromebooks
> using MT8183 w/ MT6358 use this output.
>
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collab=
ora.com>

Please remember to queue this up. All the driver changes were merged in
the last cycle.

ChenYu

> ---
> This was part of the series "regulator: mt6358: Remove bogus regulators
> and improvements". Since the driver parts related to this patch have all
> been picked up, so I'm sending this separately.
>
>  arch/arm64/boot/dts/mediatek/mt6358.dtsi | 11 ++---------
>  1 file changed, 2 insertions(+), 9 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt6358.dtsi b/arch/arm64/boot/d=
ts/mediatek/mt6358.dtsi
> index 96ba8490b629..ad5e4022e06d 100644
> --- a/arch/arm64/boot/dts/mediatek/mt6358.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt6358.dtsi
> @@ -292,15 +292,8 @@ mt6358_vrf18_reg: ldo_vrf18 {
>                                 regulator-enable-ramp-delay =3D <120>;
>                         };
>
> -                       mt6358_vcn33_bt_reg: ldo_vcn33_bt {
> -                               regulator-name =3D "vcn33_bt";
> -                               regulator-min-microvolt =3D <3300000>;
> -                               regulator-max-microvolt =3D <3500000>;
> -                               regulator-enable-ramp-delay =3D <270>;
> -                       };
> -
> -                       mt6358_vcn33_wifi_reg: ldo_vcn33_wifi {
> -                               regulator-name =3D "vcn33_wifi";
> +                       mt6358_vcn33_reg: ldo_vcn33 {
> +                               regulator-name =3D "vcn33";
>                                 regulator-min-microvolt =3D <3300000>;
>                                 regulator-max-microvolt =3D <3500000>;
>                                 regulator-enable-ramp-delay =3D <270>;
> --
> 2.42.0.283.g2d96d420d3-goog
>