Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
Message-ID: <33021b87-4c6a-45fc-a6ae-265765cfcd78@amperemail.onmicrosoft.com>
Date:   Mon, 27 Nov 2023 11:18:27 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] crash_core: export vmemmap when CONFIG_SPARSEMEM_VMEMMAP
 is enabled
To:     Baoquan He <bhe@redhat.com>,
        Huang Shijie <shijie@os.amperecomputing.com>
Cc:     k-hagio-ab@nec.com, lijiang@redhat.com, akpm@linux-foundation.org,
        vgoyal@redhat.com, dyoung@redhat.com, kexec@lists.infradead.org,
        linux-kernel@vger.kernel.org, patches@amperecomputing.com
References: <20231127020727.25296-1-shijie@os.amperecomputing.com>
 <ZWQEP4SczFh+GUHq@MiWiFi-R3L-srv>
From:   Shijie Huang <shijie@amperemail.onmicrosoft.com>
In-Reply-To: <ZWQEP4SczFh+GUHq@MiWiFi-R3L-srv>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Rk9YNkFBSktGUzRRWmdkSis1eW9VQTlZRVhxRlpnZkY2cUlKM3M4REk2eUdr?=
 =?utf-8?B?RXFkV2o1dTRPNGpDcXE3Q1M3ZDdCamdYVWphdkpaUjl3bGV3WWdIbllnY1ZX?=
 =?utf-8?B?cWdRazU2bmE1TWJhNmhqb3h1R0VzbHlXTk41WHRhaDhxV3BhemtxZUErdTdk?=
 =?utf-8?B?SGMrU3lKeEJBMlhqRzFDaWV4ampYell0Q0hJMytaWlVxdUUzc1hkc1pmQzFP?=
 =?utf-8?B?VUFoR3lEVmNReFkwaE4vOW15MlhSa0xORUd0clZUUTkyNjBjbVB5QzBDOW9H?=
 =?utf-8?B?bk1lRDJnUWtLVE5mTFVxckdqQmh6MDFPb1YrTnA1Y0tqZjJJdHRVS1grUjlL?=
 =?utf-8?B?NWNXYkRybHhjWFUxbHZEdGpFZHVCSmVQWlFYVTgzeHVyQXMrcFB5Nk9IcUEy?=
 =?utf-8?B?VzlpWGJ0MkY2YVdvWWxiQkJ2Qys0NHJVRHFtS3o0Q00zZisrVThMT25Ia2N3?=
 =?utf-8?B?dVBaaFlaOWJUdGdIMTEweFFrVzExQzhMZXZ3eFRGS3ZZQjlRRG1KclpvVTZC?=
 =?utf-8?B?RUhUbUJpa0xMWU5uRlpvTklyZXVzS3MwV3U3UVNIQ3RicXRqZUFiSDR3a1pK?=
 =?utf-8?B?aEgwMlVzQ2VSbHFCQjY5UGpLYW90SE9rQ2ljSDAzUEN5MDBMT3NDbEE0OHlN?=
 =?utf-8?B?K29ENUlaaG5FRGw2b2lGeTBPcnRqOFJnMlhObnAyZ1RnajE0cEpsZTN4RVl5?=
 =?utf-8?B?UVZIQ3R0NFhHSG9uSUhEOEJ5c1BDdi9yY2RMcVNVcUlycFk1d0xmOG5aWk9R?=
 =?utf-8?B?RDVVSzVZcVI2R0NiNDVxQ2wzbVR4emE3MEUwdUtoT0ZNbnpETmYwQ1BQRUp0?=
 =?utf-8?B?Y2NaZklwdXBYT21lS25yb1cxQ0t3QmxrOVlLT2xEYjMyaDBwSnA1aXRzM09X?=
 =?utf-8?B?R3RNSDR4WkttajVoQ0ZXSWFvSmUxRkRGemk2bjV4UzFSR01vYVJ3NEZLOS9x?=
 =?utf-8?B?LzZDVVYralNnUVNMcTVObml5bk9vMm4wM25pQ2QzODA0TjJhTGY5M1c2WjZH?=
 =?utf-8?B?MVhiUTdRdXNBOVFURWo5b1pjbzBVd0ZkNy9zUk1reUlkY3hFU3g3SzNybDZu?=
 =?utf-8?B?TlgzVjVKNW9XOXVxcWpZVlJqa0pIWDdEcE1kQ0hwNUhrSVlHUlJkZlFKMzMz?=
 =?utf-8?B?QWtDR1A4bzAwWVZURFZIZHBlbWYwaTBESzJYVGZBaWphdWRGdUFNdklDQXZB?=
 =?utf-8?B?RTFrQjZGRzYvWS8xRUdlZjFYcmFXbXducXJzL0w4K0hic3Z4SmhtR1ZCVTFE?=
 =?utf-8?B?R3VoRjRValNsTW5aSTIra3I3RUNFdjZabWJpR0owMzlJUWYyUFpUcHl4aEw2?=
 =?utf-8?B?UnhhN0tkd2lSbm0xVE4wTHFIMjV4K3pETCtVRlpHbWVad1BXTmxpOFhyZ3pn?=
 =?utf-8?B?WWZpSlNrSEk4S3gvV0lzT2RIaWRwTkR0UWhyMHcwdmxrVFJ2SDByU0NsV0NZ?=
 =?utf-8?B?SGt3QlZmYjRISHBVekZxM0dzbWQ3b0ZFaTRsUmhvYmdCdlZIQStXb3ZLWjhh?=
 =?utf-8?B?bTlXVnU4UTFFUVpHU09LTnJhaFp3Vjh2TjQ3a2VFN1A2VEc3Uk9RRjZjVW5S?=
 =?utf-8?B?WU9OWGdvRUEzOStDMFJ4WGlWUnoyS1VFY1Q1L2JMU0FVTEg4ZjJ2WlV3NFpn?=
 =?utf-8?B?Y1dmb203VFZZcGhVbXBnTlpab01QeTBRSlhocCs3M2swS0NTbFdSUVlUcTZq?=
 =?utf-8?B?MEpuR1R2RTdKSGo2cXZjNU1hNE5DMUVTbTR4NXJjQnBPdHNIVEZ5SytRYzNH?=
 =?utf-8?B?Y3oxc1ByLzdxTStRU3pqdUhsRFVzLzJBeldwVWZhWi9qR2dtUTVJbW9ERkFB?=
 =?utf-8?B?bDdISUx2WnIzWTgrenluN25lbUw1SWhDdktCUzNZdkx2WklONWJVTUt1dXV1?=
 =?utf-8?B?dmVTamtHVFh1eno5K1ZpYnYxNHI0dWNXUC91SkI2REZ1RXhoUWorOGJ4ck8r?=
 =?utf-8?B?Q3VoaWJhcnJFYzh0N1N3QmQwemNzcGNvUENQY3Arb3Zld1ZFWnZxM05jZFRr?=
 =?utf-8?B?QW5ob3Q4bERZR3A1VTV2Tlh2S1RDSDhHRGdtZFhDbW5kNlErU3ZiL2xJY2lx?=
 =?utf-8?B?NGJybTVRQU10N0ZqMk1kYTU3VkFtMXZTKzU3TnRYckJXUVRaVzVVTkliVjRI?=
 =?utf-8?B?b2U0UndBalU5SjBNVVlQRGxSeC9uRVIzOHJwbTZ2L3ROVTZkUWVDaGRpZ0Iv?=
 =?utf-8?B?V3c9PQ==?=
X-OriginatorOrg: amperemail.onmicrosoft.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 463c7504-3622-479d-189d-08dbeef78a4a
X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB7975.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Nov 2023 03:18:35.0999
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: d7QEc3/P18E/akTgACmpIpSm+HIRagQYjUnVRRbuW4rmoDOAe0fFZzMGfc7I7hDra0ky3zR6l5w8NWTkNVloSkvdNXp76tbEYUf2U5pPZ+QbP9oMRcIQjRvhrcxMN6Tc
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR01MB8370
X-Spam-Status: No, score=-0.3 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED,
	FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Sun, 26 Nov 2023 19:19:03 -0800 (PST)


在 2023/11/27 10:51, Baoquan He 写道:
> Hi,
>
> On 11/27/23 at 10:07am, Huang Shijie wrote:
>> In memory_model.h, if CONFIG_SPARSEMEM_VMEMMAP is configed,
>> kernel will use vmemmap to do the __pfn_to_page/page_to_pfn,
>> and kernel will not use the "classic sparse" to do the
>> __pfn_to_page/page_to_pfn.
>>
>> So export the vmemmap when CONFIG_SPARSEMEM_VMEMMAP is configed.
>> This makes the user applications (crash, etc) get faster
>> pfn_to_page/page_to_pfn operations too.
> Are there Crash or makedupfile patches posted yet to make use of this?

I have patches for Crash to use the 'vmemmap', but after this patch is 
merged, I will send it out.

(I think Kazu will not merge a crash patch which depends on a kernel 
patch which is not merged.)


Thanks

Huang Shijie


>> Signed-off-by: Huang Shijie <shijie@os.amperecomputing.com>
>> ---
>>   kernel/crash_core.c | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/kernel/crash_core.c b/kernel/crash_core.c
>> index efe87d501c8c..9653c4177191 100644
>> --- a/kernel/crash_core.c
>> +++ b/kernel/crash_core.c
>> @@ -765,6 +765,9 @@ static int __init crash_save_vmcoreinfo_init(void)
>>   	VMCOREINFO_SYMBOL(mem_map);
>>   	VMCOREINFO_SYMBOL(contig_page_data);
>>   #endif
>> +#ifdef CONFIG_SPARSEMEM_VMEMMAP
>> +	VMCOREINFO_SYMBOL_ARRAY(vmemmap);
>> +#endif
>>   #ifdef CONFIG_SPARSEMEM
>>   	VMCOREINFO_SYMBOL_ARRAY(mem_section);
>>   	VMCOREINFO_LENGTH(mem_section, NR_SECTION_ROOTS);
>> -- 
>> 2.40.1
>>