Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
From:   "Duan, Zhenzhong" <zhenzhong.duan@intel.com>
To:     "Liu, Yi L" <yi.l.liu@intel.com>,
        "joro@8bytes.org" <joro@8bytes.org>,
        "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
        "jgg@nvidia.com" <jgg@nvidia.com>,
        "Tian, Kevin" <kevin.tian@intel.com>,
        "robin.murphy@arm.com" <robin.murphy@arm.com>,
        "baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>
CC:     "cohuck@redhat.com" <cohuck@redhat.com>,
        "eric.auger@redhat.com" <eric.auger@redhat.com>,
        "nicolinc@nvidia.com" <nicolinc@nvidia.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "mjrosato@linux.ibm.com" <mjrosato@linux.ibm.com>,
        "chao.p.peng@linux.intel.com" <chao.p.peng@linux.intel.com>,
        "yi.y.sun@linux.intel.com" <yi.y.sun@linux.intel.com>,
        "peterx@redhat.com" <peterx@redhat.com>,
        "jasowang@redhat.com" <jasowang@redhat.com>,
        "shameerali.kolothum.thodi@huawei.com" 
        <shameerali.kolothum.thodi@huawei.com>,
        "lulu@redhat.com" <lulu@redhat.com>,
        "suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
        "joao.m.martins@oracle.com" <joao.m.martins@oracle.com>,
        "Zeng, Xin" <xin.zeng@intel.com>,
        "Zhao, Yan Y" <yan.y.zhao@intel.com>
Subject: RE: [PATCH 2/3] vfio: Add VFIO_DEVICE_PASID_[AT|DE]TACH_IOMMUFD_PT
Thread-Topic: [PATCH 2/3] vfio: Add VFIO_DEVICE_PASID_[AT|DE]TACH_IOMMUFD_PT
Thread-Index: AQHaIPx2CEiCWPjIVEGBOBlj8kNZAbCNuTFg
Date:   Mon, 27 Nov 2023 06:50:36 +0000
Message-ID: <SJ0PR11MB6744B5CAC867EE643958078D92BDA@SJ0PR11MB6744.namprd11.prod.outlook.com>
References: <20231127063909.129153-1-yi.l.liu@intel.com>
 <20231127063909.129153-3-yi.l.liu@intel.com>
In-Reply-To: <20231127063909.129153-3-yi.l.liu@intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?EHRn1zR6+2/6HkOm64cGEHHjoGNc52eYglHAJRlu7GqGsQHG6yOn3dXMwqvm?=
 =?us-ascii?Q?7GFeK71DO/EdLSVSE4jdK2NJAPW9c4EZKHS4hov0iO22h20ajBI2MlR40yGg?=
 =?us-ascii?Q?lJ8OwzuWSN5rENwbZXASjV5BO2k9E9ny5sm/CuaUIf1OgcNmxW0y+GtdUv/x?=
 =?us-ascii?Q?SvhDRQwvwq6HNyFtu4WZfeM6me3ZQr6+mfKXzX1CHgSBX0SMN9x6ba5+Xpjc?=
 =?us-ascii?Q?WA0OXavB/Dt7Tqf0vutkuwefojAnv0mf3B7Br1Npqytl6WcX+MZE+trW55g3?=
 =?us-ascii?Q?Q89Fym/ElN3ZAj6YtoR/SC1nPWhcVPyXgme5Eevq0KeyO/SKlS3cXUPnVeIl?=
 =?us-ascii?Q?4rfuiLUkgnp9kVQveJ9EiYZbCqkOv4SjL5uKILqzBh/g6Djo9LFuJmfov/ie?=
 =?us-ascii?Q?Esm9q+36p4Zo43l3ZAh+HLUpYBC56JH2j4z+GXxtFcBYvNN1nMIvuJLN3XK8?=
 =?us-ascii?Q?+JTAjXcb+l/NWYJn4hEP2QwLTjNIDniVwoDU6gZ5JZ25jAgHS+jM1t+ti5Cr?=
 =?us-ascii?Q?7t/SoxkUAtcHORilyZxvxDVvCJ5dbo9IJZeIUjUkgYKStPmGq4SdEKUAsCOF?=
 =?us-ascii?Q?eLoA4wXSsL9eX0Sz9OdBY2UJ5B81Th5/5EcrEJLyg9ElrexsTPfSPtIZUtwT?=
 =?us-ascii?Q?MyqR3o84hJh1H/GfpOJQYRYNX38yG7H0vWhLexPgr5KGVD13rVoejUhC0zZf?=
 =?us-ascii?Q?+cfj9Ct5UPv4877J2svvvZjgTSL+6Qx258j8Gz4bluwWzmxnkjjssdAarAga?=
 =?us-ascii?Q?z/JUPo7/tIWlraTKYnMGqMd1qLd+nSBjDGa64tdfJpjwlvFetXVtdTRKYCZ3?=
 =?us-ascii?Q?axUKpE1HUKg44acJmwssjkjJDBUFI+ZYz0Iizft0j0c8qtZOIrVgjFvi6Par?=
 =?us-ascii?Q?2w9DjKx4l+TElwOkIeaC2oX5frlEsV4SFPID10+7a0ez1zcGo1afbESdXlt/?=
 =?us-ascii?Q?rTJW89dU7zB9sM148g+rMnZee10sdwGUUxww5rHkChyuPni+R7C/2klU7230?=
 =?us-ascii?Q?nH+jBihf4+J6Hh3n+0Gl67MAzkMkERz9QBRXYB/IF2sxcZj5S9SrwW/Qwclk?=
 =?us-ascii?Q?jf9jNAQnuVecp3sDJwCADEz18sl2T29Luf/KZmTa/S/3hKId3q4Qt2vG28aN?=
 =?us-ascii?Q?/TaAyFloj+y27qQJ0//wMWF51hqzPAC/aDR/7jsDa7yxWzYAP5a5ytsBPJvJ?=
 =?us-ascii?Q?3SgSfpkw4obC7ZQuMz2W2zCQnXl92cexzyJqY+04lljjnrWv1AJ2ey8yYHQz?=
 =?us-ascii?Q?IdWbpRPoHsMGhniOVQf6S9IlXu25rcrvAM+B5Eih7For0dcqhM0WJ5FS1Xw1?=
 =?us-ascii?Q?b3biwndHATUy9GE683/4BpGYkz4H7jMm39xG+6M9Rb1HieoZL/LJ3+7MklyJ?=
 =?us-ascii?Q?qfSV3rIPawnvT19difbhZ9tnK4p0MiDCDA127vFq98ar/ox6MVom7u/vLjTD?=
 =?us-ascii?Q?/jbEE2Gft28UKi9WgZTzlLMmbaaQhkLQRWFrXPwhMPN3ZruuoAlzJ9eie0H7?=
 =?us-ascii?Q?p6MPwObMqeT17oXEbRICyz/5pyBrque0hb6U4T8Dy8zeSvgd8wUOUgHFPzCG?=
 =?us-ascii?Q?RWh/Pq+IIwANkaaWQp+9g8wjs5cbeoGAtK8ntjM8?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB6744.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d93bc964-6260-475c-cca9-08dbef152916
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Nov 2023 06:50:36.5631
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: v+BiwjYM9IO/bz8a/0hASQc932jrcbD8aGaC62JqMIdbv8VADEPAHH4SUJXKIPCnKh3slM5w19+ddd+OgiCZ3m1DRC3wSmfrzp5hd71ca1o=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7893
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Sun, 26 Nov 2023 22:51:05 -0800 (PST)


>-----Original Message-----
>From: Liu, Yi L <yi.l.liu@intel.com>
>Sent: Monday, November 27, 2023 2:39 PM
>Subject: [PATCH 2/3] vfio: Add
>VFIO_DEVICE_PASID_[AT|DE]TACH_IOMMUFD_PT
>
>This adds ioctls for the userspace to attach a given pasid of a vfio
>device to/from an IOAS/HWPT.
>
>Signed-off-by: Yi Liu <yi.l.liu@intel.com>
>---
> drivers/vfio/device_cdev.c | 45 +++++++++++++++++++++++++++++++
> drivers/vfio/vfio.h        |  4 +++
> drivers/vfio/vfio_main.c   |  8 ++++++
> include/uapi/linux/vfio.h  | 55 ++++++++++++++++++++++++++++++++++++++
> 4 files changed, 112 insertions(+)
>
>diff --git a/drivers/vfio/device_cdev.c b/drivers/vfio/device_cdev.c
>index e75da0a70d1f..c2ac7ed44537 100644
>--- a/drivers/vfio/device_cdev.c
>+++ b/drivers/vfio/device_cdev.c
>@@ -210,6 +210,51 @@ int vfio_df_ioctl_detach_pt(struct vfio_device_file *=
df,
> 	return 0;
> }
>
>+int vfio_df_ioctl_pasid_attach_pt(struct vfio_device_file *df,
>+				  struct vfio_device_pasid_attach_iommufd_pt
>__user *arg)
>+{
>+	struct vfio_device *device =3D df->device;
>+	struct vfio_device_pasid_attach_iommufd_pt attach;
>+	unsigned long minsz;
>+	int ret;
>+
>+	minsz =3D offsetofend(struct vfio_device_pasid_attach_iommufd_pt, pt_id)=
;
>+
>+	if (copy_from_user(&attach, arg, minsz))
>+		return -EFAULT;
>+
>+	if (attach.argsz < minsz || attach.flags)
>+		return -EINVAL;
>+
>+	mutex_lock(&device->dev_set->lock);
>+	ret =3D device->ops->pasid_attach_ioas(device, attach.pasid,
>&attach.pt_id);
>+	mutex_unlock(&device->dev_set->lock);
>+
>+	return ret;
>+}
>+
>+int vfio_df_ioctl_pasid_detach_pt(struct vfio_device_file *df,
>+				  struct vfio_device_pasid_detach_iommufd_pt
>__user *arg)
>+{
>+	struct vfio_device *device =3D df->device;
>+	struct vfio_device_pasid_detach_iommufd_pt detach;
>+	unsigned long minsz;
>+
>+	minsz =3D offsetofend(struct vfio_device_pasid_detach_iommufd_pt, flags)=
;

Pasid isn't copied, should use pasid here?

Thanks
Zhenzhong