Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762387AbXK2N6M (ORCPT ); Thu, 29 Nov 2007 08:58:12 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754610AbXK2N54 (ORCPT ); Thu, 29 Nov 2007 08:57:56 -0500 Received: from e2.ny.us.ibm.com ([32.97.182.142]:38199 "EHLO e2.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752574AbXK2N5z (ORCPT ); Thu, 29 Nov 2007 08:57:55 -0500 Date: Thu, 29 Nov 2007 07:57:28 -0600 From: "Serge E. Hallyn" To: Andrew Morton Cc: Cedric Le Goater , Linux Containers , "Eric W. Biederman" , Linux Kernel Mailing List , Pavel Emelyanov Subject: Re: [patch -mm 2/4] mqueue namespace : add unshare support Message-ID: <20071129135727.GA3343@sergelap.austin.ibm.com> References: <20071128163728.177495768@fr.ibm.com> <20071128164349.196734045@fr.ibm.com> <474DA61B.5030301@openvz.org> <474E944C.4020809@fr.ibm.com> <20071129025246.a0d03eef.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071129025246.a0d03eef.akpm@linux-foundation.org> User-Agent: Mutt/1.5.16 (2007-06-09) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2220 Lines: 54 Quoting Andrew Morton (akpm@linux-foundation.org): > On Thu, 29 Nov 2007 11:28:28 +0100 Cedric Le Goater wrote: > > > >> Index: 2.6.24-rc3-mm2/include/linux/sched.h > > >> =================================================================== > > >> --- 2.6.24-rc3-mm2.orig/include/linux/sched.h > > >> +++ 2.6.24-rc3-mm2/include/linux/sched.h > > >> @@ -27,6 +27,7 @@ > > >> #define CLONE_NEWUSER 0x10000000 /* New user namespace */ > > >> #define CLONE_NEWPID 0x20000000 /* New pid namespace */ > > >> #define CLONE_NEWNET 0x40000000 /* New network namespace */ > > >> +#define CLONE_NEWMQ 0x80000000 /* New posix mqueue namespace */ > > > > > > That's it :) We've run out of clone flags on 32-bit platforms :( > > > > yes. > > > > I have been giving some thoughts to a clone2() to extend the flags > > There appears to be little alternative. Just thinking aloud, but given the concerns with the safety and sanity of unsharing only partial namespaces, and before much userspace is depending on any of CLONE_NEWUTS,CLONE_NEWIPC,CLONE_NEWUSER,CLONE_NEWNET,CLONE_NEWMQUEUE maybe we should have traditional clone only support CLONE_NEWNS (since it's the most useful on its own) and CLONE_NEWCONTAINER, where CLONE_NEWCONTAINER always unshares all the namespaces we know about. Then clone2 can allow more finegrained choice of namespaces. It takes the exact same clone_flags as clone(), but instead of parent_tidptr and child_tidptr args it has a ns_unshare flag which specifies which namespaces to unshare. -serge > > but > > andrew is preparing to recycle CLONE_DETACHED and CLONE_STOPPED for > > 2.6.26. Some we might have some more time in front of us. > > CLONE_DETACHED proved to be in use. There are no reports of anyone using > CLONE_STOPPED though. > > _______________________________________________ > Containers mailing list > Containers@lists.linux-foundation.org > https://lists.linux-foundation.org/mailman/listinfo/containers - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/