Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
MIME-Version: 1.0
References: <20231127030930.1074374-1-zhaoyang.huang@unisoc.com> <20231127071430.GA28214@lst.de>
In-Reply-To: <20231127071430.GA28214@lst.de>
From:   Zhaoyang Huang <huangzhaoyang@gmail.com>
Date:   Mon, 27 Nov 2023 16:56:45 +0800
Message-ID: <CAGWkznFf5hdFRomLXDzoxEKVgiKY--DFbHjRLAMvgvodA01EFw@mail.gmail.com>
Subject: Re: [PATCH] kernel: dma: let dma use vmalloc area
To:     Christoph Hellwig <hch@lst.de>
Cc:     "zhaoyang.huang" <zhaoyang.huang@unisoc.com>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        Robin Murphy <robin.murphy@arm.com>, iommu@lists.linux.dev,
        linux-kernel@vger.kernel.org, steve.kang@unisoc.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Nov 27, 2023 at 3:14=E2=80=AFPM Christoph Hellwig <hch@lst.de> wrot=
e:
>
> On Mon, Nov 27, 2023 at 11:09:30AM +0800, zhaoyang.huang wrote:
> > From: Zhaoyang Huang <zhaoyang.huang@unisoc.com>
> >
> > memremap within dma_init_coherent_memory will map the given phys_addr
> > into vmalloc area if the pa is not found during iterating iomem_resourc=
es,
> > which conflict the rejection of vmalloc area in dma_map_single_attrs.
>
> I can't parse this sentence.
Sorry for the confusion, please find below codes for more information.
dma_init_coherent_memory
    memremap
        addr =3D ioremap_wt(offset, size);
What I mean is addr is a vmalloc address, which is implicitly mapped
by dma's framework and not be aware of to the driver.
>
> > IMO, it is find to let all valid virtual address be valid for DMA as th=
e
> > user will keep corresponding RAM safe for transfer.
>
> No, vmalloc address can't be passed to map_single.  You need to pass
> the page to dma_map_page, and explicitly mange cache consistency
> using the invalidate_kernel_vmap_range and flush_kernel_vmap_range
> helpers.
Please correct me if I am wrong. According to my understanding, cache
consistency could be solved inside dma_map_page via either
dma_direct_map_page(swio/arch_sync_dma_for_device) or ops->map_page.
The original thought of rejecting vmalloc is that this pa is not safe
as this mapping could go in any time. What I am suggesting is to let
this kind of va be enrolled.

 static inline dma_addr_t dma_map_single_attrs(struct device *dev, void *pt=
r,
                size_t size, enum dma_data_direction dir, unsigned long att=
rs)
 {
       /* DMA must never operate on areas that might be remapped. */
       if (dev_WARN_ONCE(dev, is_vmalloc_addr(ptr),
                         "rejecting DMA map of vmalloc memory\n"))
               return DMA_MAPPING_ERROR;

>