Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp2883801rdh; Mon, 27 Nov 2023 00:58:15 -0800 (PST) X-Google-Smtp-Source: AGHT+IEmldM4Onnx1pE0MaDDzUNlJBiupdlArJt9b9QRVzHUN4c/NU2aT7B0039Co0zMjTdmHxHO X-Received: by 2002:a9d:7d11:0:b0:6d4:726f:689f with SMTP id v17-20020a9d7d11000000b006d4726f689fmr11834208otn.6.1701075495092; Mon, 27 Nov 2023 00:58:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701075495; cv=none; d=google.com; s=arc-20160816; b=Ik5VlvdrD21DNYKAVMsgIZS0NCp56z8Nyt/02jQDWhr9syhmO2GVMI/owekEBLZ7G4 P0ptkdj+9fJGSruugOEmElQmFofOsz55jqlhBrvjuMNQOphEMwiKNOb4tQhJtXzOsQWg LBQhVgCncgpijrvoSLNDPAFM4Wyc70uukPn0T6MJGVKPTXlYQSuFtB+fEKtPTAi/DkAv ykNA6fRobSK41gK6lPGjqIMzUdr4uj2hnSxdsKu01KdD+uarmHhLsHqT3/orTJz0ja4I 1bbLTUxX5wkJfomAEojGhqJMgNAOklqdqJNXfoAAB8Zs8d1D/TvxZAxYFdDnsLkfbzWa 6ZSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=XKBTcOdr0nOr20MRuzFYCNMxLCu6czawrd9wx/YsTeE=; fh=k5yM6GttLaD1I89rqziztGhEW5bXD3M2qrh1W0YaLm4=; b=EZQAOLgrOp/BrY4K4S9ijAJvxU/bhTy6Wj8yb2t6w/sB+d4YwI1TyOItgdRRlh6h1T zMpWR2Ds9nIw0IrkQIGIWgD6tc9d70sXZXwnzYdQ7sE52Rgz6utjcl0kpru4hq4fr95J bu212qBK2ioEZdZXLREyRmbabzem/6tb5BQq35RmFGmWB0Qt99hXobMnBKO5/ve72FO4 QA3G+A1/6TEI2dSBmif+CkuUNPnUDi3nHGH2GrhYM+cDkQy1OTp+eZMisu1seDweLpOC VZHpGXXs3a8NXDtWGS24FwvQ1b0ZheMB5Z4OMb1QG2Ls6G1mZaxjpfy7IH4y9Fd4JUpZ /6fw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Uk9vjKJH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id bo7-20020a056a02038700b005c2201d6a57si9923673pgb.283.2023.11.27.00.58.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Nov 2023 00:58:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Uk9vjKJH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id BD85D808EEED; Mon, 27 Nov 2023 00:58:12 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232587AbjK0I55 (ORCPT + 99 others); Mon, 27 Nov 2023 03:57:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44786 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232590AbjK0I5z (ORCPT ); Mon, 27 Nov 2023 03:57:55 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B6209187 for ; Mon, 27 Nov 2023 00:58:01 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8762CC433C9; Mon, 27 Nov 2023 08:57:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701075481; bh=vlkRKPap0wgeSnSlCOGOwGwxoaA4L0nJ8YvdUXJ/oeg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Uk9vjKJHr7sPMTPnALarecQpDW7LAKnT4LzjIEtlya1P5X9r6ERMVISFOopfB6v4h LOcELYHn2GcLnJW0rQF7EVRkBczbEiIelJtBSP0f75l31jxyugBEnozPcftGGBKhMO h1F/m5pP4Bj0zKE8KWLhL/EkS+EjMxRXzUNi4VXAwsxKvtYh0c5eDtYfLEnIYhB14M 2IBldoTCvQdKUs6fetJXUobrYghWn2iO+wsKoSibvhBDcAPwvyKB6P2KZZZ0e4KVIY H32nAcxfn0HJOv1ZCzS/jvfkgCTRR0xXvgigSDl4XefjL85MCyIPCwJw0/c3Rn+KvF lDgVnLqpRt4RA== Date: Mon, 27 Nov 2023 08:57:55 +0000 From: Lee Jones To: Dmitry Rokosov Cc: pavel@ucw.cz, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, andy.shevchenko@gmail.com, kernel@sberdevices.ru, rockosov@gmail.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, George Stark Subject: Re: [PATCH v4 04/11] leds: aw200xx: calculate dts property display_rows in the driver Message-ID: <20231127085755.GE1470173@google.com> References: <20231121202835.28152-1-ddrokosov@salutedevices.com> <20231121202835.28152-5-ddrokosov@salutedevices.com> <20231123163252.GF1354538@google.com> <20231124094146.qsgmmbwulemjikpg@CAB-WSD-L081021> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20231124094146.qsgmmbwulemjikpg@CAB-WSD-L081021> X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Mon, 27 Nov 2023 00:58:13 -0800 (PST) On Fri, 24 Nov 2023, Dmitry Rokosov wrote: > On Thu, Nov 23, 2023 at 04:32:52PM +0000, Lee Jones wrote: > > On Tue, 21 Nov 2023, Dmitry Rokosov wrote: > > > > > From: George Stark > > > > > > Get rid of device tree property "awinic,display-rows". The property > > > value actually means number of current switches and depends on how leds > > > > Nit: LEDs > > > > > are connected to the device. It should be calculated manually by max > > > used led number. In the same way it is computed automatically now. > > > > As above - I won't mention this again. > > > > > Max used led is taken from led definition subnodes. > > > > > > Signed-off-by: George Stark > > > Signed-off-by: Dmitry Rokosov > > > --- > > > drivers/leds/leds-aw200xx.c | 39 +++++++++++++++++++++++++------------ > > > 1 file changed, 27 insertions(+), 12 deletions(-) > > > > > > diff --git a/drivers/leds/leds-aw200xx.c b/drivers/leds/leds-aw200xx.c > > > index 7762b3a132ac..4bce5e7381c0 100644 > > > --- a/drivers/leds/leds-aw200xx.c > > > +++ b/drivers/leds/leds-aw200xx.c > > > @@ -379,6 +379,30 @@ static void aw200xx_disable(const struct aw200xx *const chip) > > > return gpiod_set_value_cansleep(chip->hwen, 0); > > > } > > > > > > +static bool aw200xx_probe_get_display_rows(struct device *dev, struct aw200xx *chip) > > > +{ > > > + struct fwnode_handle *child; > > > + u32 max_source = 0; > > > + > > > + device_for_each_child_node(dev, child) { > > > + u32 source; > > > + int ret; > > > + > > > + ret = fwnode_property_read_u32(child, "reg", &source); > > > + if (ret || source >= chip->cdef->channels) > > > > Shouldn't the second clause fail instantly? > > > > We already have such logic in the aw200xx_probe_fw() function, which > skips the LED node with the wrong reg value too. Furthermore, we have > strict reg constraints in the dt-bindings parts (in the current patch > series), so we assume that the DT developer will not create an LED with > the wrong reg value. Why is it being checked again then? -- Lee Jones [李琼斯]