Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley
        Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United
        Kingdom.
        Registered in England and Wales under Company Registration No. 3798903
From:   David Howells <dhowells@redhat.com>
In-Reply-To: <20231122214447.675768-1-jannh@google.com>
References: <20231122214447.675768-1-jannh@google.com>
To:     Jann Horn <jannh@google.com>
Cc:     dhowells@redhat.com, Boris Pismenny <borisp@nvidia.com>,
        John Fastabend <john.fastabend@gmail.com>,
        Jakub Kicinski <kuba@kernel.org>,
        "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] tls: fix NULL deref on tls_sw_splice_eof() with empty record
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1508420.1701075853.1@warthog.procyon.org.uk>
Date:   Mon, 27 Nov 2023 09:04:13 +0000
Message-ID: <1508421.1701075853@warthog.procyon.org.uk>
Precedence: bulk

Jann Horn <jannh@google.com> wrote:

> +	/* same checks as in tls_sw_push_pending_record() */

Wouldn't it be better to say what you're checking rather than referring off to
another function that might one day disappear or be renamed?

David