Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Date:   Mon, 27 Nov 2023 09:20:41 +0000
From:   Conor Dooley <conor.dooley@microchip.com>
To:     Krzysztof Kozlowski <krzk@kernel.org>
CC:     Sia Jee Heng <jeeheng.sia@starfivetech.com>,
        <paul.walmsley@sifive.com>, <palmer@dabbelt.com>,
        <aou@eecs.berkeley.edu>, <conor@kernel.org>, <kernel@esmil.dk>,
        <robh+dt@kernel.org>, <emil.renner.berthing@canonical.com>,
        <linux-riscv@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
        <leyfoon.tan@starfivetech.com>
Subject: Re: [PATCH 7/7] riscv: dts: starfive: Add initial StarFive JH8100
 device tree
Message-ID: <20231127-undying-sauciness-a5c1a2e7c89b@wendy>
References: <20231127013602.253835-1-jeeheng.sia@starfivetech.com>
 <20231127013602.253835-8-jeeheng.sia@starfivetech.com>
 <20b13322-3cd1-47b1-bb39-2710ddc59a11@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="UIZ7q/jzaCkPlcNJ"
Content-Disposition: inline
In-Reply-To: <20b13322-3cd1-47b1-bb39-2710ddc59a11@kernel.org>
Precedence: bulk

--UIZ7q/jzaCkPlcNJ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Nov 27, 2023 at 09:50:35AM +0100, Krzysztof Kozlowski wrote:
> On 27/11/2023 02:36, Sia Jee Heng wrote:

> > +	chosen {
> > +		stdout-path =3D "serial0:115200n8";
> > +	};
> > +
> > +	cpus {
> > +		timebase-frequency =3D <4000000>;
>=20
> This was fixed recently on the mailing lists.

Actually, I only fixed this for the microchip stuff, as I don't know
whether or not having this in $board.dts is valid for other cases.

As far as I understand it, this works just like regular clock nodes, so
if the clock is provided by an off-chip crystal it is okay to have it in
$board.dts, but otherwise it should go in $soc.dts.

The same applies to the jh7100/jh7110, so if you could clarify it for
that platform too, that'd be great. Doing it in response to
https://lore.kernel.org/all/20231126-attractor-swampland-b1b95bd1322b@spud/
would be great.

Thanks,
Conor.

--UIZ7q/jzaCkPlcNJ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZWRfZQAKCRB4tDGHoIJi
0gHWAQC+qna0EhtpL1qCEG6ofq0rMPUV6Ic0TYQILJz5IPX2AgEAgjxLKeIm8q6D
LemVXtIRAcw5kl6QPfdqlkh2VPQxrww=
=P5+r
-----END PGP SIGNATURE-----

--UIZ7q/jzaCkPlcNJ--