Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp2899644rdh; Mon, 27 Nov 2023 01:27:49 -0800 (PST) X-Google-Smtp-Source: AGHT+IEkHBMtnVGP4v0I5qv2bhtcS+UisEHSVLoxK/9uzSwosfnDTqBcPfDcnYlasmbBEFZMTBUq X-Received: by 2002:a05:6a20:3d14:b0:18a:b5c3:55da with SMTP id y20-20020a056a203d1400b0018ab5c355damr14054801pzi.10.1701077269164; Mon, 27 Nov 2023 01:27:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701077269; cv=none; d=google.com; s=arc-20160816; b=pQsbWV6iOUSGGmO/YXNSGmFnat3dR4vCZaadpg0tz3mq8TfMOwvojBNYWZqmqJm7OA 6UVOkkZDDBsbasoNKXVJX8dUWb5IjZtGWWZu3N96vMErLbGD9iLHa/PXeOX0NmwGs1tL p7j/gfOFKoWAkMDzuVkpUDVdLO/IOwYvDxAHZ0+G/wqowSL4jBqVrfJclTd0kA424TSi DzU5MUX977fwB/bVLlRbp3pAHmTMdIyLhuza2Y0Za5gu2zJM+V8O3gZq3hangDm1p8wr XJnliURQDMkTbgVTsq4HhaPwBOMLwYbgyDJM9y72Gwe8vFNlACkGubealF/HDGq7WXwe mnRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=PjiFJfdeRFV6QLpBQ/gRzy/hxF/Hxt0YgFLXIqtXX0U=; fh=hK7CehTx5qVHFzeOf+I53wh7bx8IUqdLaGLA5LcDaIU=; b=TnGFGna+SHn9G6HULpxbl9Wd2iN6wIJdDTUw2qyuj8vRAoMOQ09hLJZ1wh1BuVb332 upA8bzAbsshIc57wUQxt7sTdEaadTS6BiFz83DlsekyrRVG3Hrt2M+9x04Bkv+hSvJBA L6cUQ1q4rJBD64EVqjhxlwkB5GtuQ2pzDp5BOP9/OjFSc0SVgOO9egr0zIzOofzRZpRU XeJBRrxYhkyKNs10fZ1EAK6PKvtVq6ZlMyvfDyPbpomBblANxrSZrYmfna26B/IIF1iq qI+TjOnwrGVbBeRn9M9WgrFxW+8TtRfLYFzVnz9J2s20FgM/xznNCHiEqNyxIuSDduNH BPLw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@8bytes.org header.s=default header.b=wK6npJ2b; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id ef23-20020a056a002c9700b006cc05369349si4874914pfb.84.2023.11.27.01.27.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Nov 2023 01:27:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@8bytes.org header.s=default header.b=wK6npJ2b; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id BB7928092DB2; Mon, 27 Nov 2023 01:27:47 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232721AbjK0J1h (ORCPT + 99 others); Mon, 27 Nov 2023 04:27:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231339AbjK0J1g (ORCPT ); Mon, 27 Nov 2023 04:27:36 -0500 Received: from mail.8bytes.org (mail.8bytes.org [85.214.250.239]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 859B7DE; Mon, 27 Nov 2023 01:27:42 -0800 (PST) Received: from 8bytes.org (p4ffe1e67.dip0.t-ipconnect.de [79.254.30.103]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.8bytes.org (Postfix) with ESMTPSA id 673DD1A6646; Mon, 27 Nov 2023 10:27:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=8bytes.org; s=default; t=1701077261; bh=vQpNvz4tXNOtI3SlzAQTo7xVyAAZoeAnZPoiW7Qf4yI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=wK6npJ2bcjwrxH2HlnrnFuv3U6BXMzV9ySKpHZ/ytEtanu18iYp44zYiEtdrNqnKg n6OxL3FoUAxP+sa6K3aj8GpIgusAMtDAPARHcgyCpX6CCy3IrC9aGQnsfaWnzxxw0Z aGQcSKI0Tx18jy3ac7oS7YIDUTmkIlcbgn6Lz7d0Zcll7Zrb/KWjFmn6KYovkJu9+I 6fO9BOzaPPK/CllYtcYn2occgUdM4L3iuVAkZiCON1QpvmrlbC0zN7Sps8zLkwWgkG sACRHpl+ORx50VUR4T5Co7YdINguOj7wXtHbtI+/tyNahHL3+YgzLNdeMsiJT0NICT gsgPimnep7BUw== Date: Mon, 27 Nov 2023 10:27:40 +0100 From: Joerg Roedel To: Dario Binacchi Cc: linux-kernel@vger.kernel.org, Baolu Lu , Jonathan Hunter , Krishna Reddy , Robin Murphy , Thierry Reding , Will Deacon , iommu@lists.linux.dev, linux-tegra@vger.kernel.org Subject: Re: [PATCH v2] iommu/tegra-smmu: drop error checking for debugfs_create_dir() Message-ID: References: <20231025152609.2042815-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231025152609.2042815-1-dario.binacchi@amarulasolutions.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 27 Nov 2023 01:27:47 -0800 (PST) On Wed, Oct 25, 2023 at 05:25:58PM +0200, Dario Binacchi wrote: > The return value of debugfs_create_dir() should be checked using the > IS_ERR() function. The patch, however, drops the check statement without > fixing it because the subsequent functions (i. e. debugfs_create_file()) > can handle the case where `@parent` is an error pointer. This deserves a comment in the code explaining why no error checking is needed. Regards, Joerg