Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp2900333rdh; Mon, 27 Nov 2023 01:29:24 -0800 (PST) X-Google-Smtp-Source: AGHT+IE3dpn9GJ1Ri0pHUhZiXXlsU2lVfGlRw6BGJv8+rYzShky8IslhIyi+doUC78K/B/4hHAXU X-Received: by 2002:a17:902:ecce:b0:1cf:7683:93e with SMTP id a14-20020a170902ecce00b001cf7683093emr14238152plh.24.1701077364536; Mon, 27 Nov 2023 01:29:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701077364; cv=none; d=google.com; s=arc-20160816; b=jx0hWD9fmzmf4bG31bx8l137d4agvkaIMaMMIyS3XgtWu01GiQ+n8k9nvhYHdrhN/1 oSpmUpubuCmP+CHGtLh/EsMqRqYuuzAAznLQOLH0RktIuexJbisjh5yZMJl1UAaPDweI NIWtFnE15D4f742lmuI8eYvkWhckvya0cw7J0MqKknXA0iDeEViz2yk4RYm5ympItEW+ Zwmnw05vkAUx79PwQ3d8INyU5od3lPfQ7dsOP9l3oumooW/xdrqr7Dvo7s6WiGNESfHV g79Vshd9SA4TlCJqHwySQGUmkaN3c//rVEIpWEAmuxZOv3ijmIv9XhFWpNyDxp3TfZ33 VZJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:autocrypt :from:references:cc:to:content-language:subject:user-agent :mime-version:date:message-id:dkim-signature; bh=cgDlP4W9ViNQMuWoNBhHwLt5SnZN6uMb4gJdU/SNPRE=; fh=Fe39KC9bmqKU1PF7N/wGP11Qz+erFX/yiHvCS04ejzE=; b=AewUwmatDqslIYLA3lnOBn/d8sYx8Y2fpETeABAnLxbiYkOO5R6DlkRrMQqEO560q0 1BHFuYtfc8o8xb3oFoSruR16pj9G6/lAvJUdb5jd13VQYNdiA0vLGCuY4u1KckO1B+Sx o6Xz45ccGclYxc2OSTAtf5Xsp7FKjiWdkmigpiC1mo7JvtuiYa2zF/KJ2TE+ja9CCpCL Xu4D4OaVhsBllIC1H2ineCpMTdosd3no3qQciBVDLhztXij4gmIC7Jzb8km3qy/rmayE 8PXoQGNvG9hR64Mv+jTNHf/Bq4R/mAVaVXCLqq/CFaHso8BWg4U5tJVyLCD0X0JRKeci M/8g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hKIVieMp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id ju12-20020a170903428c00b001cf58065627si8992856plb.303.2023.11.27.01.29.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Nov 2023 01:29:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hKIVieMp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 6BA488061CEE; Mon, 27 Nov 2023 01:29:21 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232796AbjK0J3E (ORCPT + 99 others); Mon, 27 Nov 2023 04:29:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55284 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232686AbjK0J3D (ORCPT ); Mon, 27 Nov 2023 04:29:03 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 42A84BE for ; Mon, 27 Nov 2023 01:29:10 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C096CC433C7; Mon, 27 Nov 2023 09:29:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701077349; bh=vrM5PO5L02NedrfTtlg7Lu4UoGwcKQj8F5Urwi0qnfk=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=hKIVieMp/jskjJ7KKqiL2H0gKcWPZnVG7ZzV+jJClgOwOLlAj5F9XEemWM2SMTlsr wUNNRf3FAnQv1I+MduQZppjLPKdRpm2GNyzYUTVb6+Ro+Tzx2lJFhuyd2eM/tEhsDL bYZkKzzt1jAC9PzdAkQVhzwqUmBa0ZsGYJa6WeXajAuY0krprgyBqDtC//6MjL1EJH stAzyd7YN3kwt1bjQpZX3/j+vpkerifwZtncCGl8NP4Z9W9Bus3qbJv1WtcxS5Vxi0 TXMbfOpd2GtOJx4Bh1Ule7jWLFrRKePNloF1OGLFW/jHRmdlb3bUXVMmFm2IAxuT4C rMPYd5Knsk1mw== Message-ID: Date: Mon, 27 Nov 2023 10:29:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 7/7] riscv: dts: starfive: Add initial StarFive JH8100 device tree Content-Language: en-US To: Conor Dooley Cc: Sia Jee Heng , paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, conor@kernel.org, kernel@esmil.dk, robh+dt@kernel.org, emil.renner.berthing@canonical.com, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, leyfoon.tan@starfivetech.com References: <20231127013602.253835-1-jeeheng.sia@starfivetech.com> <20231127013602.253835-8-jeeheng.sia@starfivetech.com> <20b13322-3cd1-47b1-bb39-2710ddc59a11@kernel.org> <20231127-undying-sauciness-a5c1a2e7c89b@wendy> From: Krzysztof Kozlowski Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <20231127-undying-sauciness-a5c1a2e7c89b@wendy> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 27 Nov 2023 01:29:21 -0800 (PST) On 27/11/2023 10:20, Conor Dooley wrote: > On Mon, Nov 27, 2023 at 09:50:35AM +0100, Krzysztof Kozlowski wrote: >> On 27/11/2023 02:36, Sia Jee Heng wrote: > >>> + chosen { >>> + stdout-path = "serial0:115200n8"; >>> + }; >>> + >>> + cpus { >>> + timebase-frequency = <4000000>; >> >> This was fixed recently on the mailing lists. > > Actually, I only fixed this for the microchip stuff, as I don't know > whether or not having this in $board.dts is valid for other cases. > > As far as I understand it, this works just like regular clock nodes, so > if the clock is provided by an off-chip crystal it is okay to have it in > $board.dts, but otherwise it should go in $soc.dts. > > The same applies to the jh7100/jh7110, so if you could clarify it for > that platform too, that'd be great. Doing it in response to > https://lore.kernel.org/all/20231126-attractor-swampland-b1b95bd1322b@spud/ > would be great. OK, then it should be added via label syntax, not by full node path. Best regards, Krzysztof