Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Message-ID: <54728d1f-2c57-4cb8-a1e2-de2bf0c8cd64@intel.com>
Date:   Mon, 27 Nov 2023 10:48:06 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [net-next PATCH v4 1/2] octeontx2-af: Add new mbox to support
 multicast/mirror offload
To:     Suman Ghosh <sumang@marvell.com>, <sgoutham@marvell.com>,
        <gakula@marvell.com>, <sbhatta@marvell.com>, <hkelam@marvell.com>,
        <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
        <pabeni@redhat.com>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <lcherian@marvell.com>,
        <jerinj@marvell.com>, <horms@kernel.org>
References: <20231126184315.3752243-1-sumang@marvell.com>
 <20231126184315.3752243-2-sumang@marvell.com>
Content-Language: en-US
From:   Wojciech Drewek <wojciech.drewek@intel.com>
In-Reply-To: <20231126184315.3752243-2-sumang@marvell.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YWUrMWo3aE5waWlpYzVRdDBwS1k4QTBxR3AzL1k4bWFpaDhvZkg4RGNDb0Qx?=
 =?utf-8?B?RDBiL3pQRGhZY294cWFRdlFST3RUN2hCU2xRWUNpMDdlQ3FuZXcrdnJyOFl3?=
 =?utf-8?B?U3RWSzZkRm96UyswSnV5TDJMSFpYWW9hSG81M3NvU2N3OUp4a1ZmdE9uOXNZ?=
 =?utf-8?B?NGQvQ3MrWlI0ZzFKV3hocW93anBvN2V5YVNwaDQ2bXIrVjRJamRRUmRId3hv?=
 =?utf-8?B?RVQrTFNJcGJuQ2Z3MXpvR2Fmd2ZxTHhVTWNCRFRhMkUzcy96SVExeWFabVo2?=
 =?utf-8?B?ZFVZNVFKaVUyeG5jV25wU3I5SzNBTU1Wb1VYQ0czazhLSG9qSElDOThYeVl4?=
 =?utf-8?B?UCt2N2JQN1ZJWXgzLy9oeE9kSExNbm5aMzlXOWhiV0p1MHJJWTZzcXNCTERj?=
 =?utf-8?B?Smg1YXlHV2RsU1lEQTByU2p2SE1DNGIxaEtqQUxiY1VTaElQSklGd0tHTUhP?=
 =?utf-8?B?SXlsL0lBTVRoYUJNQnJ3YTVoRzVQSkdQY3h5elExaHJPUTBha0dmNHcreDZu?=
 =?utf-8?B?L2IyZlhtYUM2K3JxRHUvb1drWHNNM3d4TlNGdnpxbzlJUXkvOC9Md0xMU0N0?=
 =?utf-8?B?bkFzZ2NWMHNJRnpUcXNqZUdTRUpFWkpzeVpNV2Q2cTVPM1FoZFRhRmViZXdB?=
 =?utf-8?B?d0hoSTdFeU1abCtXcUhJYWo2aDJPOXVlMVlPVXA1Z1NvZEoyNkhOVUxQWkFT?=
 =?utf-8?B?N2pDVEk2Vno1YTI3ZW5PLzhsaTRFbzMyTGdEQklCWG85TFV2bnZPUzQ2YjV5?=
 =?utf-8?B?d2NKWjZpT2d1QUpKS2NyY1lySWF2a2V0MkRyVDlGWEFBMkFhT0QzYi9rT3lh?=
 =?utf-8?B?Z05jSjZNeUpmN0ZDMnlKYy9hZ1dEaFlmWlViQmZCUkM1TmNPRDNTQXVXZ202?=
 =?utf-8?B?SVRudENRSGxiR3lEcFo0VTEzaXNFNHNwK0N2eHRoSzFFelgxcWovTlZvYkJj?=
 =?utf-8?B?dE8rN2xrMytFWE0yN09Ma05aNDBuSjAwWmlaYzZQekNKZ2J2V1NDZnQzWGxi?=
 =?utf-8?B?MG9Vb0ZSM1Y3RnBNUFluUDB4SU1SZUdDK0VYRFB3eEhWbzRKTGtQcnVXK2ZG?=
 =?utf-8?B?bERXTUI0VjdMS0p1aXUydWUxSXRhRlhGTG5MVEpJRE9IcVlKMVM4UzlzUGUz?=
 =?utf-8?B?N3RycFowRkhLSnNIVFFOUnNrbDJXd2VaS1Npd1hrU0h4L2d6czk1MmtVUlND?=
 =?utf-8?B?MEMvYmhMd0hhOERsRUFuUWVHa0pTSHF5TzZ2Wlc3WHR4R1FrblJUbll4ZHpj?=
 =?utf-8?B?ejE0T0FKQTREOW85U2pPa0ZOaTgwb252RTExNWNPVC93R1ZNNGtqbXc4QzJl?=
 =?utf-8?B?OEVBdVl0c2pzcGtXMHJrejlSRk1YTlRha0hqZ1R4QUhtbEgvZHZsQ0FzUjV5?=
 =?utf-8?B?ZTcvS2RvK2t2ZDVhYUo2bXl4K1JaZldESjZ6WmVqWTdjZllMU2t0WTRZSGxt?=
 =?utf-8?B?T3c1VVZybzcySmNXZ3FyVElUa1l2bHJzYmRPckovNUlUclUyNUxGdWd1N2dT?=
 =?utf-8?B?UTRnUTl1T1ZBdG9UMThJOHV4NEdMQTVjZ0ZYeVI4V1Zmb0dBbWRjejYrMXZX?=
 =?utf-8?B?aCt3VENuYUZycTZsNVgwUVNyaGRvd1RtdFZhdDFkMTA1SGpyZW1jaG9CaWdl?=
 =?utf-8?B?eUVmallSRG1jT1VwQi85UHo4Mmw1bzlpWXFvWVBmUHVFVlRFdDZGRVNEMTdj?=
 =?utf-8?B?WnRHaEdNZlZUYUtvU0dwQWNlS2RGVFd0bjB1amtCWFZCNHZwODd0Rk5RU2Yx?=
 =?utf-8?B?bEkySjBxeXl6THRVVzM4VTZuL1JjRzZSRFZ6NGVzdU5LRFgwSWsreGNTZThi?=
 =?utf-8?B?STZWS0kybldsaTFKeXJLSlhGaXhGY2trazBGaDlTSWVJRHJGczlaMmJsMmpZ?=
 =?utf-8?B?RkhTc1lDb0d5SUh0ZXhJS0d0NEZNNDAyMmg5czI4amRMUmZpNmRYOEFoVnBi?=
 =?utf-8?B?Mk5HT0pjdEM1SGw5YlhZQ0pJeFVEOWZqWXB6ZGd5cjN6MTZFWUcrKzNUL3N4?=
 =?utf-8?B?Uk0ycFluL0k5c1hoSTZpcEJ2RzBUQ05oVERmWC8wazNyNHUvOUNhYXNaWlps?=
 =?utf-8?B?ejQrdzhMNys4cGlkL1hSVlZjdEhYekxzMHB0MUxERW5iSEkyYWR3VVpidTJL?=
 =?utf-8?B?dVFGRGlsUzJJTFNlQTZlTWk4TXJvSExwSkFYdnJBM0Y4cm5Yb1ZjdkhxRW82?=
 =?utf-8?B?MkE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ca78f457-0f2c-402b-56dc-08dbef2df867
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5782.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Nov 2023 09:48:12.5737
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: z1HwnP/177CSJVSukgKlILCoBCqb5m+wlkyg6KaK1xgA6GOiTLMxMrQtXGpUU6rJFhKvWQgbTdHurhP0PO5jzWs4Bi3MfO3NSiCiXNi0/dQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5543
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 27 Nov 2023 01:48:26 -0800 (PST)


On 26.11.2023 19:43, Suman Ghosh wrote:
> A new mailbox is added to support offloading of multicast/mirror
> functionality. The mailbox also supports dynamic updation of the
> multicast/mirror list.
> 
> Signed-off-by: Suman Ghosh <sumang@marvell.com>
> ---
>  .../net/ethernet/marvell/octeontx2/af/mbox.h  |  72 ++
>  .../net/ethernet/marvell/octeontx2/af/rvu.c   |   6 +-
>  .../net/ethernet/marvell/octeontx2/af/rvu.h   |  39 +-
>  .../ethernet/marvell/octeontx2/af/rvu_nix.c   | 701 +++++++++++++++++-
>  .../ethernet/marvell/octeontx2/af/rvu_npc.c   |  14 +-
>  .../marvell/octeontx2/af/rvu_npc_fs.c         |  73 +-
>  6 files changed, 867 insertions(+), 38 deletions(-)
> 

<...>

> +
> +static int nix_add_mce_list_entry(struct rvu *rvu,
> +				  struct nix_hw *nix_hw,
> +				  struct nix_mcast_grp_elem *elem,
> +				  struct nix_mcast_grp_update_req *req)
> +{
> +	u32 num_entry = req->num_mce_entry;
> +	struct nix_mce_list *mce_list;
> +	struct mce *mce;
> +	int i;
> +
> +	mce_list = &elem->mcast_mce_list;
> +	for (i = 0; i < num_entry; i++) {
> +		mce = kzalloc(sizeof(*mce), GFP_KERNEL);
> +		if (!mce)
> +			goto free_mce;
> +
> +		mce->pcifunc = req->pcifunc[i];
> +		mce->channel = req->channel[i];
> +		mce->rq_rss_index = req->rq_rss_index[i];
> +		mce->dest_type = req->dest_type[i];
> +		mce->is_active = 1;
> +		hlist_add_head(&mce->node, &mce_list->head);
> +		mce_list->count++;
> +	}
> +
> +	mce_list->max += num_entry;
> +
> +	/* Dump the updated list to HW */
> +	if (elem->dir == NIX_MCAST_INGRESS)
> +		return nix_update_ingress_mce_list_hw(rvu, nix_hw, elem);
> +
> +	nix_update_egress_mce_list_hw(rvu, nix_hw, elem);
> +	return 0;
> +
> +free_mce:
> +	hlist_for_each_entry(mce, &mce_list->head, node) {

I belive that hlist_for_each_entry_safe should be used when deleting list entries.

> +		hlist_del(&mce->node);
> +		kfree(mce);
> +		mce_list->count--;
> +	}
> +
> +	return -ENOMEM;
> +}
> +
>  static int nix_update_mce_list_entry(struct nix_mce_list *mce_list,
>  				     u16 pcifunc, bool add)
>  {
> @@ -3079,6 +3301,7 @@ int nix_update_mce_list(struct rvu *rvu, u16 pcifunc,
>  		/* EOL should be set in last MCE */
>  		err = nix_blk_setup_mce(rvu, nix_hw, idx, NIX_AQ_INSTOP_WRITE,
>  					mce->pcifunc, next_idx,
> +					0, 1,
>  					(next_idx > last_idx) ? true : false);
>  		if (err)
>  			goto end;

<...>