Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Message-ID: <18b2ad8e-6b06-407a-a141-91a90ee7cffd@kontron.de>
Date:   Mon, 27 Nov 2023 12:23:36 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/3] usb: misc: onboard_usb_hub: Print symbolic error
 names
Content-Language: en-US, de-DE
To:     Frieder Schrempf <frieder@fris.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
        Matthias Kaehlcke <mka@chromium.org>
Cc:     Alexander Stein <alexander.stein@ew.tq-group.com>,
        Anand Moon <linux.amoon@gmail.com>,
        Benjamin Bara <benjamin.bara@skidata.com>,
        Rob Herring <robh@kernel.org>,
        =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
References: <20231127111332.107640-1-frieder@fris.de>
From:   Frieder Schrempf <frieder.schrempf@kontron.de>
In-Reply-To: <20231127111332.107640-1-frieder@fris.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NkxiQlBzUXV1eUZFNmlFY0xyL09kOWZLQ1poS1R4bXpEbXZJU0dNOFFKcGRz?=
 =?utf-8?B?QkNmRDVmaGdONU9vbmtoQzZYQ1JvMFd3ZkNFd2VKdC81Q1Fidlh6dVA1RnZQ?=
 =?utf-8?B?dHl2M09pK0Fub29OKy9mQms2RFRJczk4Q1dqQzZ3WE9RWFMwMkRJclB5QnJz?=
 =?utf-8?B?Qi9WbEtML0RWazA5UXlMVnlGTjl2ekpuLzE1VDY4c1orWnY1OXJHMW81UGxO?=
 =?utf-8?B?WGhHTEtxVE5hd3V6VGkwRG5JUlM5MDYrcmR1dHlZdzRwZVgyMnVUak1RblA1?=
 =?utf-8?B?cUhZWVZ4NndNeTBwS3JTTXpUQnF2MmZXMHMrck9QK2VLVTloT1E1dG5sMEM0?=
 =?utf-8?B?cmVkSzN0b3FmM3ZsbFIyc2FBM1YwRVBRVUxWRWlQdmVzVTJHU0Z0SlZISEE5?=
 =?utf-8?B?ek9PQWMyaEFFMklYeENVUDhOZDFYUnJQZC9DUnF5MUY0WnA5bEF0cE80WENn?=
 =?utf-8?B?dlpZaVFENm9UcDZHQjVqYXRZOVd0SmJ4UjhhZE5FSTRJRDFXQ204Z0lFRnk5?=
 =?utf-8?B?blVzOE1ZMElqQkxJY1VNRlFqZmJlVWVSVDE1UWRFa1NWUW1qOEl5VkFoWWhh?=
 =?utf-8?B?dkFGTVliMFV2UzRicG9PcDlSZ3lGYnhPaFE4T0JTaFBVcEtrNDcxaWwvU1V3?=
 =?utf-8?B?NDdjY20xRWtkZjNicWU3TTZuK2dTSS8vSmI0eEV4Nld4d3JValBTcHZ0b0VT?=
 =?utf-8?B?eG1CUGhuZ3RTZmZXSnJ2Z3FjQWNrc2xTeGRCT1FNaFd2Y0kyYmNaSWJSR2pO?=
 =?utf-8?B?citRZXovRHFOOXBkKzNCL01jUnFGTytiNnhRNnJiUmpqcnpTSmlDLzZDWEZz?=
 =?utf-8?B?WHBSRFpnWlkvcHkxeTlocExoTndLSWtGazFha3pTTU1EVzFsV2dMOC82Umgy?=
 =?utf-8?B?M3lsVy85RDBYbG8xRGdpQnpHSTBnc3VPVlQ4SkQxVkFER2xDR2FmQk5oaXFk?=
 =?utf-8?B?Z2srRDBJT1U1YmFJdm8xR042T1doVnlUNytXSjNUUytpZDY3bWdFVzBmUXN6?=
 =?utf-8?B?Z2YvZzY3LyszLzZpUUUxL0oxRjhmekFmWmVKWnhkUTBHbzVSYUp6M2htQ1pn?=
 =?utf-8?B?R3JuSVd3VHRjb2tMMFA4QTI2WUFTSDJnWS8rbnVHNFFQU3c1SWR6N1NUNm9H?=
 =?utf-8?B?dEs3ekNIUWNBQTN3Zzd6K1F3TzdBb2JSOVhsZGI1T09EeFFZT0txZWNTOFYy?=
 =?utf-8?B?MEYyR1Z5d2tKS3llVFZxWkJiL2ZuZGZEUmU5N2I2TmV5SjR4ZG1GL21Ya2VW?=
 =?utf-8?B?cE1oSWQyTkdyVnFYS0ZEOUF6cUR4NHdyM1VGL3grSHZBUEVxdWE2K3p3V1Zn?=
 =?utf-8?B?b0IwK0ZFWjFsR1o3RjlKUFQzalJrUHUySU11U0YvNXlhSFRPZWhFdmtzK3E3?=
 =?utf-8?B?cGJZYllTYmJjQjhVU2QvT0VaSTlMNUJoblk0WUh3Y3JKVjZaQ0ZZdml1L3dk?=
 =?utf-8?B?VzZsQXBXdndDWWd4QWVHSGlZRkl2Mno1ZUIxdlpVWVhySS9SWW1taERJL1Z3?=
 =?utf-8?B?S1NBeWFSQ2hHVmlaSEREQjMzejV0MDNqSVA4NUkrTzlCM25HUmVvL2FmbGda?=
 =?utf-8?B?eU10VGYzYWU0UGNpZGdSNTJaTlo2T1RpQnlRbXBSUU9jZzV5VmxZMXZUOTNo?=
 =?utf-8?B?Wi93U2NpV1lVT2R5c2JYamk4U3l6L0tKMUhMQTV2d2N1a2ZhaExKeHA4cHR4?=
 =?utf-8?B?eFdrTFMvL1MvQmEyRm5jVEFUaEVXaVhYRGNNM3lwWS9YZXlCNFE5aUJnMTNR?=
 =?utf-8?B?MEg3TDR3TEprVDk2SVlid3c3QVhMZDByMExUN1dncXdNUUswM0NtM2pXQkVB?=
 =?utf-8?B?R0cwYlpiRE8ySnB0Qkd3WXFVMkVoSGtqbmpDRFh5dHh5ZlpZTmd2ak1hbzRG?=
 =?utf-8?B?ZXZBMDgxKzFCUXJYVlRIQkpmaE1GaWpTNDRXTEJBZVB1VTFqQlQrdktyTmZJ?=
 =?utf-8?B?aEpYWDkydDl6emttOEVaUWtGaC9XS3hoYllMTGszaXN1ZVVFOWR5RnZhUWJp?=
 =?utf-8?B?UzlLMTZqNnZwd2VUN0sxcXY0K09lbVBnOThlOFJIa3labFdybmM0YjJDc00w?=
 =?utf-8?B?MEZHUDNjbk5kZ212RUpCSVdkdWNTNFdsYzJtbnc0ZDVpVkNITFIzUnJFV0Np?=
 =?utf-8?B?K3BTNnN1MVFCTE5EOUVad29WUVRzNTV3QlZMcHRyUUtDVVF3V0w2N3VtTEkw?=
 =?utf-8?B?ZVE9PQ==?=
X-OriginatorOrg: kontron.de
X-MS-Exchange-CrossTenant-Network-Message-Id: ef827cfe-8bf9-4543-83c4-08dbef3b4d14
X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5681.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Nov 2023 11:23:37.9572
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8c9d3c97-3fd9-41c8-a2b1-646f3942daf1
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: N9QYDyZ7Sxk4+i+0qCVwmFS02QyBk1ZsSA42FbfJLfohyX0IydsEIL5dN7SVUrn8HDJlqQCp/QR3iin/+F+UhW+V1C1+UJ8Eqh6dcw2JXto=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR10MB8198
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Mon, 27 Nov 2023 03:23:55 -0800 (PST)

Sorry, forgot to add the correct version prefix v2 in this series. I
will resend.

On 27.11.23 12:13, Frieder Schrempf wrote:
> From: Frieder Schrempf <frieder.schrempf@kontron.de>
> 
> Instead of printing the decimal error codes, let's use the more
> human-readable symbolic error names provided by the %pe printk
> format specifier.
> 
> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
> ---
> Changes in v2:
> * new patch
> ---
>  drivers/usb/misc/onboard_usb_hub.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/usb/misc/onboard_usb_hub.c b/drivers/usb/misc/onboard_usb_hub.c
> index a341b2fbb7b44..077824beffa01 100644
> --- a/drivers/usb/misc/onboard_usb_hub.c
> +++ b/drivers/usb/misc/onboard_usb_hub.c
> @@ -7,6 +7,7 @@
>  
>  #include <linux/device.h>
>  #include <linux/export.h>
> +#include <linux/err.h>
>  #include <linux/gpio/consumer.h>
>  #include <linux/init.h>
>  #include <linux/kernel.h>
> @@ -68,7 +69,7 @@ static int onboard_hub_power_on(struct onboard_hub *hub)
>  
>  	err = regulator_bulk_enable(hub->pdata->num_supplies, hub->supplies);
>  	if (err) {
> -		dev_err(hub->dev, "failed to enable supplies: %d\n", err);
> +		dev_err(hub->dev, "failed to enable supplies: %pe\n", ERR_PTR(err));
>  		return err;
>  	}
>  
> @@ -88,7 +89,7 @@ static int onboard_hub_power_off(struct onboard_hub *hub)
>  
>  	err = regulator_bulk_disable(hub->pdata->num_supplies, hub->supplies);
>  	if (err) {
> -		dev_err(hub->dev, "failed to disable supplies: %d\n", err);
> +		dev_err(hub->dev, "failed to disable supplies: %pe\n", ERR_PTR(err));
>  		return err;
>  	}
>  
> @@ -235,7 +236,7 @@ static void onboard_hub_attach_usb_driver(struct work_struct *work)
>  
>  	err = driver_attach(&onboard_hub_usbdev_driver.drvwrap.driver);
>  	if (err)
> -		pr_err("Failed to attach USB driver: %d\n", err);
> +		pr_err("Failed to attach USB driver: %pe\n", ERR_PTR(err));
>  }
>  
>  static int onboard_hub_probe(struct platform_device *pdev)
> @@ -262,7 +263,7 @@ static int onboard_hub_probe(struct platform_device *pdev)
>  
>  	err = devm_regulator_bulk_get(dev, hub->pdata->num_supplies, hub->supplies);
>  	if (err) {
> -		dev_err(dev, "Failed to get regulator supplies: %d\n", err);
> +		dev_err(dev, "Failed to get regulator supplies: %pe\n", ERR_PTR(err));
>  		return err;
>  	}
>