Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp2964520rdh; Mon, 27 Nov 2023 03:37:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IGXqPbID2905nyJzwPBZDTzv8SipSnlmz7pOtYI1BeiO7oI9PMaFjJgHZkQGEQvS6KH/Nck X-Received: by 2002:a05:6a20:4c84:b0:187:4cf5:f171 with SMTP id fq4-20020a056a204c8400b001874cf5f171mr9674111pzb.2.1701085074984; Mon, 27 Nov 2023 03:37:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701085074; cv=none; d=google.com; s=arc-20160816; b=NVy+HGK1yMZLOr4ba+MzWvINWb+zsaTIbNSVNVowMGcEQMAZfLbZrZEDfX/4JAAydU yBw3SMkGh6U+vacYbTi5AqNOCXhv8pvOTpIr+uU620OL/vrywqaxQf7MB1WgGaP5INcG 6AFKDSzKxF2Xh2K2SwtArj7NhQq5Wxj9LHr297pJbOl7C0lFRjgDh5gW7nRXUhVxYuQd G7lcGDVQoTEieQ9XtVzhBTnTUbn/wjy72AXrZpGMsoi5bLbkB2n7SVKQc5vcpJWFHruM jCls6VH4unkARWwXBNwKNs0WwnGJlKq92h+/741oN+WnzHIKzqHnlLynOnslEmSu64qr WVKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature:dkim-filter; bh=ngPthKNSbqBvX4ng8JZc0JixK0jI2zKMbqB/abEZ/Dw=; fh=Mme5yeZS7WXR6ZbQSsRyZ23CnKckw5tcxviJVCJOYxA=; b=f+UETXFLnCDAxUt7r2YE+1XizmiCQwC2nest6H3PKTKR1gFvypNX8BcHnKQRJQ8ttd PLElWlv1JyHq3kGB0DWRqvq5Pp6KWGM6GWhSnmHbgBvDIaWo46ZY1O8cKAfPsBkvG5mH KbbF08BEbsvt7BEebW8MXcZyYw0NDPNvEmtCfvdWsEKqyBVWaAwDN1WMPGtANtvEj8xG 9SiDkO4t9cMAZCmmMd1avR5iFrrPdM3OMWftlAUC8xI7bayEWOCF4Va4Ikmm3jbHwKq9 G8lLd0u0YNdEQJ+HfC4wYYzRs9TcXwX8uHY4VwpMz9xfc4meCyGEu+/lg0Z8NFdUcu20 kQTg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@salutedevices.com header.s=mail header.b=Iivz9lHn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=salutedevices.com Return-Path: Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id 23-20020a630c57000000b005be1f24c815si9783277pgm.502.2023.11.27.03.37.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Nov 2023 03:37:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@salutedevices.com header.s=mail header.b=Iivz9lHn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=salutedevices.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id B332880AEB17; Mon, 27 Nov 2023 03:37:52 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233285AbjK0Lhh (ORCPT + 99 others); Mon, 27 Nov 2023 06:37:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38300 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233250AbjK0Lhg (ORCPT ); Mon, 27 Nov 2023 06:37:36 -0500 Received: from mx1.sberdevices.ru (mx2.sberdevices.ru [45.89.224.132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9AC73B8; Mon, 27 Nov 2023 03:37:41 -0800 (PST) Received: from p-infra-ksmg-sc-msk02 (localhost [127.0.0.1]) by mx1.sberdevices.ru (Postfix) with ESMTP id 431C112001E; Mon, 27 Nov 2023 14:37:40 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.sberdevices.ru 431C112001E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=salutedevices.com; s=mail; t=1701085060; bh=ngPthKNSbqBvX4ng8JZc0JixK0jI2zKMbqB/abEZ/Dw=; h=Date:From:To:Subject:Message-ID:MIME-Version:Content-Type:From; b=Iivz9lHnTMGoUYPpuaaH+uCenvSk6ZN7gGLPHlEfsNNTD9i4jG3Cf9DvOrx7rPnR7 yho9zRRXiavy62iqJJAfLYqZv75wmeaSTGApDPshJLzsqoYccKdI4hwzbLHdswwle8 mlEdOXPNg2E7ScsXJMCosaOFVtsIj4sukfa9OmwH6lZiLR5dVMrI1dDHj6QvQUioqc DUl4Qog8CDbfp2bjCypesUlDUOrsWTOBl5J+Q04ofy7SbMVPWTo1yDMaWnBtDlM/4Y sOqoeu0yQI7zeSSbMkNngUMEoABArZV8uITDSG7QuUTxGN6aBGWTTFN4tlPEm4o6gI VpwoYaeOCIQ+g== Received: from p-i-exch-sc-m01.sberdevices.ru (p-i-exch-sc-m01.sberdevices.ru [172.16.192.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.sberdevices.ru (Postfix) with ESMTPS; Mon, 27 Nov 2023 14:37:40 +0300 (MSK) Received: from localhost (100.64.160.123) by p-i-exch-sc-m01.sberdevices.ru (172.16.192.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Mon, 27 Nov 2023 14:37:39 +0300 Date: Mon, 27 Nov 2023 14:37:39 +0300 From: Dmitry Rokosov To: Michal Hocko CC: , , , , , , , , , , , , Subject: Re: [PATCH v2 2/2] mm: memcg: introduce new event to trace shrink_memcg Message-ID: <20231127113739.djqzy2p2ofstjmm3@CAB-WSD-L081021> References: <20231122100156.6568-1-ddrokosov@salutedevices.com> <20231122100156.6568-3-ddrokosov@salutedevices.com> <20231122105836.xhlgbwmwjdwd3g5v@CAB-WSD-L081021> <20231122185727.vcfg56d7sekdfhnm@CAB-WSD-L081021> <20231123112629.2rwxr7gtmbyirwua@CAB-WSD-L081021> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20220415 X-Originating-IP: [100.64.160.123] X-ClientProxiedBy: p-i-exch-sc-m01.sberdevices.ru (172.16.192.107) To p-i-exch-sc-m01.sberdevices.ru (172.16.192.107) X-KSMG-Rule-ID: 10 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Lua-Profiles: 181606 [Nov 27 2023] X-KSMG-AntiSpam-Version: 6.0.0.2 X-KSMG-AntiSpam-Envelope-From: ddrokosov@salutedevices.com X-KSMG-AntiSpam-Rate: 0 X-KSMG-AntiSpam-Status: not_detected X-KSMG-AntiSpam-Method: none X-KSMG-AntiSpam-Auth: dkim=none X-KSMG-AntiSpam-Info: LuaCore: 4 0.3.4 720d3c21819df9b72e78f051e300e232316d302a, {Track_E25351}, {Tracking_from_domain_doesnt_match_to}, 127.0.0.199:7.1.2;p-i-exch-sc-m01.sberdevices.ru:7.1.1,5.0.1;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1;100.64.160.123:7.1.2;salutedevices.com:7.1.1, FromAlignment: s, ApMailHostAddress: 100.64.160.123 X-MS-Exchange-Organization-SCL: -1 X-KSMG-AntiSpam-Interceptor-Info: scan successful X-KSMG-AntiPhishing: Clean X-KSMG-LinksScanning: Clean X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 2.0.1.6960, bases: 2023/11/27 09:57:00 #22553179 X-KSMG-AntiVirus-Status: Clean, skipped X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 27 Nov 2023 03:37:52 -0800 (PST) Michal, On Mon, Nov 27, 2023 at 10:25:12AM +0100, Michal Hocko wrote: > On Thu 23-11-23 14:26:29, Dmitry Rokosov wrote: > > Michal, Shakeel, > > > > Sorry for pinging you here, but I don't quite understand your decision > > on this patchset. > > > > Is it a NAK or not? If it's not, should I consider redesigning > > something? For instance, introducing stub functions to > > remove ifdefs from shrink_node_memcgs(). > > > > Thank you for taking the time to look into this! > > Sorry for a late reply. I have noticed you have posted a new version. > Let me have a look and comment there. No problem! Thanks a lot for your time and attention! Let's continue in the next version thread. -- Thank you, Dmitry