Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp2971370rdh; Mon, 27 Nov 2023 03:50:07 -0800 (PST) X-Google-Smtp-Source: AGHT+IGIfDx3YJ11o7321LlqJ/UZgyCnGFSl+EDUgmQyxtlcO4o9x5FMjKm2f6GMiSw2ojsJiz/E X-Received: by 2002:a17:90b:4a03:b0:280:8544:42fb with SMTP id kk3-20020a17090b4a0300b00280854442fbmr10303865pjb.17.1701085806640; Mon, 27 Nov 2023 03:50:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701085806; cv=none; d=google.com; s=arc-20160816; b=O++3gTu+EWQ5B8IyXUH2Xx6iIst9rdNL991H4gJa4Bosv8JVVthphNfcB47HeYkCDu rA/JZ9CdCRC6s9S2GVJkRExvluMU1WP6iqO4F/rN129uCqjw0t5G7twd2avor6UnIo58 4awpKfzQ2I3Tfgdsm7y+U+qQ/Btmq4qH3r7C7NLMzzviapcOtv5qoLDI4UJ0fIxNx7GQ TH3pzOxK9Mhxzp6IkjmKVpIs21akHfMqlHemb4TIYlOVd9tOLg8xzLl6nZMpBA4mJKfN uporHtFdg9NwOekuydASu99aIEf/PCV1rz7leksLuKo5nAJOLBSozR6WM4i6Ux2PSCmg TgqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent :content-transfer-encoding:references:in-reply-to:date:cc:to:from :subject:message-id; bh=GFegCqOiIlhzaUCTduOEE8pj65UkEGpaoWfk80eQBJ8=; fh=VOASkBSofsvWtcaUl9L7tfTtPebCjy7QoEmLWKDa1/k=; b=X9DZzUhD/s04PzOGSW2rdZM1nif7v3o0tWIMwN93tdKVnENfJRdUkEpUttYRqDxsSv aKB4Id+T/Pq9v5otbWq0qoU5Y9JiPtbwcmc69T4ddjwEdzBfQ6enF/0WVUqp5pWidwFl gDg6gL1jbNmWUc2jT7v05Oo7Ca/wiPGeBDqBh8DIjhyMMrQGhOlZjTlboT3019ZqvXsy PvabCP+yeq3+e5UMDsQLkEcBx7vYsJRgbMN82lWNqjWSLlnDLN8PP6F83zDcmhISDXLJ /yOwNhg840xJGHwRxD9foYR1YOyH9nQXEQoMJGz5ZPWQ6MbAyANOr86xZ+IbN/SeT87h FI5w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id b7-20020a17090a6e0700b0028513871956si9673968pjk.73.2023.11.27.03.50.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Nov 2023 03:50:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 1506E80576D2; Mon, 27 Nov 2023 03:50:04 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232825AbjK0Ltr convert rfc822-to-8bit (ORCPT + 99 others); Mon, 27 Nov 2023 06:49:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232782AbjK0Ltq (ORCPT ); Mon, 27 Nov 2023 06:49:46 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F15A13A for ; Mon, 27 Nov 2023 03:49:52 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r7a7I-0004JO-DR; Mon, 27 Nov 2023 12:49:32 +0100 Received: from [2a0a:edc0:0:900:1d::4e] (helo=lupine) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r7a7F-00BvmU-Mm; Mon, 27 Nov 2023 12:49:29 +0100 Received: from pza by lupine with local (Exim 4.96) (envelope-from ) id 1r7a7F-000AZL-1r; Mon, 27 Nov 2023 12:49:29 +0100 Message-ID: <0ee99b7af0aa419f1cf0d803217f0871b10e6a00.camel@pengutronix.de> Subject: Re: [PATCH 1/6] net: ravb: Check return value of reset_control_deassert() From: Philipp Zabel To: Claudiu , s.shtylyov@omp.ru, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, richardcochran@gmail.com, yoshihiro.shimoda.uh@renesas.com, geert+renesas@glider.be, wsa+renesas@sang-engineering.com, robh@kernel.org, biju.das.jz@bp.renesas.com, prabhakar.mahadev-lad.rj@bp.renesas.com, mitsuhiro.kimura.kc@renesas.com, masaru.nagai.vx@renesas.com Cc: netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Claudiu Beznea Date: Mon, 27 Nov 2023 12:49:29 +0100 In-Reply-To: <20231127090426.3761729-2-claudiu.beznea.uj@bp.renesas.com> References: <20231127090426.3761729-1-claudiu.beznea.uj@bp.renesas.com> <20231127090426.3761729-2-claudiu.beznea.uj@bp.renesas.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT User-Agent: Evolution 3.46.4-2 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 27 Nov 2023 03:50:04 -0800 (PST) On Mo, 2023-11-27 at 11:04 +0200, Claudiu wrote: > From: Claudiu Beznea > > reset_control_deassert() could return an error. Some devices cannot work > if reset signal de-assert operation fails. To avoid this check the return > code of reset_control_deassert() in ravb_probe() and take proper action. > > Fixes: 0d13a1a464a0 ("ravb: Add reset support") > Signed-off-by: Claudiu Beznea Reviewed-by: Philipp Zabel regards Philipp