Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Date:   Mon, 27 Nov 2023 07:15:59 -0500
From:   Wei Gao <wegao@suse.com>
To:     =?iso-8859-1?Q?Andr=E9?= Almeida <andrealmeid@igalia.com>
Cc:     tglx@linutronix.de, dvhart@infradead.org,
        linux-kernel@vger.kernel.org, dave@stgolabs.net, mingo@redhat.com,
        peterz@infradead.org, Arnd Bergmann <arnd@kernel.org>
Subject: Re: [PATCH v1] futex: Add compat_sys_futex_waitv for 32bit
 compatibility
Message-ID: <ZWSIfy+QJFyw/zGC@wegao>
References: <20231123053140.16062-1-wegao@suse.com>
 <189e733e-7056-45c4-a5c6-3371f8219b7e@igalia.com>
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <189e733e-7056-45c4-a5c6-3371f8219b7e@igalia.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?JVqsbnG4RfhkxrtqZUtomjXPnCPrA1KWt2lie2cMZmmdWoQcuZYba9yJaI?=
 =?iso-8859-1?Q?hm95oS2h0TVchOyoTYrff3Or5EfPsid9ssj1ahNexKUw0rpcOZgTOGDxmJ?=
 =?iso-8859-1?Q?2gGjgDt+iy8TtTuaxjDZbLsSrfXIT/p+6ujgz/o1FnC5MLPsaReJnW4N/4?=
 =?iso-8859-1?Q?yO9rXN3fSIDzzOYgw91Fa939pEd3Iy3WzMSsDVLK/+YJEI/bBjM7EkgRyC?=
 =?iso-8859-1?Q?qNbntck7YxDx6K++6B90eMOLYCqq7PjJo5Pl4p9cimNAgqgV5EOq2ekbpA?=
 =?iso-8859-1?Q?EQrSjXjm4Nb6WwNFbDZf3msqIcTm2pQ3BgTlvPWgKsMbUWPK81ksAwzGKl?=
 =?iso-8859-1?Q?Zlv5Pwuwf3KL0obxYwiwF46/lTLcEraLaY3/L4xcTqbA147yXSJlS2PiiO?=
 =?iso-8859-1?Q?nqXrpMfnlLsgIJxBSePkthYprdp4HPKINA7XlRvMsDQuNddeQp7kGgKh2y?=
 =?iso-8859-1?Q?DtC56uRsG6+L7aCE43/XtjXc6b4vHhcEaHldq7yLSj50jLozVsbO4EnjkH?=
 =?iso-8859-1?Q?vjLicZL6DB/m9+mWYa0TYq8moC/uRFB8MUcMG/gwsDUYK0OvX2bogjesoC?=
 =?iso-8859-1?Q?gkTQ9jcamNC0/en0z4ypQrNE/Kra0ff1qTrn1ACXAnkWOShftqqxZkGBA6?=
 =?iso-8859-1?Q?ZIgy2eaIoE3J32sH6E+wIcUYwxuEPQzo5mqVOrO9/ZhgjobCv6wZDf+Zeg?=
 =?iso-8859-1?Q?oH/Wi6NfYTYkqPx0ONkAslm6DQ9qEAR0cLZtnnszVEF72aF+EOBK6+FGsh?=
 =?iso-8859-1?Q?FptY39sb5kuA/dT0F+eglL7u6uCPRDSxVkomLqDdQoM879JcBAyMO0Vxoo?=
 =?iso-8859-1?Q?ixlVHqbLvnMLevTm5aeUJIqtJNptkyRoqmbdgyAKd2Eklk2HbdbVFMzWbo?=
 =?iso-8859-1?Q?HgbrmxE+8oUWbxY0USwjI20tO8aTAXVZMw4FnZYn6IbP2o1HNFslK7PB0y?=
 =?iso-8859-1?Q?InLltmXdTZwxMGUETSy30THWPWqCQUu8duH66bKCmKOLxsDhRWveOnzP+E?=
 =?iso-8859-1?Q?wdbnmcTkHa4hnfrnpdK8fD+zXRMxYbsBkahUFRjnDhTJdXLhSqEGmoxTxv?=
 =?iso-8859-1?Q?7RkCjJMJJji3rNMm0SEOD3uM4yCs2yQMvB7DfdBFQJYaxMR7QHriQOu64Q?=
 =?iso-8859-1?Q?q07Bqs1z1dnUxR0sVZ9b3Vknx2bHIMhptkeBd1Mt+DgCwRwtJpXDznEGsJ?=
 =?iso-8859-1?Q?yMvuIXWE+vC3iNhJkYp+3BP7fcZSY6f4ATRIh4k7xjg5MHrgFbFxthuLEL?=
 =?iso-8859-1?Q?GnaFI5WZmVBCm7QbNdXcQje0nJFHh4B2zYszi/xhTCgrnvvkxcyZeD/UxS?=
 =?iso-8859-1?Q?OitzJz3PwkGVCL0Sk81mTKM0Tfe67SW9S/4IlkBU8avEHbZ6Ml29c4AeJp?=
 =?iso-8859-1?Q?HxyeazKRrTR7Kxd7lA92IPl7tcqRCJMqv+VyFRaljWc1A/lyzQ9J9glXEK?=
 =?iso-8859-1?Q?pnfuGRCZSm1svs97sgmymnQ0ypFEXIRFqTvZp6uAniLe7U+52BpyEtc4f5?=
 =?iso-8859-1?Q?XHB/8B5VfNG6DJImYtvAgGw7bt2M1wPvErvXY0OJ5PyiUr8l0TJxK+75L2?=
 =?iso-8859-1?Q?eM0X6rMYuhLGP3EgLrjo2QFRypSzQY5HADKGdQSExT9WdEamr7dh2ACkA2?=
 =?iso-8859-1?Q?0kce4n8AabjNU=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 73951a92-6d96-42a8-b1d6-08dbef42a159
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8199.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Nov 2023 12:16:06.0993
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HgijzCCmT9jLJOOXnRZyUK3F06uKgIJ+pp7EuGL3qT/f4NiQnAtpWOne4Kp7aeBd
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8479
X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 27 Nov 2023 04:16:34 -0800 (PST)

On Thu, Nov 23, 2023 at 01:09:55PM -0300, Andr? Almeida wrote:
> [+CC Arnd]
> 
> Hi Wei,
> 
> Em 23/11/2023 02:31, Wei Gao escreveu:
> > From: wei gao <wegao@suse.com>
> > 
> > Current implementation lead LTP test case futex_waitv failed when compiled with
> > -m32. This patch add new compat_sys_futex_waitv to handle m32 mode syscall.
> > 
> > The failure reason is futex_waitv in m32 mode will deliver kernel with struct
> > old_timespec32 timeout, but this struct type can not directly used by current
> > sys_futex_waitv implementation.
> > 
> > The new function copy main logic of current sys_futex_waitv, just update parameter
> > type from "struct __kernel_timespec __user *" to "struct old_timespec32 __user *,"
> > and use get_old_timespec32 within the new function to get timeout value.
> > 
> 
> From, what I recall, we don't want to add new syscalls with old_timespec32,
> giving that they will have a limited lifetime. Instead, userspace should be
> able to come up with a 64-bit timespec implementation for -m32.
> 
> Thanks,
> 	Andr?

Just a comment, I have checked the glibc latest code but do not see any implemention(*.c) on
futex_waitv syscall. So normally you have to do syscall directly with __NR_futex_waitv from 
userspace. So i guess glibc-side can not covert this struct correctly currently. Correct me if
any misunderstanding.

Thanks
Wei Gao