Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp3005285rdh; Mon, 27 Nov 2023 04:37:28 -0800 (PST) X-Google-Smtp-Source: AGHT+IGYbe7nHA+YKiX97mkv0nKIw43nEg04mrazZ/agN/AC+aV1jj8ADxRA4DuUPocZDmDzVE7A X-Received: by 2002:a17:902:ea07:b0:1cf:8a78:2203 with SMTP id s7-20020a170902ea0700b001cf8a782203mr10783350plg.56.1701088648065; Mon, 27 Nov 2023 04:37:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701088648; cv=none; d=google.com; s=arc-20160816; b=g7EZlzf9rtSa6jbUdGvoSyMacAgbPmelcxLbzxqWH5VbtjDZjByl5W3/D97Gv8cKM6 UGLOmnz7Agg8FQeR8L1TGENEPwttOr5beEbIS1Kx71l0CpZLn0Nvj8n1GPgQ1yg65vad tly2WlKDHOxtH46D/KIEtGVeucVEYZyT7r7SUgEnZpZc0zbEnQcFETojqAPAqxsgI0JY EMhr/IwRYB0L/yLUihUTxl6z0UMUPT1GVp8/hHyqLXNuRoFYnEvbUUPxR/5bT4F3M/es mgRFQBhmZRhjhTc7vHifafxcrUDlbJz0FdNsPtPxE3LphBrJ3huYL4obZPNhd5Grz0K0 4rEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=NdcOTN4FoRMqSjUpYgPAnDwqJhAMM02+zH0BYNDR+nE=; fh=Omeij3RQJitYcv5r7VTxN+idsQHibM7jPsz6z3jqTjA=; b=sANDif/w2auQfasl1b/3jCt+RIU/gIPXRaAY/uEkRuk02IUrfdwT9xsOrir8u94n2b 6z80UgT6NoYDXSsAI2i1nSwDeh9z8euXhF+umdU2CvDuO8JNXspCBqBCg5Zd28xMiU/W xRzjFHcUB375gQ5r55ag+8v96bGhqkU9+qepOE68bWyq8Lt/hyyO8yiK0mzzdiBs74Bj iLpZSCKh+wmk55ZSJdAILH0Ov3gZ5Iisa4GCh+tXGlju918/Wy3G6cdkgohvG6DEmRzo PyUIjhwIPwDgAYvCYnvNtC5/hWDl3czd406ylRY+yRZrJpTXotvJLNGRnp+cjP+/7Tui xO4g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NS+1TflW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id y11-20020a170902700b00b001cfdf2b1d86si371477plk.96.2023.11.27.04.37.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Nov 2023 04:37:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NS+1TflW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id E1698805ECF6; Mon, 27 Nov 2023 04:37:26 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233193AbjK0MhN (ORCPT + 99 others); Mon, 27 Nov 2023 07:37:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54352 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233180AbjK0MhM (ORCPT ); Mon, 27 Nov 2023 07:37:12 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D529D137 for ; Mon, 27 Nov 2023 04:37:18 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BAA21C433CA; Mon, 27 Nov 2023 12:37:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701088638; bh=7xwl2go0dypemlRQx0VO0egjtxiAuAu5+0HRC11KHFg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NS+1TflWMGnme8u2dnnmKXzu3p5uLGRFpki3eE/ZTF+zo6R980UPkMsFL6QQq9/KF TLK9TlUGuZRV8BlcoITBHrf6fOtkxgl2sSoM2XmI9U4WJ8i2bsMXV5bNa3DF56cUaS h/j/ux80f6jrAq5/VjiMw08iTXFyNsnbWvAWtiwFBdL6uOpgfrnJLfjQIHv8DAe20g RThm7zSjfd0BnD0xnYDBQsXjm9xKlfM9Y1sItz7p+KqXQvY68v/4E+rs12Mm328q/u 9xFCVvd1PLXAp8xuqtpPxOow2ZGee81kN1I0BFY2oNf77/BRuEz5Hv4xlnhdgXbbTz 0Tunq2OROve3Q== From: "Jiri Slaby (SUSE)" To: gregkh@linuxfoundation.org Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, "Jiri Slaby (SUSE)" , Richard Henderson , Ivan Kokshaysky , Matt Turner , linux-alpha@vger.kernel.org Subject: [PATCH 2/5] tty: srmcons: make srmcons_do_write() return void Date: Mon, 27 Nov 2023 13:37:10 +0100 Message-ID: <20231127123713.14504-2-jirislaby@kernel.org> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231127123713.14504-1-jirislaby@kernel.org> References: <20231127123713.14504-1-jirislaby@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 27 Nov 2023 04:37:27 -0800 (PST) The return value of srmcons_do_write() is ignored as all characters are pushed. So make srmcons_do_write() to return void. Signed-off-by: Jiri Slaby (SUSE) Reviewed-by: Richard Henderson Cc: Ivan Kokshaysky Cc: Matt Turner Cc: linux-alpha@vger.kernel.org --- Notes: [v2] reordered so that it makes sense arch/alpha/kernel/srmcons.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/alpha/kernel/srmcons.c b/arch/alpha/kernel/srmcons.c index b68c5af083cd..de896fa9829e 100644 --- a/arch/alpha/kernel/srmcons.c +++ b/arch/alpha/kernel/srmcons.c @@ -88,7 +88,7 @@ srmcons_receive_chars(struct timer_list *t) } /* called with callback_lock held */ -static int +static void srmcons_do_write(struct tty_port *port, const char *buf, int count) { static char str_cr[1] = "\r"; @@ -125,7 +125,6 @@ srmcons_do_write(struct tty_port *port, const char *buf, int count) need_cr = 0; } } - return count; } static ssize_t -- 2.42.1