Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Date:   Mon, 27 Nov 2023 14:49:02 +0200
From:   Petre Rodan <petre.rodan@subdimension.ro>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
        devicetree@vger.kernel.org, Conor Dooley <conor+dt@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-kernel-mentees@lists.linuxfoundation.org,
        Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH v3 1/2] dt-bindings: iio: pressure: add honeywell,hsc030
Message-ID: <ZWSQPrExmcT5kPit@sunspire>
References: <20231126101443.13880-1-petre.rodan@subdimension.ro>
 <8641e35a-d481-4c27-b450-9ee72ae769b5@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <8641e35a-d481-4c27-b450-9ee72ae769b5@linaro.org>
Precedence: bulk

On Mon, Nov 27, 2023 at 09:06:54AM +0100, Krzysztof Kozlowski wrote:
> On 26/11/2023 11:14, Petre Rodan wrote:
> > +  honeywell,pmin-pascal:
> > +    description: |
> > +      Minimum pressure value the sensor can measure in pascal.
> > +      To be specified only if honeywell,pressure-triplet is set to "NA".
> > +    $ref: /schemas/types.yaml#/definitions/int32
> > +
> > +  honeywell,pmax-pascal:
> > +    description: |
> > +      Maximum pressure value the sensor can measure in pascal.
> > +      To be specified only if honeywell,pressure-triplet is set to "NA".
> > +    $ref: /schemas/types.yaml#/definitions/uint32
> 
> Sent a pull request:
> https://github.com/devicetree-org/dt-schema/pull/118
> Once it get merged, both $ref could be dropped.

thank your for the PR.

in patternProperties, please also add the int32 type for pascal.
your patch seems to cover kilopascal only.

cheers,
peter


> 
> Best regards,
> Krzysztof
> 

-- 
petre rodan