Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Message-ID: <673d222c-52ee-4b65-9dff-0357ed0726a8@intel.com>
Date:   Mon, 27 Nov 2023 14:01:59 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net 1/1] net: phylink: Add module_exit()
To:     Gan Yi Fang <yi.fang.gan@intel.com>
CC:     Looi Hong Aun <hong.aun.looi@intel.com>,
        Voon Weifeng <weifeng.voon@intel.com>,
        Song Yoong Siang <yoong.siang.song@intel.com>,
        "Lai Peter Jun Ann" <jun.ann.lai@intel.com>,
        Russell King <linux@armlinux.org.uk>,
        Andrew Lunn <andrew@lunn.ch>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        "Jakub Kicinski" <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        =?UTF-8?Q?Marek_Beh=C3=BAn?= <kabel@kernel.org>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20231127101603.807593-1-yi.fang.gan@intel.com>
Content-Language: en-US
From:   Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <20231127101603.807593-1-yi.fang.gan@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Rkt2VU84VDlvMTlNNGZwZEx6UjNLUWFaYXI2dnRnUnArUlltTUJFRTIzR2dO?=
 =?utf-8?B?d3IyZ2YzZWxTWXRGTWp3aU54Vy9tWi9uUG81QzVvWlFUR29Va1VRZnJnMnBF?=
 =?utf-8?B?anlZMmtHN2RKaHJPS054UmNmSHFNOHp6UTZaRmYvNmovZHhaSFQ3TGJNczN0?=
 =?utf-8?B?NmpmT0dpeHNLNHRjZ1d5YWhndjEyRU1QQ2RSWjdqck5SWTc3bjMrL2phMDNJ?=
 =?utf-8?B?RlZHUE5KSjFybzJFWFhWSUVzc0JjM0R0L0NKWU4xSmhMYkNJYlhZdWZSQUI0?=
 =?utf-8?B?RFl4eXBab2Q5ZWhOMnFHRCtHY2VYTHc1dkZqSGRTc00waU5zdlROWVVQK3Rk?=
 =?utf-8?B?R1pxaGVydjI5Sis5VEllcFhLckJkeWpKbUhVLzN3dllZRk9FL2hPWHNFdllk?=
 =?utf-8?B?UW5XOXFjU1pGVHF6cUxFZ0I0ZTE0TWVTRkR0RjhxeWw5MEpCTDNCMTFRamkx?=
 =?utf-8?B?UkR6WTRrWlo4aUZsVjZjdUs4UXJQcjM4THZsSVh5b0lBd2llR2xTclduQzFH?=
 =?utf-8?B?N0diNUQwUlNPSFJZd2IvbWw1U05CWnF0NmUvVjF5REJ0UUZydUxPY2hvM0l0?=
 =?utf-8?B?bENFZnJwVVArV0xISHcwckpSa0gyeUs4NFZjQXB4OWVPbHNlMVF1dzVJMFFZ?=
 =?utf-8?B?bnIvYUw0TWRQVHlzTXRJYmlWZCs2ODJFTUxKU1UvRjdDQ3R4SUVMZzZhaGNV?=
 =?utf-8?B?clN6cnZiSERONlpqaW5IQUplQjBaMHVrUFN3SXJhc2JRRGJ3Q1ZVckhkaUxl?=
 =?utf-8?B?UmRCai93Q2tNZ3h5TGZ1MVpCaE9CTEpqNWxzSFRZbStWSWRrQWw2YTd6UmJ1?=
 =?utf-8?B?OHozNkZTa090dGRCYmVrT0lOR0s5VGFhaU9zRGpYMUNhMS84SlFMR0E3SjNh?=
 =?utf-8?B?ZDM0aWc4M1B4cTl6Q2xoL1Z0eTc3ekZDY1Nqb2M1bnVYWURPTTYzb3BlWlls?=
 =?utf-8?B?ckQ0Nnk2RlczUmkrWlNjK3NYZExwUFUxZW5CSkV0MUVPamxuNEdEV2pvdXZJ?=
 =?utf-8?B?bzFQR0RGcVBKUXhOVkZPL0R1MUNnYU0rNFBwSXFpZGdGblNZYksrdzcxOHV6?=
 =?utf-8?B?QTZEY3dEUzVhQlBmUHdzOG02RldpL2NhUVBaZERCVnVrUjBPRmJMQWJmUXVE?=
 =?utf-8?B?QlJ5V21FckFUbHpvQ3FjdnM1VzFDeTdGK1Y2aUV5dG9lOTM0aExOWHVHekEw?=
 =?utf-8?B?aVJzVVpXZVZkUU0vOW1KN3V0Ti9EL3FNVVBqRTNHN2VDdnNpbG1FRlRGaCtB?=
 =?utf-8?B?eTcxSHRRd0Y0ak5jekN6cmdJQVo2Z2VvNW40WXRyQzlFZXV6N1A5YmVDWnJD?=
 =?utf-8?B?Q3lqbFNCa0dFQ2pyU1pIWkMwRGlYcGhYME5TbUo4ZUNEU25aeXovZEVxM3Yy?=
 =?utf-8?B?eERod2F1NkxMeXZlWDJ6dndZZDhHQ3U0bno4L0wyditIMytQR2xDZExzYjUy?=
 =?utf-8?B?VG1pUVB3QzNzRmdEMmVtRDJZODd0NGlneHgyemZyZitHTEpmYWMyN01NcE11?=
 =?utf-8?B?NlYrSG1SZFR0dFM5a1U1cVJSNWRweHorQ1gyTTYzK1VkNGdVWHJ1OWVjUzgz?=
 =?utf-8?B?bEZiV1N5aUNaUyszQlFqYTV6M2FXa0Y0ZjBqVGxpWHRJSUErYzJPOG1maUdq?=
 =?utf-8?B?MzE4VUIyV1VLcDFuRS80ZmZkM1FZNHA4UnE5QXNPRTkwbWg2MlNtb25pWmJW?=
 =?utf-8?B?bFNhU1NoWGN4TWRRYVI4RjFIVWF4UTBZMnJLK3loN3hWNGRucXMrVk9MOFRG?=
 =?utf-8?B?a0hpSHk4OFJrRnlXUFQ5Vy9neGhEazQzK1UxTFFCR1FzU20xNEd0bmsvVW5K?=
 =?utf-8?B?Uk9lajgySGUrYjh6TjBaeXZaaVhhb3laa0FDRG5McmJqemxlU1V5OFVXclA3?=
 =?utf-8?B?amZQNzRKRkdmN0VSNUV2QUtpdHI3Q3Vsb04wcjRaWU9HVlhYWXhWQ0c3d21z?=
 =?utf-8?B?eTVKME9ycVFUenNvM2tNLzdwZjFIZlU1NUYzOXg4ZnNzejByZDNpL0xNdW9F?=
 =?utf-8?B?V1dpbEFjV213Y1hscjZCN1ZaQTQvK1dEQXBPYXRvOWlUM2VWOC9Ld2FZNkVr?=
 =?utf-8?B?UERkbTljSGJSZUZWemdsUmFkYkZ4OEw2RUJubjI3VFVQZXVzbmJUYnYvbURj?=
 =?utf-8?B?NkZwODRDbU1SZTdDUGo3QW52SzNteU14elVpbmtwTWp1N3RPQkNScUVBR09P?=
 =?utf-8?B?YUE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e63c89ea-17b7-448d-5958-08dbef491bfc
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Nov 2023 13:02:28.5446
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4+twXevOjVU1RpGQX9gNvAaLcFcNrvhIua8wU/G1+Vef5Qy2UDlHf/cpbhMPd8Mvf5dn+McInA7jDJM7SvlZXo4nZ0QpuqIOV95L9Pfw7Nc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5395
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Mon, 27 Nov 2023 05:03:26 -0800 (PST)

From: Gan Yi Fang <yi.fang.gan@intel.com>
Date: Mon, 27 Nov 2023 18:16:03 +0800

> From: "Gan, Yi Fang" <yi.fang.gan@intel.com>

Please fix your Git vs mail client settings, so that your own patches
won't contain "From:" with your own name.
I'd suggest using "Gan Yi Fang", as that Intel's versions with commas
(,) aren't optimal for mailing lists and development.

> 
> In free_module(), if mod->init callback is defined but mod->exit callback
> is not defined, it will assume the module cannot be removed and return
> EBUSY. The module_exit() is missing from current phylink module drive
> causing failure while unloading it.
> 
> This patch introduces phylink_exit() for phylink module removal.
> 
> Fixes: eca68a3c7d05 ("net: phylink: pass supported host PHY interface modes to phylib for SFP's PHYs")
> Cc: <stable@vger.kernel.org> # 6.1+
> Signed-off-by: Lai Peter Jun Ann <jun.ann.lai@intel.com>
> Signed-off-by: Gan, Yi Fang <yi.fang.gan@intel.com>
> ---
>  drivers/net/phy/phylink.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
> index 25c19496a336..7121503c9259 100644
> --- a/drivers/net/phy/phylink.c
> +++ b/drivers/net/phy/phylink.c
> @@ -3724,7 +3724,10 @@ static int __init phylink_init(void)
>  	return 0;
>  }
>  
> +static void __exit phylink_exit(void){}
> +
>  module_init(phylink_init);
> +module_exit(phylink_exit);

This pattern (empty __exit function + module_exit()) is +/- common in
the kernel. How about making a macro from it, just like it's done with
e.g. module_platform_driver() etc.?
So that you could just add to phylink.c something like:

module_exit_stub(phylink);

>  
>  MODULE_LICENSE("GPL v2");
>  MODULE_DESCRIPTION("phylink models the MAC to optional PHY connection");

Thanks,
Olek