Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp3060688rdh; Mon, 27 Nov 2023 05:50:52 -0800 (PST) X-Google-Smtp-Source: AGHT+IEjDz4pdEo2cbbKDenXDCq+cpsFWyluFX2yr4dovsvXILff6KRFzWG4rMHrHokjMIBvZ/Js X-Received: by 2002:a05:6a20:914e:b0:187:d44:59f1 with SMTP id x14-20020a056a20914e00b001870d4459f1mr10502908pzc.31.1701093051763; Mon, 27 Nov 2023 05:50:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701093051; cv=none; d=google.com; s=arc-20160816; b=Syw+EogUMLD6Uu3jkCe1+qBj72sdTLEzC4glrj41IaV602F6AHAh6WCO5cyL3VhBMF hcp3XMmICWEPwAUdiF9O5bZ16QVYZgoW2NTWfLY+osk9uTMOLIXoPL7/SeGeyel00mYQ nr2SCKtuOSS1yTZ45EZWsWJ+6lLzcwfqcWx7jYbwZJQCHWVxps1odkzzMlcO9n70KuGa KGxkJtQGFTsHhcv9CzUjBQ5q7dGYdtUSlhUe1iDLbLk+iXT5yidbj4Zck4ZoGS2Mb/Yl Ft+eC+YyrRludE8m07KM7O/wt813GuoqikSP14SpJYv4z5duBNItKYAz0XI1WWioa7FL 0V9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=pgGqq5i1QmR6KGOIGIql8otlNg1yTW7A75NlHApYI4g=; fh=VuAgZt664OYdl6V9lpNOM1joeYx9OGEkvxmybxQWSP0=; b=TpDbRTXYwaZ48tdM3U3JCBUYw7YhSB/GYxMw/CjLAryOhCfGKQGNflntRYgdW6PMx+ vEQWRQHvLA7UMioZC4EySRhVQ4/A6lTKrS+cXw9RXKMVdtJVL2ppBunUIjQ+mEObcAgH 3HV6PIyz9wz3+126aycl9cUGMCuYPz2+NWOU6W8hfu8tj2kiY6DvrBkWKrn/LZ6FbCbF ccUzYj2lfcVS1RfcfLYW2Y0gk0r4HTSONru71AjrBsjrnRfmEOmKG7OxrDmU3KtVeocr O5AS8djqZDkuMXdtepoCWCT7lZMpEis+4Pap45OOxzRPZJAlWQLop7Duk5V1SWekWj/u DfjQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@atomide.com header.s=25mailst header.b=sOg33PuR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id w11-20020a63fb4b000000b005c2791fedbasi10075489pgj.124.2023.11.27.05.50.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Nov 2023 05:50:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=fail header.i=@atomide.com header.s=25mailst header.b=sOg33PuR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 64B4D80941E6; Mon, 27 Nov 2023 05:50:50 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233129AbjK0Nua (ORCPT + 99 others); Mon, 27 Nov 2023 08:50:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35978 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230071AbjK0Nu3 (ORCPT ); Mon, 27 Nov 2023 08:50:29 -0500 Received: from mail5.25mail.st (mail5.25mail.st [74.50.62.9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 945CFC3 for ; Mon, 27 Nov 2023 05:50:35 -0800 (PST) Received: from localhost (91-158-86-216.elisa-laajakaista.fi [91.158.86.216]) by mail5.25mail.st (Postfix) with ESMTPSA id B87DF604AC; Mon, 27 Nov 2023 13:50:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=atomide.com; s=25mailst; t=1701093034; bh=FE9cvV3PjTeKPLT9+4+I0lHD4+oUEtNr//lG4eUzrzw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sOg33PuRFPb4dK1Qfkk80dZYbIvLfUVgUl30rBvhJk1LlEBQdjRwQsxNZvh2GPwZq oU7Q0aIXs7RJI77othtwSKD5RLzgI6hLlQcud7CNbexg4It2oHqJlQx/zu4Fzq3BjU FAl63pOdUEp2gLwOlFLuC6NIhoHq1rtllfPqTNmlsmR9iLV5vG5LuxSjkXpQ3JmDph jFgQ6dkPvzH3Up1j8EPOOSW1FI7Xqiu0WUi0fLDkIkbbcRd1QU6VXD4Z56EGnZ4szs InYkmJxbYJudmoCC23NUjac0819zpQiozHoWy2LtweHQucfhzbuw8KBG5PSKJyFbwA zhpmZAGW/+pSw== Date: Mon, 27 Nov 2023 15:50:08 +0200 From: Tony Lindgren To: Greg KH Cc: Andreas Kemnade , marcel@holtmann.org, johan.hedberg@gmail.com, luiz.dentz@gmail.com, johan@kernel.org, arnd@arndb.de, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, tomi.valkeinen@ideasonboard.com, =?utf-8?B?UMOpdGVy?= Ujfalusi , robh@kernel.org Subject: Re: [RFC PATCH 3/3] drivers: misc: ti-st: begin to deorbit Message-ID: <20231127135008.GN5169@atomide.com> References: <20231126191840.110564-1-andreas@kemnade.info> <20231126191840.110564-4-andreas@kemnade.info> <2023112729-qualify-relearn-6a72@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2023112729-qualify-relearn-6a72@gregkh> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE,T_SPF_PERMERROR autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 27 Nov 2023 05:50:50 -0800 (PST) * Greg KH [231127 08:25]: > On Sun, Nov 26, 2023 at 08:18:40PM +0100, Andreas Kemnade wrote: > > The TI-ST driver seems not to be used anymore. For bluetooth needs > > there is hci_ll.c which has device tree support and can work without > > this one. Also firmware download support is there, so it is also not needed > > here. GPS can also reuse parts of the framework in hci_ll > > > > Contrary from this driver, device tree support has been removed. > > > > So start deorbiting it by marking it as broken. > > > > Signed-off-by: Andreas Kemnade > > --- > > drivers/misc/ti-st/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/misc/ti-st/Kconfig b/drivers/misc/ti-st/Kconfig > > index 1503a6496f632..6bf9cc845745c 100644 > > --- a/drivers/misc/ti-st/Kconfig > > +++ b/drivers/misc/ti-st/Kconfig > > @@ -7,7 +7,7 @@ menu "Texas Instruments shared transport line discipline" > > config TI_ST > > tristate "Shared transport core driver" > > depends on NET && TTY > > - depends on GPIOLIB || COMPILE_TEST > > + depends on GPIOLIB || COMPILE_TEST || BROKEN > > Why not just delete it? Why have it stick around any longer? Sounds good to me too. Regards, Tony