Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp3062992rdh; Mon, 27 Nov 2023 05:54:40 -0800 (PST) X-Google-Smtp-Source: AGHT+IEz6XDUu+qOJoxvTyqTScNdvLZAcbzf7xhsqUQUUtbj9BkmOpyz3Pas0UkTiKoBOC8K4WKn X-Received: by 2002:a05:6a20:1608:b0:18c:da:ba0b with SMTP id l8-20020a056a20160800b0018c00daba0bmr13934023pzj.44.1701093280455; Mon, 27 Nov 2023 05:54:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701093280; cv=none; d=google.com; s=arc-20160816; b=RppnSeEFWjY6vtNXAnFbWsfHC9UGvnzhLUMddyOxvyElTzEOllTEsiLDfU2JRxlCLn +EZA0QLNqic3Mq1GeUCQMPmRFmTjPi2V974R/ScyOtdOHSYrYnOt3Wfl16wl4zNQRN9X Fvqa6xsKBBLkIjrN29zAcZeoa/eSN+SdBGspRJVv8TkasN4Rv2RZ9YQSsdOqq/WOuuQi 4IUgbFoAj4lLKJlIydJbT56iLnHYnI/r85mnfsx2r3Ex9NV9jjRsVZnQyJxI04G8y2/H FwF1JglDZ0YmF88ZxI+YLwV3CripNUJrGYXQ9yIkIp4vVJampMQjix/OTfcoHF0VfYe6 g5UA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Ybd9N7tSltfA50TaXog+BFMRHz/ybMU5OjfKHaMKi/c=; fh=0HuRsgt+OXA8gN/mQRjXya5bcg57qhykugeTCItMtj8=; b=eGNevbHgM0FZYuIYlRW1tN492gwnEVhbv/z5pT+PXzv8+lNt43lZDsdJHBq4xe1MTO w/Zq7008WcLJUxtOp+9OU2j20rKPCG6NfqVb6RSvOcJ9d51i4OkG4zvq5m58mLWLHArg CvGlgRPje0rIGogj5nZz8y1cxacT8xo5tatcmM5ZG4SS4z2ptqBIGAfDsv0qgSMn6uLR mF8iZGF9XdlLWnDQQjHM2L30I8nJz25Z2+cNjM+Sy167CZ8GG+BEtjm7APf0HA0wsOim zwoIM7exExX1jIW9CnaQ6xsjF5T7GdcjdNLo2zG9ue7GfI38tW4G8S6xi/ObyNGUWo7r mjJA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=gKQfL6ZY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id bz20-20020a056a02061400b005b01279150fsi10923996pgb.528.2023.11.27.05.54.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Nov 2023 05:54:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=gKQfL6ZY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 3C09A8093F5A; Mon, 27 Nov 2023 05:54:37 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233477AbjK0NyL (ORCPT + 99 others); Mon, 27 Nov 2023 08:54:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233204AbjK0Nx5 (ORCPT ); Mon, 27 Nov 2023 08:53:57 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7205B19A for ; Mon, 27 Nov 2023 05:54:04 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C32A7C433A9; Mon, 27 Nov 2023 13:54:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1701093244; bh=ky2aKAKe/DTLRtU5o6/e30Zf24aqeF/l3aPJrk9lnlo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gKQfL6ZYskF0p5TNuO6zVRFZoQLAG8oNppD1T0vJTxnJhp2SCK5ZatpwvpASOwtJn WXbyol5HLd9xEtKT0zNfok1ZEE3K2xCrnbO295QLctRj+PmpZeABwbpbE28rBHwLod ZWQ5ryVFlDO6fkvb25d/Ou26A9R+A1+RNHmPqmVY= Date: Mon, 27 Nov 2023 13:12:03 +0000 From: Greg KH To: Florian Eckert Cc: Eckert.Florian@googlemail.com, pavel@ucw.cz, lee@kernel.org, kabel@kernel.org, u.kleine-koenig@pengutronix.de, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [Patch v9 0/4] ledtrig-tty: add additional tty state evaluation Message-ID: <2023112745-sector-revenge-f821@gregkh> References: <20231127110311.3583957-1-fe@dev.tdt.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231127110311.3583957-1-fe@dev.tdt.de> X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 27 Nov 2023 05:54:37 -0800 (PST) On Mon, Nov 27, 2023 at 12:03:07PM +0100, Florian Eckert wrote: > Changes in v9: > ============== > - As requested, I have removed the memory leak fix patch from the previous > patch series v8 and have send this patch directly to the stable > mailinglist [10]. > - I also have removed the not needed wait for completion code path on > sysfs attr store and show, for the new configuration options, as > requested by greg k-h [11]. > - Patch v8 3/6 dropped, because the change is not correct as mentiond > by greg k-h [12] and this part of the code will be removed anyway > in this patch series. > - Update naming of the function ledtrig_tty_waitforcompletion() to > ledtrig_tty_wait_for_completion() which match better with the API call > function wait_for_completion_timeout(). > > Thanks to all reviewers for the suggestions for improvement :+1: of this > patch set. Nice work, thanks for sticking with it: Reviewed-by: Greg Kroah-Hartman