Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp3108013rdh; Mon, 27 Nov 2023 06:42:02 -0800 (PST) X-Google-Smtp-Source: AGHT+IE+omjwIHgq9iP2oVTDKseDwd90mLSa67CmqgiMFPVEiPSloCN7pAKaLxL5hTx1OlHI51De X-Received: by 2002:a05:6a20:9390:b0:18c:5178:9649 with SMTP id x16-20020a056a20939000b0018c51789649mr8855809pzh.14.1701096122508; Mon, 27 Nov 2023 06:42:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701096122; cv=none; d=google.com; s=arc-20160816; b=1IKXbSIkFUAlE677VqV3fZvyWcdReoj/He97yLUsW8Fq/URNX7PGDlVhnqbHvL7R2m IPR1epuvOg2Uci5l/hL7Ij2OFXZvoNkINXrlq+n4+3rU1xd0WPqviUnkGuFAcG0Icm6z yUck39lEpdsltl5+ztGBnsekYrjABwRfGfuJkoBbLyIZj9JXY/7GRv84YyZxTWmlP1Wc Dzq6K+sjz3VC8dbnt0gh1w99udlwKw91tHhCI+UG/yXhp3CSf8CnmRUUlt3E2/EMQeMy w8pdJ3+Zol/uHziAoRh46n//P/So3vq4a1fw0iWC+0yL7txkPLIvxRxjsO5cehYuRtqG I0XQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from :dkim-signature; bh=XRQp0zOYdNbHHuto1yIZyaF4vtL+R1Yy6pinuFlVyl8=; fh=PDvBbh2c5owVQJHT3yjvJxa4713gCLVDsLtRSLIA4zI=; b=zz32cts1ef6kXlml2IUSpgM4qZHHP3CPwapcIcQlEa7ESqgPVFzkIuJhtpvTxkZTzs TWmjump6eCUW7YS4zcWhYx9HQyXZV0b81sKwImuzHodcz65/4kKt3l47UlSgdgxHJPXQ M+B2ATfZuBz5GkwfER7cyHO7tY6w1JYtksuQkYxoRFn/dOFCbE3yySn5YhEVqD68Zd6D bE5o6+QRXmVEEA7/Xjz6c1F4yjQmtFFTnt7OyCFLm/dDW1XTcwluvYDa4Z5i+uGj4efR v4kAnPk+4w6ZOtB+xDcX5XcZE81LW8cfwjI3Xhit8U7PypC6bryE/JMLbnApslL8/RF1 kfAw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=G2kFeCAT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Return-Path: Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id e37-20020a630f25000000b005b8ebca5313si9592095pgl.426.2023.11.27.06.42.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Nov 2023 06:42:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=G2kFeCAT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 02797807DEDC; Mon, 27 Nov 2023 06:42:00 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233565AbjK0Olq (ORCPT + 99 others); Mon, 27 Nov 2023 09:41:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37076 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231754AbjK0Olo (ORCPT ); Mon, 27 Nov 2023 09:41:44 -0500 Received: from m12.mail.163.com (m12.mail.163.com [220.181.12.216]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 8F763C2 for ; Mon, 27 Nov 2023 06:41:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=XRQp0zOYdNbHHuto1y IZyaF4vtL+R1Yy6pinuFlVyl8=; b=G2kFeCATce1RM9VxhgJW3Ni3vKuNEVGlSV z5z7sCjf5f+tGWBCo8lzrOsC3sK+ji6ZJlmbV0ZzPbc9JEetumc3AZKgfK3FAlrx 2Nqe6Vr/1fytMTZZqs/xVlK3CukUyt9ZcbCHjB830BSb6OoUkoyj1TQmx2HAoHcP wNM6Bbyyw= Received: from localhost.localdomain (unknown [39.144.190.126]) by zwqz-smtp-mta-g4-0 (Coremail) with SMTP id _____wB3FVSGqmRlvUJQEA--.27646S2; Mon, 27 Nov 2023 22:41:12 +0800 (CST) From: Haoran Liu To: npiggin@gmail.com Cc: mpe@ellerman.id.au, christophe.leroy@csgroup.eu, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Haoran Liu Subject: [PATCH] powerpc/powernv: Add error handling to opal_prd_range_is_valid Date: Mon, 27 Nov 2023 06:41:08 -0800 Message-Id: <20231127144108.29782-1-liuhaoran14@163.com> X-Mailer: git-send-email 2.17.1 X-CM-TRANSID: _____wB3FVSGqmRlvUJQEA--.27646S2 X-Coremail-Antispam: 1Uf129KBjvdXoWrZrWUuF13Xr1ruF1kCF1fCrg_yoWftFgEq3 WxCa10qw48Wr4q9w1DCr1rGrnFk343Gr4UKr1Ig3ZFkryavasxC3s7ZrZ3WF17WrW2krZx GF98Kws8A3WSvjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7xRufO2UUUUUU== X-Originating-IP: [39.144.190.126] X-CM-SenderInfo: xolxxtxrud0iqu6rljoofrz/xtbBcgE1gletj1OaTQAAs1 X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Mon, 27 Nov 2023 06:42:00 -0800 (PST) In the opal_prd_range_is_valid function within opal-prd.c, error handling was missing for the of_get_address call. This patch adds necessary error checking, ensuring that the function gracefully handles scenarios where of_get_address fails. Signed-off-by: Haoran Liu --- arch/powerpc/platforms/powernv/opal-prd.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/powerpc/platforms/powernv/opal-prd.c b/arch/powerpc/platforms/powernv/opal-prd.c index 327e2f76905d..b66b06efcef1 100644 --- a/arch/powerpc/platforms/powernv/opal-prd.c +++ b/arch/powerpc/platforms/powernv/opal-prd.c @@ -66,6 +66,8 @@ static bool opal_prd_range_is_valid(uint64_t addr, uint64_t size) const char *label; addrp = of_get_address(node, 0, &range_size, NULL); + if (!addrp) + continue; range_addr = of_read_number(addrp, 2); range_end = range_addr + range_size; -- 2.17.1