Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
Message-ID: <c822cc63-3ff4-4edd-9416-015c52f9fb5b@amd.com>
Date:   Mon, 27 Nov 2023 09:52:35 -0500
User-Agent: Mozilla Thunderbird
Cc:     yazen.ghannam@amd.com, linux-edac@vger.kernel.org,
        linux-kernel@vger.kernel.org, tony.luck@intel.com, x86@kernel.org,
        Avadhut.Naik@amd.com, Smita.KoralahalliChannabasappa@amd.com,
        amd-gfx@lists.freedesktop.org, linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH 02/20] x86/mce: Define mce_setup() helpers for global and
 per-CPU fields
Content-Language: en-US
To:     Borislav Petkov <bp@alien8.de>
References: <20231118193248.1296798-1-yazen.ghannam@amd.com>
 <20231118193248.1296798-3-yazen.ghannam@amd.com>
 <20231122182451.GHZV5Hc/49OYomyejc@fat_crate.local>
From:   Yazen Ghannam <yazen.ghannam@amd.com>
In-Reply-To: <20231122182451.GHZV5Hc/49OYomyejc@fat_crate.local>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TEI5M0M2amk5MERpbW5OcmJlNG9xa2owSldBYzFKZGQ1Vkd4M0FHV3BqVlNw?=
 =?utf-8?B?bnlwbEhlZWZGQ281Q1E3eWtNZWdaWnY5MWJaL2ZpUFdCVU1iUzdjeUV1elAz?=
 =?utf-8?B?aWdmODFjbUxNQXFtUWUvYkMzU2pUV3ZNMjhZaDg3dnRpeTBEZmlPU0dZM1FT?=
 =?utf-8?B?a1VOUmxSOXJEQjk5MXhnemRJZnAwSXh6elRvcU40TmxrVExzRlhkR3hRaDQw?=
 =?utf-8?B?cStKcDBtMG11STN3cjdpdVVLY2x0d2FGalZJWEpVWjdIRXMySTh4U0w5UlN2?=
 =?utf-8?B?WldVTUg4MVlyMFdiWkZKMVZUVjBFbllleW03VWtpTkxXOW5aeWxMc2RIbklW?=
 =?utf-8?B?ajJhc2tucUowOGJwejFuWDZ4ZHZiWThqOHhlVlNYSnJyait2ekpIb29OYjlp?=
 =?utf-8?B?REp4OXVsQU40dm83bnZIblRkZG5wOGN5aWdSTDVsMHlIMXl2MzlVYkFaOE9Y?=
 =?utf-8?B?M2JrQXNjSDJpRjNwZTFYcWxnaThRVVI0ZWN2bW1ISWJqTFM1YlJIS1FBZHY0?=
 =?utf-8?B?M1dOa3lqd3AxZFF1am9td3E1c0VUbFNJdGNDdXNweitrNnphTEsxNTE3U2tu?=
 =?utf-8?B?bXB6dXQzSldEd251MHAvS09UT01JN2VielFDRTJreU5qSm41S1NudTAzMExR?=
 =?utf-8?B?RWgvWUZjMW0zWm1kcldKSGZYdnFvcVdxVGp4am1Jb1ZXMGxuWDl1SWxMVDN2?=
 =?utf-8?B?UkZGTkRXSzBrNjRrdFBUcDZTcC83ZW40UEpzczhrQTZWd055QjQzdDhCZ2Nh?=
 =?utf-8?B?Y2hzSlpZWEdNTHdoMWhpdEt0YkhZdU1xTmtJREl2R0dSMmRoekFLOEcvZkFX?=
 =?utf-8?B?eVk0STY0NGFyaWZQdE9mOEZKTzNEVGVZdXFsOTEwcGNCS2dJV1ZicGFVQUJP?=
 =?utf-8?B?dHEzMzUvcEpuSFMvQS8zTkY5SlRRTTVEcnZBQ2I2NGxwQk1xWC9sLzZFV3ZR?=
 =?utf-8?B?S0I4L1lzcnRMMHp2VEN3Sjk2TnpGU0w5V2V1SVBUb3JTU2lUaWg2cDNyNnh1?=
 =?utf-8?B?SC9WWFgxWlIwbzhodjhEc3JpTXBuRGgxOTZ2TDA3VzllNVkvcURzTEJWRncy?=
 =?utf-8?B?dFlTV0dwM1RSN0QxSktEVmpVTWpSUm9Sd1YzZzZ6T2ExemcvRUlma1VRV0I4?=
 =?utf-8?B?WXZhejVtTTdHU1BtU3ljQmhOQWR0TWhxNUhtV2w2OUgrYWdmbEloZk9CdGVL?=
 =?utf-8?B?ZE4rWnlLNUNXaE1mTWFQNmdwK0ZNbng5cGpLUHgvNFk1TW9aOWo4U0JTT0J0?=
 =?utf-8?B?eUVGQ0JUMFNFd1FJZHI4eS95UmJlZlU4aXlzdEw5aGFRU0xuZENOTmo5QXA2?=
 =?utf-8?B?dWo4YjBlbnVxK3JLZythY2pzb0lReDR1QjhjdUZpU0NObXhBc2tNUFlWNkRK?=
 =?utf-8?B?aTNHNHZlU1M4VHlYTlU5SU5Ob0RWTzk0MnoxTjJrdFpZYzJSdThlRWx3S0Z5?=
 =?utf-8?B?UU0xYnA4cTVMTUUyQWViOWozb1ZaV2VWWEpUdDBqdGFxUThxNWNOOUhNcFow?=
 =?utf-8?B?SERZblJTN0JFZ3RrMjZudVNPM056SEZCTElMcGpwempvWkRkRklLSVVLRlph?=
 =?utf-8?B?dWNpWE52WEF6OENtVTAvdWpYY1o4MVI4dHRMa1h1b2xFQ21rb3U1L2lPY05Z?=
 =?utf-8?B?YWE5K2lxWC9DYkowRG1NTW94dmZnRHl5RHQ1bGcyZlo1NVQ0THZUc0NEMEhB?=
 =?utf-8?B?UkZhb0kwRFVqQjlQWU5UK3lEc2V0VmZGanBiSWVTRFZuMVhMbTF5TEx5UlJX?=
 =?utf-8?B?VWVzem95Rk8rNVBROWxVWDBWVU1WWkYzTFZCZWVoQWtYcXFrTE5IOUNEVDhF?=
 =?utf-8?B?QVFpQVJGbll0dmVsS2JpZ1FlZHdkaTdDVXNQOGtvdXBlUGFCZ3FJUUhIOVc1?=
 =?utf-8?B?OGhITlF1by9FVzVwUWFXWGpUYzg0ZHd1RCtFaitmSm5jbVFWM0pyZXIyMkZZ?=
 =?utf-8?B?cmNvcDlDOXU0d2pSLytpNDZzcHRySFNBR1RPR2h1K1FKeWZ2REpXdW5nWTFt?=
 =?utf-8?B?ekJEN3JVd3d6bFJ6cHBoRjA3bnFKU3JvSk41alp3ZHpWUHkvR0pCR0didmZL?=
 =?utf-8?B?MG1ScEZJdGM1dU5jdk9QSzZPOEZoVmNWSTlLZEoxQXRBWjVlZWNjTndOY1hr?=
 =?utf-8?Q?OjKUFsZ+UVkKZNAzSxvbyoBHN?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fe0d7d63-a0cd-4059-8534-08dbef587f4d
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3108.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Nov 2023 14:52:37.6519
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0JSZ96L0EN8nhhCXsuYNbagUl8V9OqbsCHW6K/ONk/Y+yl23ap47DcVmmj06mFlxeXcPatUlLi1Q/+8mDZ1BrQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB6900
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Mon, 27 Nov 2023 06:53:02 -0800 (PST)

On 11/22/2023 1:24 PM, Borislav Petkov wrote:
> On Sat, Nov 18, 2023 at 01:32:30PM -0600, Yazen Ghannam wrote:
>> +void mce_setup_global(struct mce *m)
> 
> We usually call those things "common":
> 
> mce_setup_common().
> 
>> +{
>> +	memset(m, 0, sizeof(struct mce));
>> +
>> +	m->cpuid	= cpuid_eax(1);
>> +	m->cpuvendor	= boot_cpu_data.x86_vendor;
>> +	m->mcgcap	= __rdmsr(MSR_IA32_MCG_CAP);
>> +	/* need the internal __ version to avoid deadlocks */
>> +	m->time		= __ktime_get_real_seconds();
>> +}
>> +
>> +void mce_setup_per_cpu(struct mce *m)
> 
> And call this
> 
> 	mce_setup_for_cpu(unsigned int cpu, struct mce *m);
> 
> so that it doesn't look like some per_cpu helper.
> 
> And yes, you should supply the CPU number as an argument. Because
> otherwise, when you look at your next change:
> 
> 
> +       mce_setup_global(&m);
> +       m.cpu = m.extcpu = cpu;
> +       mce_setup_per_cpu(&m);
> 
> This contains the "hidden" requirement that m.extcpu happens *always*
> *before* the mce_setup_per_cpu() call and that is flaky and error prone.
> 
> So make that:
> 
> 	mce_setup_common(&m);
> 	mce_setup_for_cpu(m.extcpu, &m);
> 
> and do m.cpu = m.extcpu = cpu inside the second function.
> 
> And then it JustWorks(tm) and you can't "forget" assigning m.extcpu and
> there's no subtlety.
> 
> Ok?
> 

Yep, understood. Thanks!

-Yazen