Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Message-ID: <27e09418-3201-4908-9ea7-13691f28c664@amd.com>
Date:   Mon, 27 Nov 2023 09:53:17 -0500
User-Agent: Mozilla Thunderbird
Cc:     yazen.ghannam@amd.com, linux-edac@vger.kernel.org,
        linux-kernel@vger.kernel.org, tony.luck@intel.com, x86@kernel.org,
        Avadhut.Naik@amd.com, Smita.KoralahalliChannabasappa@amd.com,
        amd-gfx@lists.freedesktop.org, linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH 03/20] x86/mce: Use mce_setup() helpers for
 apei_smca_report_x86_error()
Content-Language: en-US
To:     Borislav Petkov <bp@alien8.de>
References: <20231118193248.1296798-1-yazen.ghannam@amd.com>
 <20231118193248.1296798-4-yazen.ghannam@amd.com>
 <20231122182805.GIZV5INdVuBOhbtjOm@fat_crate.local>
From:   Yazen Ghannam <yazen.ghannam@amd.com>
In-Reply-To: <20231122182805.GIZV5INdVuBOhbtjOm@fat_crate.local>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TW11YmJKUER6SXVtN1ZCSHJVbU5uN1oyeTJ0YlhzNGF6WEJWODdCTTFhVSt4?=
 =?utf-8?B?SWxZRjY5bUZkK3FqOThML3ZRTFlNRHcvUnhDU2NtTHZPZHNrMDJrTklGVnY1?=
 =?utf-8?B?RWlqQU9XRFErUzllV1ZVcldNWWdNV3FrK0RGNkRIZDM3aFovRXlhc2lTL3dT?=
 =?utf-8?B?NnZPc2M0VHpLdS8zbWF5ejJLTWJiYXJ5czVrMEY0MXAxMkxpK2NqQzVNL3B4?=
 =?utf-8?B?UFBPamFPTjBCTUVBMEhTTHFVbnBJMzQ0eEJ1NjhWcm8xaXpBREY2VDlBUDRs?=
 =?utf-8?B?MnpnOUwrbk1YUHpvam81TEs4bHorYk5jalpHNUg0V1NkSkZnUFVFTnhXUFZ5?=
 =?utf-8?B?M1c3VGdIempHQXN4ejBLa1o1RkZJdEQ0WE9FSmdEa0RlczBhVmVwMnZXenFM?=
 =?utf-8?B?empCSk5TODJqMnRtQ3R3N0w0VWxOck1EbDEwQXB3V1g5cDc4NnFCY2NUcGFs?=
 =?utf-8?B?bFJhdE5iWGdwZDdFNXVmdnFCemN6N1Z4L28rNkozdmFydG5WSFlNK2pySzRq?=
 =?utf-8?B?eTBvWHJMTVFXOFROUTFSZ0hPL3U3MWkvYVZIdStoRWtzTUtJZVRYTzN5dTgr?=
 =?utf-8?B?NS8vQ2U0LzFqTEN3SmkrYjJtVERva3RMWFhwY0lCd29odS82Wm1CM2ZvM25X?=
 =?utf-8?B?d0FhNE5vdWVCRUtWM2tRRHFpL29DczVMeVBwdGEvTlIxUW5CYk5hSWlIWXln?=
 =?utf-8?B?eFdnU1FHdmRXMHk5UFptV2JaVlBzTnNYejRSYlV6OExnbmpuUXowV2FPcnpC?=
 =?utf-8?B?K3ZoNWhjOTZxcGxKNTJPMVFpTGdBNGxoWGtkNHdnOUVJS2puWXlub0VidVVB?=
 =?utf-8?B?M0lVMzFvTXUxYzVkOGZEdFk3THlWTlNSc3B2T2Vxdm9tTTcza210OEpIelhI?=
 =?utf-8?B?eGVkbDZ1YURyaW5sVmNIVkRRZ2N4UkNjTldrd2FFZ2RncWJqelAyb1ZOcjRx?=
 =?utf-8?B?VXBIanIxckV3US93T0NpRG9OdHM3QlZ5TFNUUFd1dFVvYVNvdWt1WnhuNzlR?=
 =?utf-8?B?Q3NBQTRvQkREZUNiN05SaDNBRDFVTEZNYmJaL1pmUEN4NVlQaUlESzJNb2Vk?=
 =?utf-8?B?eU5HT0k5ZG1PZzZNY2JaOGpoQktCQjRjYUQvaVJQdEgzSk02dGluOVZWdk9w?=
 =?utf-8?B?L1MrWHNNbmhycWpQU1NLcjh1VlJpa1BqNzdSeDZmQXk2WnViektlZVRBMWpq?=
 =?utf-8?B?UFBlbk4xQVh0QlZuVU52aitLT2NmK1I2MGh3M3lMbnJHcTU2SmlaM29LYmZm?=
 =?utf-8?B?OW8rQm5IcU9PeHo0Y2FBNUl3ckxLK3RzbEszMnFBMTFLYlg5NWZiMHNUUmlL?=
 =?utf-8?B?VWZ3ZmUwQjdLbW1LTjFVcTVMOHV5QXl5QTJrY20waXc5aHE4bWRhNGtQbEpy?=
 =?utf-8?B?LzNXTndJV2cyMzYzdjdMSy9zRDBPU2pSbkdWS25TL2NDelpYZnpzT3VNdGI0?=
 =?utf-8?B?S1lid2FtQ3BmVG1Uc2IwdzVuSWxOTVNaREtKSUI1a3RaaHZRdFRnVTVKVHdU?=
 =?utf-8?B?dTZMeTlEUEVEbUJpNXJTYmJNci9xNk5wd3BDdlpHN0YvTllWaC84MVNFSi9C?=
 =?utf-8?B?NlJod1M5Vm9HajBYd1lYWktEdVhIRE42cXoxcHVZYVNNN1VXUmNiZ29uQkhk?=
 =?utf-8?B?TjV0ODlXTUZ4YUFHUjE2amg1dWJnMVNSVlo5d3ZWSUQ5WTcwYkJuQjhyQ3o2?=
 =?utf-8?B?RmRXYUpTMUF3aExxMlVNTGNEak9jOWt4c2Y2RnlWYVlOUkgyVjgxbkx1dUVX?=
 =?utf-8?B?RnNTcE5NcktnWm5neG5KWUhMU0VWQTFjTXlOR25hcDhXcnBNdU9ZNHN1QUMz?=
 =?utf-8?B?aEtHTXRpWUZReTBvQ2NCaEJsZnI5L2ZUMjRvVGw3bW14REtDTGF4azZTeHFV?=
 =?utf-8?B?VjNGVVB2UDhvZkVuWDkxNml0QW9OenMvRWwybklsOFZIbWpmK3FIKy95VnVO?=
 =?utf-8?B?bUtQRVh3WEc4ZVlTeXFjY0xLb1B3MUpFSUMzSE9ORDZ6UzZ3bjkzTDU2ZWYv?=
 =?utf-8?B?TjFZNjNvekFKMFRqdHZCVGQyTURhSUpWbDNQQVFCVjQ2amhIWlNxMUlLNmxh?=
 =?utf-8?B?TDVNMi9BRjY4bmFXTUFuUUNEcEYyaVVjMWp1OEswVy9MQ3YwcUFlMUZwK1k2?=
 =?utf-8?Q?Wrn142WBiHmmxxZjiK4fDOqzT?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0e35cf8b-e242-4705-e0c5-08dbef58978d
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3108.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Nov 2023 14:53:18.3027
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yR7/w7oTv3Cs3BiiL03AZsF/43MZJZ6NengIVt3DGwSlGaMdNEwlIBsx+kTQS/pgW+xtTYMKly8PVA6p/DlyyQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB8644
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 27 Nov 2023 06:53:28 -0800 (PST)

On 11/22/2023 1:28 PM, Borislav Petkov wrote:
> On Sat, Nov 18, 2023 at 01:32:31PM -0600, Yazen Ghannam wrote:
>> Current AMD systems may report MCA errors using the ACPI Boot Error
>> Record Table (BERT). The BERT entries for MCA errors will be an x86
>> Common Platform Error Record (CPER) with an MSR register context that
>> matches the MCAX/SMCA register space.
>>
>> However, the BERT will not necessarily be processed on the CPU that
>> reported the MCA errors. Therefore, the correct CPU number needs to be
>> determined and the information saved in struct mce.
>>
>> The CPU number is determined by searching all possible CPUs for a Local
>> APIC ID matching the value in the x86 CPER.
> 
> Those below are explaining what the patch does. Not needed here.
> 

Okay, will remove them.

>> Set up the MCA record after searching for a CPU number. If no possible
>> CPU was found, then return early.
>>
>> Gather the global MCA information first, save the found CPU number, then
>> gather the per-CPU information.
> 

Thanks,
Yazen