Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Message-ID: <7b6d0d32-c1c5-4c57-a34c-81c9699c0d49@amd.com>
Date:   Mon, 27 Nov 2023 10:00:00 -0500
User-Agent: Mozilla Thunderbird
Cc:     yazen.ghannam@amd.com, linux-edac@vger.kernel.org,
        linux-kernel@vger.kernel.org, tony.luck@intel.com, x86@kernel.org,
        Avadhut.Naik@amd.com, Smita.KoralahalliChannabasappa@amd.com,
        amd-gfx@lists.freedesktop.org, linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH 05/20] x86/mce/amd: Use helper for UMC bank type check
Content-Language: en-US
To:     Borislav Petkov <bp@alien8.de>
References: <20231118193248.1296798-1-yazen.ghannam@amd.com>
 <20231118193248.1296798-6-yazen.ghannam@amd.com>
 <20231127114349.GMZWSA9QADGqCXnTYe@fat_crate.local>
From:   Yazen Ghannam <yazen.ghannam@amd.com>
In-Reply-To: <20231127114349.GMZWSA9QADGqCXnTYe@fat_crate.local>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?REo3RStoV0tSZFVRdVYxUThuZFV4NlVWNWtZdVdIbS9XTXNIQUg1ZnZTcW4v?=
 =?utf-8?B?MUFhSXhDNWNyUis1TDA2d2dmMHk5V1hETnB6bjlsajhyOFFQejNqc0ZHcFlY?=
 =?utf-8?B?NnZDOTRLUWdFWHMyaWpxZ3hKREJ5RTV2S0FhdG9qZlN6ekF3ZG1WaytRS2RF?=
 =?utf-8?B?Zzh0L2Z4RjVBUksrZ2VNOTlYSkdhSE5GSlFxMHFlQ1RFcWt4V3pKaUdGSWgr?=
 =?utf-8?B?dUxYc1JtVU9SQ1NxYWp0MFE3N1FDQTBIWitnT09aSjBaRTBDREtwWktoVnRF?=
 =?utf-8?B?OTh4YnFoSGZKMk9pdWUvMjVWbXJzdE9qSDZOS09RRXJvUTVTdzdTM0ZnTm8y?=
 =?utf-8?B?eGZyaGJ4ejJNRlJYSnJXeHgvKzJ6WmxOczRxNmljSlB5NFBRRnN3OWdMQVI3?=
 =?utf-8?B?eHN1anVEaDV5Y0ViWW9STjRkeHllZkVlWWZsWWRNbWJBREFlcXVJdmVNSXRs?=
 =?utf-8?B?NDNWUGtPZ1hCYzZRRThGU1I0YXA3SklUVVN6QlBpVFlBK3ZTb250b3hkcU1H?=
 =?utf-8?B?MVRYMVAzS3k5b1o3ZGJSaGdIaS9EQThqc0E0blRPZUhYeDFCV290ZFhwWHJE?=
 =?utf-8?B?R0YxclcvZzRDcXhuQVFZeEhSdG04cXBHNFhnLzZQdXBWaTdmZzdKU2dSWjdS?=
 =?utf-8?B?VjdZcHFqZGdKQ0wyMTlXNlNkb2hZL2ZDdUZqbTFMWWhPN3ZWeG5obk4vc29F?=
 =?utf-8?B?QnA2Vk5SaHhzMHYrcWxVdS9NMU9scDhNdUlMZmpValdXVUdyZXZyWHlKUjB0?=
 =?utf-8?B?UTRyWXdOUU1TOEpkMmlKemdFUVovbXJ0WStmVkxRRzVZSGROVk1adTRvZ0sy?=
 =?utf-8?B?M2V1TTNlYlFKZFBEMEFMazZVRmRMaUYwWUdibGhYT1B5c1A1RFgrUjZiSWpJ?=
 =?utf-8?B?Rjc4TW4zM0VYVmkwYk9janE1VTZ0aHdpOUJDU3FHVGxqb291blZqSjA2QWZI?=
 =?utf-8?B?K1lPSUVEdFBMdkhHYmR1WVVEa1pxSkhCRk5FdkRXTFJkME9abnh0NktuZTFv?=
 =?utf-8?B?OTVseEJMU1E2c1I4ZjdpNC84MGFNZFEzN2lZMW9kMjhCenN4N1huaEU4YTlN?=
 =?utf-8?B?cnh5bUxWRTMxZUJlcEFpdGpDWmFQNUdrQWJHeDlob3dhYy8vVGd0T0JWTGI2?=
 =?utf-8?B?Q2x2NHM0NWtaWS9ZR01IY1lSR09XTDhyNFNaYTMyNzBTNFpXREJOVzBtR1Bn?=
 =?utf-8?B?Y1ptcjJybHlvamNGYU9kaktDZm1kS2JUQ1hDdVJCeWNCVkNYZncybGNnVXdO?=
 =?utf-8?B?L1VTOTBQN01ZYy9FYStLY016a1BLbFg0Z0JsNXNxRU56elFYQngwclloTldi?=
 =?utf-8?B?UjBxMDFwMFRyaHIySzRwSnh0cHhzQzR0UC9nTkg5RlpqTFJXdWlMRVJEYnRH?=
 =?utf-8?B?QmJndUtwN3M4NWNlMDhXUlJpZVozdFMwbDR2djl1MlZ3NDNGK2xsY3FxNklM?=
 =?utf-8?B?Z0xXc3MrU3VobXN4VUtZOU8yNldmenVDd2tEbjVtTUV2YzRCbkxiQVk2eVJZ?=
 =?utf-8?B?ZS8zbVczTG52ZlIrZ1ArNmE5cHdPajNLek9LekRJTlJZQ0lzV0YvcHoxOFUy?=
 =?utf-8?B?a1V2OGtnbmtXQ2lsb3I2eU10V0ErYVZ5TEt5aTc3U2QxdU8zbUdNK0dnOVYy?=
 =?utf-8?B?ZHpzb2MvaC90Y3JiRXdjeitWNEY0WVFZVjNlN3FLZ2orOHZERHR2STBEbVQ2?=
 =?utf-8?B?WUhBa2QrUUdSdUZoUUtMelUwTHhKR05rVGtCSmJ5bWp3alArbFI2L05IbnVB?=
 =?utf-8?B?UnVxbWY5ZHRpM2pnYlR5ckZiM0pFc1NFeXR3QzY3eExsMGpmTGVTN1gwRDZa?=
 =?utf-8?B?SlozdWhsWk04dXBxUVZ6Q1ZlMkUwMVloVUZxcTFjOVFxSWlYZDJJRkdXTldS?=
 =?utf-8?B?U2ZiT1pGeDF0Q2l6blJnRDEzaGdXOUtsRWJuVGNFRDhBMU9TbCtyNzdjNXVl?=
 =?utf-8?B?NUsvZmZ6UWY4MGY2dTMvN1ZkM1hQVUR5bHNvU2VhdkJtUTZ2cmJoOGpSQ21N?=
 =?utf-8?B?bnJTZVJYRXRKQ3pDb3AvaGpXODRNL0lieGVYUU80UlZDYk9mR0dYTExTMmtk?=
 =?utf-8?B?ZDlNNFhPQm9wYnpFWEF6UitzWXc3RU9tc0ZDSXgvZGhibTRhMHdBU0tZS0ov?=
 =?utf-8?Q?jCKkZTwj24OtlJfrGpq5wiGIk?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2addec44-46fe-4d08-ae48-08dbef598914
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3108.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Nov 2023 15:00:03.5060
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: F+0ufRzDEZQmJpdVDQexdBygeigvM+qHZbbExvJAk/57oiEj7ieN2S/cWI5O7xSQpmIWW6Oz7HMfBOfNa7741A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB8644
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Mon, 27 Nov 2023 07:00:24 -0800 (PST)

On 11/27/2023 6:43 AM, Borislav Petkov wrote:
> On Sat, Nov 18, 2023 at 01:32:33PM -0600, Yazen Ghannam wrote:
>> @@ -714,14 +721,10 @@ static bool legacy_mce_is_memory_error(struct mce *m)
>>    */
>>   static bool smca_mce_is_memory_error(struct mce *m)
>>   {
>> -	enum smca_bank_types bank_type;
>> -
>>   	if (XEC(m->status, 0x3f))
>>   		return false;
>>   
>> -	bank_type = smca_get_bank_type(m->extcpu, m->bank);
>> -
>> -	return bank_type == SMCA_UMC || bank_type == SMCA_UMC_V2;
>> +	return smca_umc_bank_type(m->ipid);
> 
> 	return FIELD_GET(MCI_IPID_HWID, ipid) == IPID_TYPE_UMC;
> 
> after having done:
> 
> #define IPID_TYPE_UMC	0x96;
> 
> and you don't need that silly helper.

The helper is also used in the following patch. But in any case, it may 
be overkill. So I'll drop it.

> 
> And then you can do more cleanups ontop by doing
> 
>          /* Unified Memory Controller MCA type */
>          { SMCA_UMC,      HWID_MCATYPE(IPID_TYPE_UMC, 0x0)        },
>          { SMCA_UMC_V2,   HWID_MCATYPE(IPID_TYPE_UMC, 0x1)        },
> 
> and have all the numbering properly defined and abstracted away.
>

Yep, agreed. Thanks for the suggestion.

Thanks,
Yazen