Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Message-ID: <79e63555-a46b-43aa-ab2c-161e1cb80904@amd.com>
Date:   Mon, 27 Nov 2023 10:12:16 -0500
User-Agent: Mozilla Thunderbird
Cc:     yazen.ghannam@amd.com, linux-edac@vger.kernel.org,
        linux-kernel@vger.kernel.org, tony.luck@intel.com, x86@kernel.org,
        Avadhut.Naik@amd.com, Smita.KoralahalliChannabasappa@amd.com,
        amd-gfx@lists.freedesktop.org, linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH 06/20] x86/mce/amd: Use helper for GPU UMC bank type
 checks
Content-Language: en-US
To:     Borislav Petkov <bp@alien8.de>
References: <20231118193248.1296798-1-yazen.ghannam@amd.com>
 <20231118193248.1296798-7-yazen.ghannam@amd.com>
 <20231127114648.GNZWSBqPq3AzQkwk+S@fat_crate.local>
From:   Yazen Ghannam <yazen.ghannam@amd.com>
In-Reply-To: <20231127114648.GNZWSBqPq3AzQkwk+S@fat_crate.local>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TGd5cnI0VDZDa1JTVEJvcndINGhZbEpxTFhUQVUwakpIcnRtRzkzSEpKU1Zj?=
 =?utf-8?B?V0lKYUtoa3BnZXpyQUdDVDBnM20xNzNENml4dmZHaGNldFYrWkZOZHBxZWNN?=
 =?utf-8?B?MUowaFEyN2xpdHg5QzJzV0g0UkhmN3c5cFliN081MFJEUGtwTzJCNUMxTmFQ?=
 =?utf-8?B?V2FjWGhIeVppNHZlVHJlRWtBT2JjM3g3L2dYMXAzZE9xcER2amhEelV0TkRL?=
 =?utf-8?B?amtVYmhJSmZTWmR4SUZGbDF3SzBMSVdUQ0N0bkd6anluWHZNZkpKaDk4ZEc3?=
 =?utf-8?B?bzB4R1oyR0dCeGNwaDEvdExIR3plR2ZYWXNIY2RRVTB1SFBVR0pSY05BTnhZ?=
 =?utf-8?B?NElBcW1zZG1iRmdzclVRc0tyM05iNFRsTythS284QjBPdXhOck1yRks5c2dh?=
 =?utf-8?B?NWxjUTZqT1E0bWhGOE5lM1FLUnlFOXBKbVdILzMrKy9JY2JiL3FxVzFkZ0lQ?=
 =?utf-8?B?dXN4WGFyQ2RTbFZNa1padGN1T0l1NFJ5SzFwMzdHZm5xMmgvZUErR2RqWWdW?=
 =?utf-8?B?U1EyV0h2T241d05kSUdSbWhZWEozU3hkL2paaSsrVzRoR2F0WmkwQk84ZkJr?=
 =?utf-8?B?VzFNVDJ4RE4vT0Riei9GNEg1azhocWZjOUtIU1NPUUtBYlJqVXhwbzcvNFFR?=
 =?utf-8?B?TStERURXaUhLVVlpM3owbmpDeloxb1hoaWlOTHFkSUl4WnlTUkg0a21xZ0Ew?=
 =?utf-8?B?dUpEeUVsZThOTE5jUEkvRnBIMjc4MzJtUW5KaGoyQlFCOWZjQ214bzNIVmtQ?=
 =?utf-8?B?ckRqbE1XdkZmWm1rbVpVYng0L3lDTnVkcmNwL044M2dnQWlZSTFOZzRpMXpZ?=
 =?utf-8?B?RGcvK2pianM1b29hNDRTWkhoODI4K1o4aFFRK1VUY1Axd2FJRkRmT2puams0?=
 =?utf-8?B?MkhBV3UwSmxyQ1Vpc09xdWtIMVdkWXpUU2VpR2ZFc2Z1RHEvdmlQbmVHNmVK?=
 =?utf-8?B?bWg0UzlycTdSUjNhTjBkVDVzOEt1OHBuOXcvNk83UlVhYUhtbExFVFd4Zzkz?=
 =?utf-8?B?a2xRS2pKblJiSnlZV1JmTG1Kd0hUTjZCTUNjV1pyQlI2NVhGWXk0ZHpmWUZJ?=
 =?utf-8?B?MjVwYytmMFNIMjA1b0hjTENaQW8zcmt1Wk1Ed20wbE9ueXY5S1dpWG5hMWZs?=
 =?utf-8?B?N04yK0hFUmFEZGkrSHV2aWhuVlVhNDJ4dmRMWVh6cytqcjdYcTlWQldvSGxr?=
 =?utf-8?B?elRXVEYveDVwRUt4RzliZEdkN3l1eXgwWDk1bDU1QnU5bG4rUEF1QmRGVDdv?=
 =?utf-8?B?NmNXUlZucmZKU1lSVmkzUi8vNmVseUNBc2lvY1FnVGhITFFNMWJvQlZlRTZU?=
 =?utf-8?B?dmFQT3BnVCtPc081MTRTdDduZGVncXN3QXhmL0xraEd6ckcrYWNpTElISldx?=
 =?utf-8?B?VEIwQjhQTDRGamE0YkNmN1RDMC92aldtbDBtRE82T0t5dFlYL3ZZengyWmIw?=
 =?utf-8?B?d0hKSVNWMUJDT0VKay8xOWpycUZCWUt3c1dmaVh0Wk9iVjN6ODl5M3MvbTht?=
 =?utf-8?B?bjBZQUpETTQzRCtudHZGR3ppN2lmNjk5QUxwVzJIdjFFU2x5M2hQalhMVU81?=
 =?utf-8?B?bjlQcVo0S1llanFLeUpYYTQxQmJjOFNpbE50YTRibzVZNms2YkJpS0Q0UkV4?=
 =?utf-8?B?bGRXSjF2MkRhWWt4OGdrcVlOZEJDYzJoelpIZFZkQzE0eHNhUTJSYzY4dEVh?=
 =?utf-8?B?Tks4d2l2MUZ3UkhjU3lCd2ZQQ0hWdytIRnBaSWFqSEVMalNSb2d6ZjMwNGlZ?=
 =?utf-8?B?MXJueFZ1TFRBZE8vWmdydHpiNklabll2MW5lVHNhb0UrZUpJT3JiMzhmSHZp?=
 =?utf-8?B?VFRISDVnd21NdTJSTjQxL1Z1R2tsRWd3SFBoTEhVbzRoejg1MFdaNXVYZWZM?=
 =?utf-8?B?VnlXamVkWEtRTE4xajZhNHV6RVpRSmJEWXYxdWlmM2FQYUdpa1NoTFRvVjgv?=
 =?utf-8?B?ZXErNW0rUmsrbFA1eHlDOUhXZkFHb2hjeW5zTzg2SDBWcExNYlByeDNaUEli?=
 =?utf-8?B?K1Q1SmwrMm5oUzFvZmszcktIVzNtKzNvZmNzUFArZkQ0eGNvNUlGRFJ3MWRh?=
 =?utf-8?B?cjVobDNtRnNxU1FqSi9aTjc4Vm0xeTcyNkxuRmN3d2paYkFwTzlXY3dKUFVF?=
 =?utf-8?Q?UQY3K9DKG9pt4XHt2Z+PBNNJ8?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9f0b4a45-4a79-4f1a-55fe-08dbef5b3edf
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3108.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Nov 2023 15:12:18.0097
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1HhnYd8lOIKGI9YjzlAhgwzXWskKNfbqQQ3pNwJ5n9215iZUXd8t33SBl7MiLoy2nm2m6CDjReCL0JpyOMPGuw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB8028
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 27 Nov 2023 07:12:33 -0800 (PST)

On 11/27/2023 6:46 AM, Borislav Petkov wrote:
> On Sat, Nov 18, 2023 at 01:32:34PM -0600, Yazen Ghannam wrote:
>> +/* GPU UMCs have MCATYPE=0x1.*/
>> +bool smca_gpu_umc_bank_type(u64 ipid)
>> +{
>> +	if (!smca_umc_bank_type(ipid))
>> +		return false;
>> +
>> +	return FIELD_GET(MCI_IPID_MCATYPE, ipid) == 0x1;
>> +}
> 
> And now this tells you that you want to use
> 
> 	u32 hwid_mcatype;       /* (hwid,mcatype) tuple */
> 
> everywhere and do your macros around that thing.
> 
> No need for yet another helper as this all is static information which
> doesn't change.
> 
>> +EXPORT_SYMBOL_GPL(smca_gpu_umc_bank_type);
> 
> Definitely not another export.
> 

Right, we already use the tuple thing. Patch 8 in this set uses the 
tuple to look up (search for) the bank type at runtime. This is in order 
to get rid of all the per-CPU stuff.

Now I figured it'd be good to have special helpers to do a quick check 
for the UMC bank types. Because memory errors will be the most commonly 
reported errors.

But it's likely not important to save a few cycles here. Especially 
since the helpers will be used in the notifier chain and not in the #MC 
handler, etc.

I'll think on it a bit more, but this patch and the previous one can 
likely be dropped.

Thanks,
Yazen