Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp3169499rdh; Mon, 27 Nov 2023 07:53:02 -0800 (PST) X-Google-Smtp-Source: AGHT+IF3iCG48SwfT4ETi0luK2nbGQC6kEtLC0A9r9toOYuoNPJUxUrBkamFnWozTarHsS0n805u X-Received: by 2002:a17:90b:1d84:b0:285:b876:5038 with SMTP id pf4-20020a17090b1d8400b00285b8765038mr5914293pjb.39.1701100382166; Mon, 27 Nov 2023 07:53:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701100382; cv=none; d=google.com; s=arc-20160816; b=p9skGBNwJ84w0GU84N+2MEssERLVh6HMVWKGPhKHokHKZAN/5rKLYSjUbyWicnB+2L zwdFRD2aEjbGRYQTd/vIQXy/9PuISOSpojS/N2jXbOtji0fpgJeXUYrZY7tKMmbCp2Ax EHA6NrgMfFQw+V1oF/l6a4/IZLSFKRN4ne+TqWxH6U0+QO5/3J7OVYwtS7E0cs5Pll5n yP/zA1ThLWLW8vUP23Z5BFAyCDlHAnWWEDleC2tm4mSjW/ahhPY8bNvQPRgQXrpVF/8i xpX0MEJqiZiiDNZ99H6IImrtHh7NUiZ8mI60HD4pAvLbb7+H7/OOsLhl8mZGztbLAKhA 1g5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=5N6kZb4IAgxIr7SYxQl9PYNEUJjuE+UwQ2fmZlq2BKE=; fh=aK65aNznMbqxL52we2kvrGlipk+CpLzOZyoW2ahcfTg=; b=hvRDUFxQAnv3FPs6LlzuAl2UuiKYhk94SLQV1CRGkPiLvLoiqKGeTLUGlLGu591/pW sjphqzlZLKnyhxO46bIHEj3Lndiucbr7nbdmEFlos9DuO2fGV5aYZD+A5VkTy/K3yveA Ia1gygYk2oAfvH/zFhJc8hRVtt894p0Pydb7E3Eov45L6UfoQyEZVxGxraQk7dbSNWPm X4U+SEbfByuL7o3BbB5aH/JK4onco37sKYx967ffwT2zRN2IG0hSkxJWK6mXANy62ck4 esAXkboYl/q7VY8li00kX8Ifadl/X/dptTZcyMEjo2B2v6ijJ/QamLbDMxUCLSGTtVh8 jCbg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=WIPkkKv9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id ep2-20020a17090ae64200b00285259acbcesi9897120pjb.142.2023.11.27.07.53.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Nov 2023 07:53:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=WIPkkKv9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 188098136BF7; Mon, 27 Nov 2023 07:52:54 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234079AbjK0Pwf (ORCPT + 99 others); Mon, 27 Nov 2023 10:52:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234082AbjK0PwS (ORCPT ); Mon, 27 Nov 2023 10:52:18 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6BC9792 for ; Mon, 27 Nov 2023 07:52:17 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 80E98C433C7; Mon, 27 Nov 2023 15:52:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1701100337; bh=5u1FD6v6ixPZgDy+Cll9ZwyPBlwrxX8SjGva753EFHQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WIPkkKv9CLGKKc3kD0b1mtlSxoZoSf4b2NDd2Jpm0qDbNQpwxZlKToKjicFGQbk6f HNSHhf4ZTSq7IVQKS27sD8z6/3ZjJcoqy9T0LXFcz8O9j152SXOmvUEKO8s770kPIx ARtPWL+xbpx6SuEr+VunYzxIIrCLdMtUjsyWgYB0= Date: Mon, 27 Nov 2023 15:52:13 +0000 From: Greg KH To: Frank Li Cc: Peter Chen , imx@lists.linux.dev, Pawel Laszczak , Roger Quadros , Aswath Govindraju , "open list:CADENCE USB3 DRD IP DRIVER" , open list Subject: Re: [PATCH 1/1] usb: cdns3: skip set TRB_IOC when usb_request: no_interrupt is true Message-ID: <2023112748-coveted-enunciate-cf13@gregkh> References: <20231027183919.664271-1-Frank.Li@nxp.com> <20231031084521.GA1948529@nchen-desktop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Mon, 27 Nov 2023 07:52:54 -0800 (PST) On Mon, Nov 27, 2023 at 10:28:57AM -0500, Frank Li wrote: > On Tue, Oct 31, 2023 at 04:45:21PM +0800, Peter Chen wrote: > > On 23-10-27 14:39:19, Frank Li wrote: > > > No completion irq is needed if no_interrupt is true. Needn't set TRB_IOC > > > at this case. > > > > > > Check usb_request: no_interrupt and set/skip TRB_IOC in > > > cdns3_ep_run_transfer(). > > > > > > Signed-off-by: Frank Li > > > > Acked-by: Peter Chen > > @Greg: > ping What are you needing from me here? Blind pings do not provide any context :( thanks, greg k-h