Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
MIME-Version: 1.0
References: <20231123032615.3760488-1-victor.liu@nxp.com> <ZWSbKkgs8V4sdy8T@intel.com>
In-Reply-To: <ZWSbKkgs8V4sdy8T@intel.com>
From:   Linus Walleij <linus.walleij@linaro.org>
Date:   Mon, 27 Nov 2023 17:08:40 +0100
Message-ID: <CACRpkdZG+8KPWGNcp1jGXnSodXqS0qXiwXDPqf1yqoDZw1aS8w@mail.gmail.com>
Subject: Re: [PATCH] drm/bridge: panel: Check device dependency before
 managing device link
To:     =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= <ville.syrjala@linux.intel.com>
Cc:     Liu Ying <victor.liu@nxp.com>, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org, mripard@kernel.org,
        neil.armstrong@linaro.org, ulf.hansson@linaro.org,
        rfoss@kernel.org, tzimmermann@suse.de, jonas@kwiboo.se,
        jernej.skrabec@gmail.com, Laurent.pinchart@ideasonboard.com,
        andrzej.hajda@intel.com, angelogioacchino.delregno@collabora.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Nov 27, 2023 at 2:36=E2=80=AFPM Ville Syrj=C3=A4l=C3=A4
<ville.syrjala@linux.intel.com> wrote:

> > +     panel_bridge->is_independent =3D !device_is_dependent(drm_dev->de=
v,
> > +                                                         panel->dev);
>
> This broke the build. Looks like device_is_dependent() is not even export=
ed.
> ERROR: modpost: "device_is_dependent" [drivers/gpu/drm/drm_kms_helper.ko]=
 undefined!

Yep Ying made a fix, I just applied and pushed it because it was obviously
correct.

> The recommended defconfigs in rerere-cache do seem to have CONFIG_DRM_KMS=
_HELPER=3Dm
> so this should have been caught before pushing. How did it slip through?

My neglect.

Neglect may have something to do with my desktop being 10 years+
old. Building random defconfigs on this machine takes so long time
that invariably other stuff has been pushed to the branch before
the compiles even complete.

Yeah I know. I should buy a better computer.

Yours,
Linus Walleij