Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
From:   "Bahadur, Sachin" <sachin.bahadur@intel.com>
To:     Jiri Pirko <jiri@resnulli.us>
CC:     "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH iwl-net v4] ice: Block PF reinit if attached to bond
Thread-Topic: [PATCH iwl-net v4] ice: Block PF reinit if attached to bond
Thread-Index: AQHaIPe/QZ4HasPNt0KtTZtgr5dQa7CN6caAgABvukA=
Date:   Mon, 27 Nov 2023 16:23:55 +0000
Message-ID: <BY5PR11MB42574D2A64F2C4E42400213A96BDA@BY5PR11MB4257.namprd11.prod.outlook.com>
References: <20231127060512.1283336-1-sachin.bahadur@intel.com>
 <ZWRkN12fhENyN4PY@nanopsycho>
In-Reply-To: <ZWRkN12fhENyN4PY@nanopsycho>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?M6LccqGjd8+StQSegge3vgeVMtJb7NS28YEF3rwCdofYZKV/j7TxBNfZB/R0?=
 =?us-ascii?Q?cUigj1bJbRO75AXJwxJUTsxm+JIS1oN/tycOGSemXbM2SpCuetNT+BgWLCAj?=
 =?us-ascii?Q?n36bYdJGIJwvfHfKAJjyhJ0z5ffPUlBf4SH240uEU7zNViOXnWhs2lLet/P3?=
 =?us-ascii?Q?QwaMd8wyF49L3rQndxhYfGTXwp/2gwa+oAIQfpmYeyGdrF4K8UJCp+WGtqOo?=
 =?us-ascii?Q?DJ6Jc3ElZRlA7sMPbVJ9kQ/438iNduDn3x7WFU9h+MZ8pcQxx7Dwl/Zn1yMd?=
 =?us-ascii?Q?mMKyVDm1vafkM3foA/oBnzJCuUVQ/lRgwq1h690P/ZVcJ6NHuNqlA3NL4TI1?=
 =?us-ascii?Q?hVGV4AiE3Uc8iDDTH6oIWKUZNVM0Nurx2eaPt54ChPOF/WrzC/WjVLOcDJJU?=
 =?us-ascii?Q?bwxsJREwf2sdn+ZCNxeNX1x/AeMfNBqRogCPVQpwiePh1QCwnNtsaIeGcnXQ?=
 =?us-ascii?Q?z3sfTV4CB3BFGbh2jdxtNqZXgI4HJCnMJHZzKDIIzd6Q1dyW5S/YkwPS1Bm1?=
 =?us-ascii?Q?DD5Q2BKiZ/Y5gy8gcVpoKimfwjdoZJATCuEhmdEl8Bq4Oa72LF7TA1yGE4/Q?=
 =?us-ascii?Q?D/ncDoJajKfM4dsaYqdJVyeJxLm/G2s5UJI9zEhQxEp/DUEw/I1etOdLLUA7?=
 =?us-ascii?Q?6SxoAT5GUywf/L157TWauYNYM4UUMaw2ccIVoIXWJ3rTZzPBZ/gFsyKNnsnC?=
 =?us-ascii?Q?HxKk6XJRzxlntOSHxM7bdlKL+9pqMK9fBQzCqf5YLnS7MwH9IzKaWBgjvQ1o?=
 =?us-ascii?Q?Krpa0mnoeq62Sf6bwen0BEr1xUrY8RZm8MaWZfS5migg+C0PPUXrrGY6GE/D?=
 =?us-ascii?Q?jfOyed3yZS34lVyS5/5hF9l2LvPWFnd99do/mDwpB5GC1zLQdNFyalq4Vyvt?=
 =?us-ascii?Q?+bCLh8q0Rhkm9WttwE9bG/yCV0IAxUwRC0OkI+cfe29u4XUCnazCIgshoYsO?=
 =?us-ascii?Q?EdeZJAbBN/PDEapmosjeH15pRnyzqkGWdnvJcfKUEdC23Fbs5aS2S3ROGrW1?=
 =?us-ascii?Q?H0/kuUL22b+zrHM74YNjEWbbm9ADFewpSmMHwbKeFwRTXp5AN/DZTGzgXU3r?=
 =?us-ascii?Q?mia0WEauZx96xwVtCH+u1PuM7te1Ui4sDRlxO0PtryXwdtBRDfoLdbyFIk4m?=
 =?us-ascii?Q?Ey8SrifGY1FIk/8GrdIMCNt3YA2/VgoXNtcGyY4RIXMer+EEoXhvG8n6l2bW?=
 =?us-ascii?Q?xvw/Qb2A3gf8cssbpM7zuvnwH2wH2fwv1XcuYxwIv/MIHftKhoWnJ9FOK1Ed?=
 =?us-ascii?Q?L0bIRP0ZLCW8C7ahHYF3Q9JCGDnVt/pbzPAvV75eAH/pU2rGzG7SMlI8ADHi?=
 =?us-ascii?Q?ksFEdPQ6KfaKYCEcdILP5uDC1PIkl+M3zGBEgB+p4OCaoEsSNuJw7bMnbALB?=
 =?us-ascii?Q?XbT3znbMnOpAVY+zgEnzkbuGOFlTn3RrYA49kDJvLlWUmrV765Cr6Q4TlBpF?=
 =?us-ascii?Q?EP481qsFoV8Pcp9NN/7rYMtCl62vaLKVOW2AuTyzdmjH7hNFEqR8y3GdPkh0?=
 =?us-ascii?Q?jkyzFrxqUvg6mu/cHIbIablczdZNvNs6nBCxWOiK1riF2sEK3zohQYC7XyvT?=
 =?us-ascii?Q?2M8cuaPvwuahVllAu2ohsuJN9nRoKjuWh6zm9VZf?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BY5PR11MB4257.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5f26fd20-b81a-4355-57d3-08dbef654047
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Nov 2023 16:23:55.1779
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: vBpw8b9/2EJoPlCzZIroC9fTj1xZiJUgIxQ5bGmD6LmLh4c8Hzr9zNsY80oY7kuVtzwJsaLe3YnbdQw2h/M99olmNhv2P++TguIIqE271cY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB7564
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 27 Nov 2023 08:24:23 -0800 (PST)

=20
> Nack. Remove the netdev during re-init, that would solve your issue.
> Looks like some checks are needed to be added in devlink code to make sur=
e
> drivers behave properly. I'm on in.

Sure. This fix should apply to all drivers. Adding it in devlink makes more
sense. I am not a devlink expert, so I hope you or someone else can
help with it.

>=20
>=20
> >+			return -EBUSY;
> >+		}
> > 		ice_unload(pf);
> > 		return 0;
> > 	case DEVLINK_RELOAD_ACTION_FW_ACTIVATE:
> >--
> >2.25.1
> >
> >