Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp3222388rdh; Mon, 27 Nov 2023 08:56:53 -0800 (PST) X-Google-Smtp-Source: AGHT+IErEB1rjTC9k7G/XEleKFb8XKV+HOtgNheT4wwVKS2hD+4k3oq0wBfA1Dq9WPDWr/Tecf8L X-Received: by 2002:a05:6a20:6d9e:b0:18b:4dc2:a4d8 with SMTP id gl30-20020a056a206d9e00b0018b4dc2a4d8mr8851792pzb.8.1701104212626; Mon, 27 Nov 2023 08:56:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701104212; cv=none; d=google.com; s=arc-20160816; b=IK2LwPq5olmQP2NUqhF0UAwqhqCey2JV4o6Lx2PSNiFTeA9NKqaSpgpLk9ULL+MltH iE/SGQSnRImQl3Trmg0Iiyz8XXkMFUmmB80LjoRcGGgC71JO+nuxXRSE0UWgNgJO8kxQ n+JV1ordcSs0E9HQqJtnSGyIZxKqAcW0VNNpBFpCRZrBrXdFb8jf9zJoIvL01mcviNxQ 3ouIvAxYIzslvFiJYzk0iJin62nwOQF14JE51ajoBV1r5Wq0hPKox+govDtTDuSwgVXc 1UBLEwPsFCU1O7mzMzGFYr1UqRyH+5WTG64emzrP2dDzWWJdJl5GadlN3+p8qkck49a0 dHAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=tWI/ser4D+gUe9Uu+9WaR7BOmLMH4p7k3i3Qv2RY/LM=; fh=6Qtl8iZGoLN6JUWLuXnO6pSSFZd40pa3oPqH4w6wu8Q=; b=YQ0v+RX3tXF5F3qCj7gPC9Uphn6ok1pXN4NVY3Op/Zsk3To1VASrV2f/3iLUKrKHx5 aUYSemCw7oKFPstZCblnL4byVHeePGefbpDvLOPtBSI92luJabodcU12T2ey9FkcA6de iIczcBC1aTkvI6MGEEq3TG7v1C5ZEMyLBY6rH40QJpHSf8yRFwV85ra5MwhM6oxc0w4B tO409XyuQOeqywg8humnALKsZ3aiZvFN12IsFtRH+zNMTJvX4MlczZGzuB4yd3ULWDJt BgyeiTCEpN8bZUtlSinALI6H8EQ80q7p/ulNLGimHl9rvkHA4HGgUVGsPedDRshkygiB w3cg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=Err5SscR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Return-Path: Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id fb13-20020a056a002d8d00b006cb63c86cc2si10496097pfb.100.2023.11.27.08.56.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Nov 2023 08:56:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=Err5SscR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 0E747822D567; Mon, 27 Nov 2023 08:56:44 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234252AbjK0Qzb (ORCPT + 99 others); Mon, 27 Nov 2023 11:55:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33742 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234313AbjK0Qz0 (ORCPT ); Mon, 27 Nov 2023 11:55:26 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 40433D62; Mon, 27 Nov 2023 08:55:16 -0800 (PST) Received: from benjamin-XPS-13-9310.. (ec2-34-240-57-77.eu-west-1.compute.amazonaws.com [34.240.57.77]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: benjamin.gaignard) by madras.collabora.co.uk (Postfix) with ESMTPSA id 4ABBA66072A4; Mon, 27 Nov 2023 16:55:14 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1701104114; bh=TyWnSNSrmM8e46vPb9QIHFcmc4e6SFgOyK7FFQxtbXw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Err5SscROifk648ZJExh4TQcnejZoFk5VctUstRXFW7HD/aTCrbJQJX8ZSLDvvyRL MQLLvghzMeFsGURIpqImWeUvuqVd/eyR8Azsb4eHTgSWBKOUcyPuPWfFnhvWe/zshf a0DtV3EBKK37x+NgmCtrbbdsIevIEP65WtQyWnxpmnRZq9ZlZ3eemnDf+sWtBRIyCa rttpbZsQHyXxXKX2GYv69QEk3eyMnHYeAYyQp/VaT1vJJpl0TRoFihbCrCg1NzoNao rFxqDtpQmDWOg0mLYj8078e7FMg89rwT+n01VTwqP2Jy1V9cqPCCXEK006LM0k7fZN 5qi/QTyW5oC8w== From: Benjamin Gaignard To: hverkuil@xs4all.nl, mchehab@kernel.org, tfiga@chromium.org, m.szyprowski@samsung.com, matt.ranostay@konsulko.com Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, kernel@collabora.com, Benjamin Gaignard , Dafna Hirschfeld , Laurent Pinchart , linux-rockchip@lists.infradead.org Subject: [PATCH 12/55] media: rockchip: rkisp1: Stop abusing of min_buffers_needed field Date: Mon, 27 Nov 2023 17:54:11 +0100 Message-Id: <20231127165454.166373-13-benjamin.gaignard@collabora.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231127165454.166373-1-benjamin.gaignard@collabora.com> References: <20231127165454.166373-1-benjamin.gaignard@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 27 Nov 2023 08:56:44 -0800 (PST) 'min_buffers_needed' is suppose to be used to indicate the number of buffers needed by DMA engine to start streaming. rkisp1 driver doesn't use DMA engine and just want to specify the minimum number of buffers to allocate when calling VIDIOC_REQBUFS. That 'min_reqbufs_allocation' field purpose so use it. Signed-off-by: Benjamin Gaignard CC: Dafna Hirschfeld (maintainer:ROCKCHIP ISP V1 DRIVER) CC: Laurent Pinchart (maintainer:ROCKCHIP ISP V1 DRIVER) CC: linux-rockchip@lists.infradead.org (open list:ROCKCHIP ISP V1 DRIVER) --- drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c index c6d7e01c8949..de3d89b1fac7 100644 --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c @@ -1431,7 +1431,7 @@ static int rkisp1_register_capture(struct rkisp1_capture *cap) q->ops = &rkisp1_vb2_ops; q->mem_ops = &vb2_dma_contig_memops; q->buf_struct_size = sizeof(struct rkisp1_buffer); - q->min_buffers_needed = RKISP1_MIN_BUFFERS_NEEDED; + q->min_reqbufs_allocation = RKISP1_MIN_BUFFERS_NEEDED; q->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC; q->lock = &node->vlock; q->dev = cap->rkisp1->dev; -- 2.39.2