Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp3222426rdh; Mon, 27 Nov 2023 08:56:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IHcsWdg7RNu5ny/M721hU1irs2wOrFrFH7Y1ztwnmqSBKnEA4a2Y8VKuO6t+dY/FOMs2ice X-Received: by 2002:a17:902:a712:b0:1c3:6d97:e89e with SMTP id w18-20020a170902a71200b001c36d97e89emr12396623plq.58.1701104215266; Mon, 27 Nov 2023 08:56:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701104215; cv=none; d=google.com; s=arc-20160816; b=rziZBXylaTf9Kh3EzedWn9gqpRBox6Z5FCXCf9ctaqaqwHULbyYoCGQe5yzeCUxucp TvJEapWL5z1BepdebJcvVSVcNx+FcUpyR2E8o44D8oKuHPKNG31Fp15wsVa5hXhZSlNB e/7ZZIKmvGbUJsQN9qAO4W3PSU2TklvGXp3U8pu+r10fxeKPO1Q90apuDpw5gkr0yfyx V3gs8AjjnE7gkgYXDffDYExZC+tyMdsTIQDlffEOf+HS/QsmPfVpFEjylYVgpf3cpBe9 dDMT93Nn/n5cIgNYeVJ8JspOhH/4db9mDA/ybzX9jVx/m4sXUg7JUNvcNYh6tT49wdXm AINA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=a7nZ1PRDitkCqjBHsaihCPuzInVMEyteoLUQpBrHmOk=; fh=XADoe4SDokwAxxVUjMbPMzOPT1Su1y27+I89Xw5yMIw=; b=xI9SNf2pPi40Brk1CpQBLEr2I798O0V7tc/wY5FTSujNPkmnGJc4mQPUPK4h4EV/6N aanjjuAPM2QcmxPiS3YDSrx3AjlLju3eHMyjN1N8uszjNanENDHSLfbXBBgMYqZdBGdv F0szJXeXQDCS8wKr8NazhmGI+W4h52+S+5iimeea59UGMnN3Lahjrabr1fNN5Jk8G84z y+6SlxhZ4BvHIs6LbrndiRJ+UbTylMi1UkI0yBE6PP4tK6U0W6YpQS77ZuSbZOAGlCdr 1G0B6yswXWwXHEKMYwaOjhy7Sz1K7Y0TDGzVOFXfNNWI3HJhFs4/pFgEdF/ncytuK1Zb k+Nw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=aK5Jnza1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Return-Path: Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id a4-20020a1709027d8400b001cfb967b763si4783762plm.32.2023.11.27.08.56.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Nov 2023 08:56:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=aK5Jnza1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 931488158388; Mon, 27 Nov 2023 08:56:49 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234368AbjK0Qzg (ORCPT + 99 others); Mon, 27 Nov 2023 11:55:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41200 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234354AbjK0Qz0 (ORCPT ); Mon, 27 Nov 2023 11:55:26 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1975610C3; Mon, 27 Nov 2023 08:55:17 -0800 (PST) Received: from benjamin-XPS-13-9310.. (ec2-34-240-57-77.eu-west-1.compute.amazonaws.com [34.240.57.77]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: benjamin.gaignard) by madras.collabora.co.uk (Postfix) with ESMTPSA id 1F6F46602F16; Mon, 27 Nov 2023 16:55:15 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1701104115; bh=aaWCiqdk39sHKKb5QCMsk+ktnGuP0FZaTGK54tWrHxU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aK5Jnza1wx5sBNowajBeB5DX02ljyxjC4c27B+SImhywaxDxh9iCWLMyGA6/UTFrH HBZ4/iQONttHOownb4AKM+IHPs/4xfuQxikg3zgIwYVlxg04TAra+pMkvVpzbKpNWR iqxH2MQ7+vOr67hiT9DknWQebgDsWq6NEk9vRDN4zSygZkXgQThE1ES8F32RI4TScb 4NiwI1BHAodRWKJmi8XWytuFZ6QVBJUsYU64tamXX/goCVjX19CYKQGlXiav+HheR0 MxlIiIo1fwqnPjis8aD9W9KSfAUC8QxT+f4twZUoucK4OU9AzD2xVEQCvwk62b4+8A b7e83ngdHNcvg== From: Benjamin Gaignard To: hverkuil@xs4all.nl, mchehab@kernel.org, tfiga@chromium.org, m.szyprowski@samsung.com, matt.ranostay@konsulko.com Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, kernel@collabora.com, Benjamin Gaignard , Eddie James , Joel Stanley , Andrew Jeffery , openbmc@lists.ozlabs.org, linux-aspeed@lists.ozlabs.org Subject: [PATCH 13/55] media: aspeed: Stop abusing of min_buffers_needed field Date: Mon, 27 Nov 2023 17:54:12 +0100 Message-Id: <20231127165454.166373-14-benjamin.gaignard@collabora.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231127165454.166373-1-benjamin.gaignard@collabora.com> References: <20231127165454.166373-1-benjamin.gaignard@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Mon, 27 Nov 2023 08:56:49 -0800 (PST) 'min_buffers_needed' is suppose to be used to indicate the number of buffers needed by DMA engine to start streaming. aspeed doesn't use DMA engine and just want to specify the minimum number of buffers to allocate when calling VIDIOC_REQBUFS. That 'min_reqbufs_allocation' field purpose so use it. Signed-off-by: Benjamin Gaignard CC: Eddie James (maintainer:ASPEED VIDEO ENGINE DRIVER) CC: Joel Stanley (supporter:ARM/ASPEED MACHINE SUPPORT) CC: Andrew Jeffery (reviewer:ARM/ASPEED MACHINE SUPPORT) CC: openbmc@lists.ozlabs.org (moderated list:ASPEED VIDEO ENGINE DRIVER) CC: linux-aspeed@lists.ozlabs.org (moderated list:ARM/ASPEED MACHINE SUPPORT) --- drivers/media/platform/aspeed/aspeed-video.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/aspeed/aspeed-video.c b/drivers/media/platform/aspeed/aspeed-video.c index d08aa7f73d4f..c28b10808cda 100644 --- a/drivers/media/platform/aspeed/aspeed-video.c +++ b/drivers/media/platform/aspeed/aspeed-video.c @@ -2034,7 +2034,7 @@ static int aspeed_video_setup_video(struct aspeed_video *video) vbq->drv_priv = video; vbq->buf_struct_size = sizeof(struct aspeed_video_buffer); vbq->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC; - vbq->min_buffers_needed = ASPEED_VIDEO_V4L2_MIN_BUF_REQ; + vbq->min_reqbufs_allocation = ASPEED_VIDEO_V4L2_MIN_BUF_REQ; rc = vb2_queue_init(vbq); if (rc) { -- 2.39.2