Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp3223068rdh; Mon, 27 Nov 2023 08:57:49 -0800 (PST) X-Google-Smtp-Source: AGHT+IGRStHkEKOJ5lFJO6DDhuuAz1tT5erlliX77e2jMb+Mmwo0LRBwgqx3hjvr+hCV6IyQWF/s X-Received: by 2002:a17:902:d4c5:b0:1cc:22db:cf3d with SMTP id o5-20020a170902d4c500b001cc22dbcf3dmr22316243plg.15.1701104268729; Mon, 27 Nov 2023 08:57:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701104268; cv=none; d=google.com; s=arc-20160816; b=GfyOMi2DDnSLcSXa0QlzeI+bo/x2OcUZIunq3hMjpLTpUAB9B/dZg3aeeRVRDllnEl kfio9MTQk/4OPsfb0aArK8UXR8ifgZCiufdHExahFJ/vq4iy6yOMfjkHvZcqcLd0pj4G YPWWwpteagXfZ9Wao2rw1gyyHrJ7km0u5BNNaN2Wvd9YBiT2bKwGf6oJN+72y+BOewcT DJqOFh0mrw9YqPgOp/sEGZxypOSvg1ckqne4dprtoNM4mIuatis0VhqA+ZWn/BMLzj+t mgN+RLdnR23NzVxMZdsyUlatjjI7GL+lxJj1Czo1blAF2/xRpCoUsA1phOuHOXv8pOKu m22A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=4+ZaZqPZwgPild56G38jJn8a5yioVH70h4EBqMd0LDw=; fh=bQ/9cLuVXnxkmkl6uvGq10tPVYRHKGSQEztRUXZtt8Q=; b=AUs47mMJKOuWWQWV0NX0TYyOt+Ssss8VpI21Xa6FVuX7mdeDasRnkpjaczjXzcnB3L argx0GJ8xeTQ2pLRqP57izQKJgPX0GrHy+nVXj/MxHovJHbe0HxrGS8njy4ks8Ej88ts UE/+3A9C/l1wVRIAxdakwBaGyp9HlWye/lSyZ3v5omNF2oACB2Vmu1mU1ictzysKFEPV /LrOqP4ergNMo1vHj6qqmxfxxiAregLqO3mDldd0LIAzPID+qvFQikufH9B6jZw3vnEN EeA16/4lk/qlwh1Vmp0stmKuRKOpN4zCm2rrjFaoK91dtEKPm1SvVPCgYKqRy01NsDLr SsJA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=AiG+Ejb2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Return-Path: Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id u1-20020a63d341000000b005be3c62f45fsi9971958pgi.638.2023.11.27.08.57.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Nov 2023 08:57:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=AiG+Ejb2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 2D4E2815831A; Mon, 27 Nov 2023 08:57:42 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234418AbjK0Q4q (ORCPT + 99 others); Mon, 27 Nov 2023 11:56:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51674 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234549AbjK0Qzy (ORCPT ); Mon, 27 Nov 2023 11:55:54 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7E9F91BFE; Mon, 27 Nov 2023 08:55:28 -0800 (PST) Received: from benjamin-XPS-13-9310.. (ec2-34-240-57-77.eu-west-1.compute.amazonaws.com [34.240.57.77]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: benjamin.gaignard) by madras.collabora.co.uk (Postfix) with ESMTPSA id 75A956607286; Mon, 27 Nov 2023 16:55:26 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1701104127; bh=YIgkAExbbbECDPnkaD6N0lG+VUJuWN8PC9JRmzX9TCI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AiG+Ejb2+mNZ23dQ58fH8HeFPy3hJ02mlj2Hi6rxIeY+Gy1a8/QIAfOk23U/takDW v6q5IkEXN2y6tQf+omLSLpcCgvsdNkad61xg1wUI87O6gd/fMVHJPt7beMBJxoFrzv o3zi6w3FT8MG0PcMXFjmkzio7deWNDtDOAOgQxgjwDHJYjxGTvkbAVGKotPtggFhjH nEwfKFLrFCHpdhjTGSVVIYW9HnpEUsKJSQJhbxaToNiZ+59Uk/fYnCZBuMuMOIXmHs 95pGFhjthjI/q+XLSrPOYxKfQ89KGXqn3gvvCg3f+9+VRpC04Qij8+Svm2OuMVLuVw WvZajJW/poNYw== From: Benjamin Gaignard To: hverkuil@xs4all.nl, mchehab@kernel.org, tfiga@chromium.org, m.szyprowski@samsung.com, matt.ranostay@konsulko.com Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, kernel@collabora.com, Benjamin Gaignard , Paul Kocialkowski , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , linux-sunxi@lists.linux.dev Subject: [PATCH 27/55] media: sun6i-isp: Stop abusing of min_buffers_needed field Date: Mon, 27 Nov 2023 17:54:26 +0100 Message-Id: <20231127165454.166373-28-benjamin.gaignard@collabora.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231127165454.166373-1-benjamin.gaignard@collabora.com> References: <20231127165454.166373-1-benjamin.gaignard@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Mon, 27 Nov 2023 08:57:42 -0800 (PST) 'min_buffers_needed' is suppose to be used to indicate the number of buffers needed by DMA engine to start streaming. sun6i-isp driver doesn't use DMA engine and just want to specify the minimum number of buffers to allocate when calling VIDIOC_REQBUFS. That 'min_reqbufs_allocation' field purpose so use it. Signed-off-by: Benjamin Gaignard CC: Paul Kocialkowski CC: Chen-Yu Tsai CC: Jernej Skrabec CC: Samuel Holland CC: linux-sunxi@lists.linux.dev --- drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_capture.c | 2 +- drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_params.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_capture.c b/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_capture.c index 1595a9607775..f47f9946c19f 100644 --- a/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_capture.c +++ b/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_capture.c @@ -660,7 +660,7 @@ int sun6i_isp_capture_setup(struct sun6i_isp_device *isp_dev) queue->buf_struct_size = sizeof(struct sun6i_isp_buffer); queue->ops = &sun6i_isp_capture_queue_ops; queue->mem_ops = &vb2_dma_contig_memops; - queue->min_buffers_needed = 2; + queue->min_reqbufs_allocation = 2; queue->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC; queue->lock = &capture->lock; queue->dev = isp_dev->dev; diff --git a/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_params.c b/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_params.c index e28be895b486..259f6bfcb620 100644 --- a/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_params.c +++ b/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_params.c @@ -489,7 +489,7 @@ int sun6i_isp_params_setup(struct sun6i_isp_device *isp_dev) queue->buf_struct_size = sizeof(struct sun6i_isp_buffer); queue->ops = &sun6i_isp_params_queue_ops; queue->mem_ops = &vb2_vmalloc_memops; - queue->min_buffers_needed = 1; + queue->min_reqbufs_allocation = 1; queue->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC; queue->lock = ¶ms->lock; queue->dev = isp_dev->dev; -- 2.39.2