Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Date:   Mon, 27 Nov 2023 11:16:36 -0700
From:   Keith Busch <kbusch@kernel.org>
To:     "Jim.Lin" <jim.chihjung.lin@gmail.com>
Cc:     axboe@kernel.dk, hch@lst.de, sagi@grimberg.me,
        linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
        jim.lin@siliconmotion.com, cj.chen@siliconmotion.com,
        david.yeh@siliconmotion.com, hardaway.tseng@sk.com
Subject: Re: [PATCH] Merge tag: Fixed an issue where it takes more than 20
 mins for SK Hynix BC901 to switch to developer mode on Chromebook
Message-ID: <ZWTdBKLU32mEc70A@kbusch-mbp.dhcp.thefacebook.com>
References: <20231123100642.40923-1-jim.lin@siliconmotion.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231123100642.40923-1-jim.lin@siliconmotion.com>
Precedence: bulk

On Thu, Nov 23, 2023 at 06:06:42PM +0800, Jim.Lin wrote:
> SK Hynix BC901 drive write zero will cause Chromebook takes more than 20 mins to switch to developer mode
> "disable wrtie zero" can fix this issue and Sk Hynix has been verified.
> 
> Signed-off-by: Jim.Lin <jim.lin@siliconmotion.com>

For the changelog, let's abbreviate the subject to something like:

  "nvme-pci: disable write zeroes for SK Hynix BC901"

> @@ -3394,6 +3394,8 @@ static const struct pci_device_id nvme_id_table[] = {
>  		.driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, },
>  	{ PCI_DEVICE(0x1c5c, 0x174a),   /* SK Hynix P31 SSD */
>  		.driver_data = NVME_QUIRK_BOGUS_NID, },
> +	{ PCI_DEVICE(0x1c5c, 0x1D59),   /* SK Hynix BC901 */
> +		.driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, },

Could we get an "Ack" from the vendor?