Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Date:   Mon, 27 Nov 2023 14:24:41 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     "Zhang, Tina" <tina.zhang@intel.com>
Cc:     Joerg Roedel <joro@8bytes.org>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        David Woodhouse <dwmw2@infradead.org>,
        Lu Baolu <baolu.lu@linux.intel.com>,
        Will Deacon <will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>,
        "Tian, Kevin" <kevin.tian@intel.com>,
        Nicolin Chen <nicolinc@nvidia.com>,
        Michael Shavit <mshavit@google.com>,
        Vasant Hegde <vasant.hegde@amd.com>
Subject: Re: [PATCH v10 1/6] iommu: Change kconfig around IOMMU_SVA
Message-ID: <20231127182441.GA1170207@nvidia.com>
References: <20231027000525.1278806-1-tina.zhang@intel.com>
 <20231027000525.1278806-2-tina.zhang@intel.com>
 <ZTtixEgSkBI-TRro@8bytes.org>
 <MW5PR11MB5881E07803D25E3588FFABB789DCA@MW5PR11MB5881.namprd11.prod.outlook.com>
 <MW5PR11MB5881463F11D86198291EB52989DCA@MW5PR11MB5881.namprd11.prod.outlook.com>
 <20231027112013.GT3952@nvidia.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231027112013.GT3952@nvidia.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?IeTINm29GO1z2BTUPbsSKD7jkYJD1fghp3TZafctDqjJdcwioAgQu9tXU5cw?=
 =?us-ascii?Q?p55NTOz+CriwKpls4dkm636vVO2e0bU5SZVAZFe45gI/b6TlDNoqxWspRa5A?=
 =?us-ascii?Q?YkYkHNLJH4UkHdAPE3nEriT2SZ7haL2lKigFb0KAG86FMmx5lxpPHazhCHpI?=
 =?us-ascii?Q?IDvpAnlYZfHBUxB58bq57R1Of5lDueGv4IVZ6Qaun/iTxk6Gmqc+1Rn45hvA?=
 =?us-ascii?Q?s2UE25XY3Lh6PXUpHkvYRkR+sw023F8pmJE7cH2H7huSCShqHwz53olpsv3F?=
 =?us-ascii?Q?4x2y2K9VtcaYkLEGzCcbjVgbTowqtABNYdFaGu5VuL3oO950ObEjhM1ljAvw?=
 =?us-ascii?Q?LYq5/3g3+VH1HqZ5Xgqy8blfFHttgfc0Xz7JGEt1EkXiBe05KK9sVfrfVBCz?=
 =?us-ascii?Q?xgPScWPrezMnW8lajROZaqC6IIc4c9H/t8OMkdRbfuCozaieWz2cYHnB7O1a?=
 =?us-ascii?Q?ztGaoB7ZIbYWP5PkXHHwb9Ne2HCTpf3Gior2uGDIr6FfLpyri7hnZQ6myQf4?=
 =?us-ascii?Q?HAISYvKMT1lCi1QMb7Gp78RqnWTU29lUcGmuFR9VnLoHGcZHKCIFYZvRQQC+?=
 =?us-ascii?Q?a4sjnvneNKBa0RpYHmtZG0fz0HTZ8rRaQMbdY0w+yFwaM99ixqjdlJShQMv/?=
 =?us-ascii?Q?kGiDGjVdzvjvuygpwTGvLoyYlEOG31BLLko1YRv4SSdWUQBf+0cEMC6EchmN?=
 =?us-ascii?Q?mxzrs6TqxUJ3LvDhCwofHDPx4RIPzMB4RYGRqLWkkAhfoiGFuDxjMh5uzwcM?=
 =?us-ascii?Q?3wzR4qu2jHUCVWbf57Yac2msUPWNvibZRf9ZOxKGj+23JSm3WQ/pAVrmK2Pr?=
 =?us-ascii?Q?7apjQdy6yMr5dkQMZo5JKayttD4AFPJ17/g3TrnRfNl/1kXnpQZ+ktheL2Rj?=
 =?us-ascii?Q?bswSWqvSoBXf2rRW2pEfaCDW6CfWTp8dyqSC6FVUrHdA1EanYU2iYIQteGZZ?=
 =?us-ascii?Q?SOpO7axu9vuU08ZnNSwkiarccVODX2eJmXJW+QhthmeTl0noYIYL7twHxsef?=
 =?us-ascii?Q?O0UQxtLXOVgewIl5TJDiTXis9Jfafz0EqFQtDnSdE3FBhIaHkyLk13BldiOU?=
 =?us-ascii?Q?j7SsUXcAE/R+HbjhTKcM0ldDNMz/r9c9t8z6yF0pyMM41ecNMtHqzkTxq+e/?=
 =?us-ascii?Q?rxcVD8p9TbRE5Nm9+33oQ47pQi4cqJHkFV/4BIWjdmFrVghCb2NUtwse/tL0?=
 =?us-ascii?Q?PhyD85PqXawYoj/wUmFAmQLG5ezYPsh8Ize79d5dC3nnzPDhQO+hzxL4CjAG?=
 =?us-ascii?Q?tE+zTB6dlnnyuJLOUKNPKU5sgFW2bBETqIAV6wbf+hM2mqcQIJNgLqQmPXPl?=
 =?us-ascii?Q?u255meFOiJII8jfDSnoSkp3tCIy4LK7eGQ0aCzAWbtU2W9Rv5wh6jnDOVOIf?=
 =?us-ascii?Q?hLGfYpWvASaqDpPftUHXXWp5gsSJJ4nJA3+IjvQRIc7ZNroR2D/Ec42iIT8J?=
 =?us-ascii?Q?E7CLmoiKXk7syuLWORsyzxGj4SV25QKXueXdHkzE5pIScUg595NwIXr0UJ8K?=
 =?us-ascii?Q?eOtUSEL0F4SvhV/Su4fayTYesweBZDhRISCiIKlZlJ0rxEmxBWXfaLrgguOC?=
 =?us-ascii?Q?PzQ4nc3yuyMh/c154zs=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 83ec6a59-9fdb-4226-058f-08dbef762008
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Nov 2023 18:24:42.7094
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JE0cIE0N7YLik1qUc40gCguX4WD5GPxwMU4lA9j8icUus4vGL86cMyMdBL8dM5sl
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8331
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Mon, 27 Nov 2023 10:24:58 -0800 (PST)

On Fri, Oct 27, 2023 at 08:20:13AM -0300, Jason Gunthorpe wrote:
> On Fri, Oct 27, 2023 at 09:14:17AM +0000, Zhang, Tina wrote:
> > > > On Fri, Oct 27, 2023 at 08:05:20AM +0800, Tina Zhang wrote:
> > > > > From: Jason Gunthorpe <jgg@nvidia.com>
> > > > >
> > > > > Linus suggested that the kconfig here is confusing:
> > > >
> > > > While this patch looks decent to me, you forgot to Cc Linus on it. In
> > > > general, given that it touches a couple of core files, I'd like to
> > > > wait for some more people to have a look at it and not rushing anything in.
> > > Make sense. I'll CC Linus. Comments are welcome.
> 
> > Can we separate this patch? I'm thinking about CC more people for
> > review. At least, we need to CC all the reviewers of
> > https://lore.kernel.org/all/20230506133134.1492395-1-jacob.jun.pan@linux.intel.com/
> > to this patch. So, it seems more reasonable to separate this
> > patch. What do you think?
> 
> I think that makes sense, let's go ahead with the rest of the SVA
> series and we can do this next cycle. Bikeshedding config names isn't
> really critical.

So this didn't make it even without the config change :(

Can you please resend it again and CC the right please please. This
needs to go into this cycle for sure

Thanks
Jason