Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Message-ID: <95fc95c8-dac6-4137-a9cd-29f27da64e41@gmail.com>
Date:   Tue, 28 Nov 2023 00:23:54 +0530
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] driver : edac : Fix warning using plain integer as NULL
Content-Language: en-US
To:     Borislav Petkov <bp@alien8.de>
Cc:     tony.luck@intel.com, qiuxu.zhuo@intel.com, james.morse@arm.com,
        mchehab@kernel.org, rric@kernel.org, linux-edac@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        linux-kernel-mentees@lists.linuxfoundation.org
References: <20231109212157.1454726-1-singhabhinav9051571833@gmail.com>
 <20231127171435.GCZWTOe+DQSy4kkuKO@fat_crate.local>
 <dfb5b4cd-935c-445b-aaa7-bcce962a143d@gmail.com>
 <20231127183941.GGZWTibScFM4lgbqkG@fat_crate.local>
From:   Abhinav Singh <singhabhinav9051571833@gmail.com>
In-Reply-To: <20231127183941.GGZWTibScFM4lgbqkG@fat_crate.local>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/28/23 00:09, Borislav Petkov wrote:
> On Mon, Nov 27, 2023 at 11:53:02PM +0530, Abhinav Singh wrote:
>> Hello, thanks for reviewing this. As of now this is only a warning issue in
>> kernel. I saw this post by linus
>> https://www.spinics.net/lists/linux-sparse/msg10066.html and thought of
>> submitting a patch. Also a similar patch of mine got accepted
>> https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg2560740.html,
>> so thought about opening this one as well.
> 
> Lemme try to understand what you're saying: just because someone
> accepted a patch of yours, then others should not ask you to improve
> your commit message so that it explains *why* a change should be done.
> 
> How about you put the gist of what Linus is saying in your commit
> message? Don't you think it would be a much better commit message then?
> 
> Especially if it explains why, even if it is the case that 0 == NULL, we
> don't want those in the kernel.
> 
> Hmmm?
> 
Hello, my sincere apologies, I wrongly interpreted that you were asking 
for a reason in reply rather than in the commit message itself. Yeah I 
agree putting a reason in the commit message will make more sense. Just 
to be correct this time, I need to put a reason why this needs to be 
fixed, in the patch itself, right?

Thank You,
Abhinav Singh