Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
MIME-Version: 1.0
References: <20231121101331.22837-1-naresh.solanki@9elements.com>
 <ZV9MNdOCkIpLB+6Y@finisterre.sirena.org.uk> <CABqG17jRbqcw=QioyZTPFTidUDiPDgBFbm45vfvG2Sc5TOznvw@mail.gmail.com>
 <ZWSj4+Ag739Axe8O@finisterre.sirena.org.uk>
In-Reply-To: <ZWSj4+Ag739Axe8O@finisterre.sirena.org.uk>
From:   Naresh Solanki <naresh.solanki@9elements.com>
Date:   Tue, 28 Nov 2023 01:28:38 +0530
Message-ID: <CABqG17i0cFLoZdU==bkzveKem4wMwYz3eMVE2Y51BHsKEsUXsg@mail.gmail.com>
Subject: Re: [PATCH v2] regulator: event: Add regulator netlink event support
To:     Mark Brown <broonie@kernel.org>
Cc:     Liam Girdwood <lgirdwood@gmail.com>, linux-kernel@vger.kernel.org,
        Patrick Rudolph <patrick.rudolph@9elements.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Mark,


On Mon, 27 Nov 2023 at 19:45, Mark Brown <broonie@kernel.org> wrote:
>
> On Mon, Nov 27, 2023 at 04:07:45PM +0530, Naresh Solanki wrote:
> > On Thu, 23 Nov 2023 at 18:27, Mark Brown <broonie@kernel.org> wrote:
>
> > > I'm also not clear on where the 15 byte limit comes from.
>
> > I felt 15 characters would be sufficient for regulator names.
> > Would need your inputs to make sure here.
>
> It does feel like it might be a bit tight - perhaps double it?
Sure. Will change to 32.


Also there is a possibility of regulator name  duplication.
And below mechanism is already used in debugfs:

        const char *rname = rdev_get_name(rdev);
        char name[NAME_MAX];

        /* Avoid duplicate debugfs directory names */
        if (parent && rname == rdev->desc->name) {
                snprintf(name, sizeof(name), "%s-%s", dev_name(parent),
                         rname);
                rname = name;
        }

I need recommendations here.

Regards,
Naresh