Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
IronPort-PHdr: A9a23:FVs+aRzSEEqsdoLXCzMRngc9DxPP8539OgoTr50/hK0LK+Ko/o/pO
 wrU4vA+xFPKXICO8/tfkKKWqKHvX2Uc/IyM+G4Pap1CVhIJyI0WkgUsDdTDCBjTJ//xZCt8F
 8NHBxd+53/uCUFOA47lYkHK5Hi77DocABL6YAl8PPj0HofRp8+2zOu1vZbUZlYAiD+0e7gnN
 Byttk2RrpwPnIJ4I6Atyx3E6ndJYLFQwmVlZBqfyh39/cy3upVk9kxt
IronPort-Data: A9a23:ur43lalH5XwuRO5UGF5yJp3o5gyhJkRdPkR7XQ2eYbSJt1+Wr1Gzt
 xJOXzuGM6mKN2vyfdolPY3g9U8AuZSAyNZmSVY//nwzFltH+JHPbTi7wugcHM8zwunrFh8PA
 xA2M4GYRCwMZiaB4E/rav649SUUOZigHtLUEPTDNj16WThqQSIgjQMLs+Mii+aEu/Dha++2k
 Y20+5G31GONgWYuaTtNsf3b8nuDgdyr0N8mlg1mDRx0lAe2e0k9VPo3Oay3Jn3kdYhYdsbSq
 zHrlezREsvxpn/BO/v9+lrJWhRiro36YWBivkFrt52K2XCukMCdPpETb5LwYW8P49mAcksYJ
 N9l7fRcQi9xVkHAdXh0vxRwS0lD0aN6FLDvHXO7ssat9xT9XFj+4rItXRAJLaAZ07MiaY1O3
 aRwxDEldBuPgae9x6i2D7UqjcU4J86tN4Qa0p1i5WiGVrB9HtaSGOOTuIIwMDQY3qiiGd7db
 tAFaD5mbzzLYgZEPREcD5dWcOKA3yWhI20E9grNzUYxy3WD6wFYl6KyCp3cUdvNa+FPvEnA9
 22TqgwVBTlBaYTAkmDamp62vcfLnCXmSMcRGae++/pCnlKe3CoQBQcQWF/9puO24ma6WtRCO
 wkP8TEvhbY9+VbtTdTnWRC85nmesXYht8F4CeY27kSGzbDZplrfDWkfRTkHY9sj3CMredA0/
 mOCm9DjOwQ2i5K2W1PatebFkiOfOAFAeAfuehQ4ZQcC5tDipqQ6gRTOUstvHcaJYjvdR2mYL
 9ei8nBWulkDsfPnwZlX6rwuvt5BjoLCQghw7QLNUyf5qAh4f4WiIYev7DA3DMqszq7HEjFtX
 1Bdx6ByCdzi67nRzERhp81RRdmUCw6tamG0vLKWN8BJG86R03CiZ5tMxzp1OV1kNM0JERewP
 xeK4FsAtMANYyb6BUOSX25XI5pzpUQHPYq8Ps04kvIXOvCdiSfepX4xOxbIt4wTuBJ9wf9X1
 WinnTaEVitCVv89k1Jats8W0KQgwWgl1HjPSJXghxWh2vz2WZJmYeltDbd6VchgtPnsiFyMq
 753bpLWoz0BC7eWSneMruYuwaUicCJT6Wbe8ZIHL4Zu42NORQkcNhMm6eh7KtY1xfsPyL+gE
 7PUchYw9WcTTEbvcG2iQntic7joG514qBoG0eYEZD5EB1BLjV6T0Zoi
IronPort-HdrOrdr: A9a23:z/ZKIKAiuzrUI6LlHejpsseALOsnbusQ8zAXPh9KOH9om52j9/
 xGws576fatskdhZJhBo7y90KnpewKkyXcH2/hgAV7EZniphILIFvAs0WKG+UyDJ8SQzJ8h6U
 4NSdkYNDS0NykFsS+Y2nj4Lz9D+qj6zEnAv463pBkdKHAPV0gj1XYHNu/xKDwPeOAyP+tCKH
 Pq3Ls9m9PPQwVwUu2LQlM+c6zoodrNmJj6YRgAKSIGxWC15w+A2frRKTTd+g0RfQ9u7N4ZnF
 QtlTaX2oyT99WAjjPM3W7a6Jpb3PH7zMFYOcCKgs8Jbh3xlweBfu1aKv6/lQFwhNvqxEchkd
 HKrRtlFd908Wntcma8pgao8xX80Qwp92TpxTaj8DneSI3CNXcH4vh69MVkmyjimgwdVRZHof
 t2Nleixt5q5NX77XzADpbzJkpXfwGP0AkfeKYo/g5iuM0lGf9sRUh1xjIJLH/GdxiKsrwPAa
 1gCtrR6+1Rdk7fZ3fFvnN3yNjpRXgrGAyaK3Jy8PB9/gIm1EyR9XFoj/A3jzMF7tYwWpNE7+
 PLPuBhk6xPVNYfaeZ4CP0aScW6B2TRSVaUWVjibWjPBeUCITbAupT36LI66KWjf4EJ1oI7nN
 DEXElDvWA/dkryAYmF3YFN8BrKXGKhNA6dh/129tx8oPnxVbDrOSqMRBQnlNahuewWBonBV/
 O6KPttcrbexKvVaPB0NiHFKu5vwCMlIbgoU/4AKiaznv4=
From:   "Karan Tilak Kumar (kartilak)" <kartilak@cisco.com>
To:     "Martin K. Petersen" <martin.petersen@oracle.com>
CC:     "Sesidhar Baddela (sebaddel)" <sebaddel@cisco.com>,
        "Arulprabhu Ponnusamy (arulponn)" <arulponn@cisco.com>,
        "Dhanraj Jhawar (djhawar)" <djhawar@cisco.com>,
        "Gian Carlo Boffa (gcboffa)" <gcboffa@cisco.com>,
        "Masa Kai (mkai2)" <mkai2@cisco.com>,
        "Satish Kharat (satishkh)" <satishkh@cisco.com>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v3 02/13] scsi: fnic: Add and use fnic number
Thread-Topic: [PATCH v3 02/13] scsi: fnic: Add and use fnic number
Thread-Index: AQHaF0p6uXPGn2t9xE+tpp//qiyWn7CKTRQzgARhDUA=
Date:   Mon, 27 Nov 2023 20:17:53 +0000
Message-ID: <SJ0PR11MB58960721DF0510FC1CED01F8C3BDA@SJ0PR11MB5896.namprd11.prod.outlook.com>
References: <20231114223221.633719-1-kartilak@cisco.com>
 <yq1y1emtzok.fsf@ca-mkp.ca.oracle.com>
In-Reply-To: <yq1y1emtzok.fsf@ca-mkp.ca.oracle.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?WCBhNHAWNCyUJ+tP4wSWAR3QB+4w+uv3ZL9iNmHZ4nsyryIY3o/GssqI19aW?=
 =?us-ascii?Q?Le60u/9f5boViU5kcJc2ziresrMIV8sqK6tQfxxa8IiqFJh9fDMMTNsy3i66?=
 =?us-ascii?Q?uYtb2gD0Z+KvogEUVJ5cx1FzcnDvBdunwUK9J8lcGY+Po99Y9OhcVNPofGHz?=
 =?us-ascii?Q?PHtBq+reNBQtz80SCxaGUO0ocgapQOry1kFTHBcUkg97ZPvw/xVLo8HeoGw9?=
 =?us-ascii?Q?QyPxsgUiyTwLuQd6Uemv9WC5Q8DRgszzeT12gXXTdkl71dcJCp3rhtNaYFqx?=
 =?us-ascii?Q?O7KdgzYROR7cL1uTvtEv1NVRGZCdt8cVjuzyWB5LFtuCirj/7FrAW+5NwU8J?=
 =?us-ascii?Q?zK9Frwutg655ccfpwnVcZZit/YKVSSz7HtPbXF3Vhl8sZe23ety/27N3BHN6?=
 =?us-ascii?Q?S57s1QyoguBZEzuQxU6GDMxMrTh3MLqeIoVCdSVWpiSizDR8AZpR4ARmJ4nh?=
 =?us-ascii?Q?BGP3WW9nmyPc2Rw7QMNhtY55Et/ruyLZPxH97HjZD/JPyLdo8AKeal9u5Bw7?=
 =?us-ascii?Q?iRBfNJp0dblXnj2Z64ifu8c+Jg0Pd9WY4KrVeeas/AZjlJr9zfO4EYODsEPV?=
 =?us-ascii?Q?63gEX3MWAoICjqhhDrrEHVI0hyJdF3lA1aV/Z0rICiTJi/GSj5jrYkVOTMSU?=
 =?us-ascii?Q?UxpJzip13LNAsSuU/nvxvyc8CTisPuVU6sjD5YF7gIc2CxBFcuw0xxy8RERs?=
 =?us-ascii?Q?i4oYJ3i06kCfGNXCoSBn8UDw7Rp9AG1r1ubFqT9c3fBwCtFWRpL71zwx7ipz?=
 =?us-ascii?Q?7nEgC7AlY7dHpuHf1GKpnofJAtZg6tkwgFpcydRQB9G5E4ni3X4AITrin4CM?=
 =?us-ascii?Q?9KYoqSyAvI7PFzCED5fsgfc52q5+rgqQADpSrLaPDyT5F309hprEPoiDPn1t?=
 =?us-ascii?Q?nuj/crpm4rNHiaFArdYaTq78+cyQqaj2ESrxUoR3mzZobFjH731OWdEVo7Uw?=
 =?us-ascii?Q?TEhCfNCWM/EC1WR+KlvWNGoHTd30Ylu+FY6m5Gr4CoHDYaEHDOXtyQwpUqoi?=
 =?us-ascii?Q?bqoc7mT+Yljv309fZbc2Y/ZyHU9Dw+h4V4/47/LohGHfGmDdJ6BAMw6hnnge?=
 =?us-ascii?Q?7TjvtNKLEGal+jnZgcpfSx/hE83hgw+b/wvSfd2iDzPWRqqFkQTDG8tDltIE?=
 =?us-ascii?Q?MTj6+ByLCjR2uZ1dgQxY5E3NIopw2zBARi2niaGu+mw2Ppi0W6HgkFjvHHUx?=
 =?us-ascii?Q?3bXBDAKdgnv03wJXp/vYxN8ka+RWesrlfFZDh18WYnRaK8brCSO8gZfzSrmL?=
 =?us-ascii?Q?SPC8ANFxA091aMGwkr7JcYextyx5BaQ/mu86KOhwrp6YhgXFZ2Makv9Y2sHh?=
 =?us-ascii?Q?XBsvPJmSla7Dbfg6CY1JgICUfSRyvXJ5wW6UrO3Nl2JWUidS4fguB+/QqkNe?=
 =?us-ascii?Q?SVEe1i0b2Ck3IG8MPp16uyJ8xHNc+wAcke0eAefqqti/WpmOU+zDG3nUsC2u?=
 =?us-ascii?Q?D+Bn2o3Jv+sUNySJXTY2qJBxUbjx/EktI5+oxjfC6O4XY74p1H56XqTODjXJ?=
 =?us-ascii?Q?VFIymZCAPSb7F2JaQqPIsJKRSGSBHi46feEFl411P76A720JAwQE/jwQ5tPb?=
 =?us-ascii?Q?wMdPUYC1JtjWTbWC6OlsPSs8Xgww5eSYhCp120KvOo3c0eYEQJjJ/ZZoPpLy?=
 =?us-ascii?Q?h+9SHpX3RqClCDRerCl8VZ8=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: cisco.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5896.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c9a9d9de-29fb-4720-c5a4-08dbef85ef81
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Nov 2023 20:17:53.0662
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: YnKOn1SvthNabVIsXsgg0GKLLkjWDH8ejAmevO0EdWFMhUWM+SlSBkKdleIxUMaqeTrmapm4nj0zmI2MlJe8Nw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4876
X-Outbound-SMTP-Client: 173.37.147.229, alln-opgw-1.cisco.com
X-Outbound-Node: rcdn-core-4.cisco.com
X-Spam-Status: No, score=-8.4 required=5.0 tests=DKIMWL_WL_HIGH,DKIMWL_WL_MED,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,
	USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 27 Nov 2023 12:18:12 -0800 (PST)

On Friday, November 24, 2023 5:22 PM, Martin K. Petersen <martin.petersen@o=
racle.com> wrote:
>
>
> Hi Karan,
>
> > Add fnic_num in fnic.h to identify fnic in a multi-fnic environment.
> > Increment and set the fnic number during driver load in fnic_probe.
> > Replace the host number with fnic number in debugfs.
>
> I agree with Hannes. Everything else in the stack will be using the host =
number. Your change will make it harder to correlate a SCSI error message t=
o an fnic driver instance.
>
> If you absolutely need an instance number I suggest you add it as an orth=
ogonal value instead replacing the host. Also, we typically use an idr for =
enumerating things like this.
>

Thanks for your review and comments, Martin.

I understand the issue. I'll take your suggestion about adding the fnic ins=
tance number as an orthogonal value instead of replacing the host number.
Could you please help me understand what is meant by "idr"? How can I use i=
t?

Regards,
Karan