Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Message-ID: <b760bf11-c8a7-4f9f-b2c5-2e35e84e46d2@oracle.com>
Date:   Mon, 27 Nov 2023 15:26:38 -0600
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] scsi: be2iscsi: fix a memleak in beiscsi_init_wrb_handle
Content-Language: en-US
To:     Dinghao Liu <dinghao.liu@zju.edu.cn>
Cc:     Ketan Mukadam <ketan.mukadam@broadcom.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        John Soni Jose <sony.john-n@emulex.com>,
        Jayamohan Kallickal <jayamohank@gmail.com>,
        James Bottomley <JBottomley@Parallels.com>,
        Mike Christie <michaelc@cs.wisc.edu>,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20231123081941.24854-1-dinghao.liu@zju.edu.cn>
From:   Mike Christie <michael.christie@oracle.com>
In-Reply-To: <20231123081941.24854-1-dinghao.liu@zju.edu.cn>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QS9iMDJrRlZkZnVwelRHUGs5RjcvRlFzMnRTTWhORHNhT0VTSVB4UDU5SmE4?=
 =?utf-8?B?R0VkMk5yclY5M1pQbVQyclMyWkxGOUREa01PbDZLOFE5MU1rM2ttV244QkU3?=
 =?utf-8?B?eGUzOFJLNnhJN21KMU9JdG80WDN4MjNNMXRCSUVwQnVRdE42VmQzQWNQWndB?=
 =?utf-8?B?aUN3WmR4WnVFU0pIbDk3ZEc4VGdlUVkyUjJkZy9PRncrN3g0a0VHM1MzcU5H?=
 =?utf-8?B?V0t4bnhWcjNNd1lBZzBmM0dCcFUxaXR6UG5VNmhsQnZRRFBiS3JqdC9VY2lv?=
 =?utf-8?B?eVl3aHR2RndkR1B5ejVudXpNT2ZlVi9VWWxERmlKbExqYUtBOEhjTGhJMTl4?=
 =?utf-8?B?bUQzT2szY2JiMk93TkVMY2VPNktoeU9vQ0R5K21MZE5GcDZ2Wi9TaE00SXNH?=
 =?utf-8?B?NTJ4cWZ6ZXJSc0ZUYVRMMjM2ZnZaWEhDUmdQMEVDck5NL2dDVVJGQU96M3VR?=
 =?utf-8?B?d0pvOUgwTGo4Tlc1Rm1EZDFVRFFUWE5meXJYdkdZRG5WWDJTVlFJa05SK01a?=
 =?utf-8?B?VUlYYjJYL2RFenJwVkRXOVRhMVh4TnZyZmplZ2NaN2o3eDAyQkZwUXpaMTFz?=
 =?utf-8?B?N3BuSUlYTXl5TXZVWXdHcm1ZdlQ1WkZsbWtIV0xsV2xoS3VLM0tzM1h6N0Rv?=
 =?utf-8?B?RStvNFJ5Z1RLd1dNKzc3dDhVUEo5ZVFNSXJaUFQ2cm5GZytYYW5lRTVuQjF4?=
 =?utf-8?B?R3VqS3NhbTJKeDlza0NhUFhzMHVrclNkWVRXaWhqdUtieHY0ZjZoU3JaYklS?=
 =?utf-8?B?cWdORGUxNzRHbVpFekxYZENWd0IxTGFGR1V1K21FRzJnZE50VldiZDgvaXlT?=
 =?utf-8?B?RTJmQWxmaVA3ZmdJSUJqekpSY2lsbnpGMSszRjl4OEhvUlhyRUt0bEpYSkF5?=
 =?utf-8?B?WDlueEVHODZUWFpPcFczZDRaQUMrUk9USkNPQTIySG5KWk43SlcxbGFGcDZx?=
 =?utf-8?B?eWFMT0FQM0VpMTZLOEhKUGJsb1JjNm5FUjN3OCtyZHkzOWFnblQveFFaTVRk?=
 =?utf-8?B?ajRQSXFJT0Nua2h2VGtTeEdyR3Nod1ZEUWs1L0pqaU05TS8zd1RIclR3emRL?=
 =?utf-8?B?MHRra0NkenBpTXlDUkR2N1R6a2VEUXkxS3p4UjJ4Q1hIeEd2TXBWZG90WTBH?=
 =?utf-8?B?QlhMUmU5TlhyM2swNThDZWRoWmp1VFFIWmFPOXlSWGNUMUJQM2xKM2N1Qzla?=
 =?utf-8?B?T3VDZ1YvenlETXJ1TWM2WWJUREJTM0psNnNuUTd4WXpWTGVCRS9QVWJmNnYy?=
 =?utf-8?B?bDB2MTg0K3hxN3FFM1hYZVpjV1l2UGZPOWRtWTdXeVV1WitJa2wrU3pzdUVz?=
 =?utf-8?B?eXlhN1FmTHRISjVpMlhOU2VzNGNuMDN3SzZHVFp5NVNSOFUzUHFxWi9GWnZ2?=
 =?utf-8?B?blFYTkNiQ0ZXaUUvZlZZVStIM1RLUW5hWmsxb3E4aEs1WU96b0R5RmtSNHhv?=
 =?utf-8?B?TnpHZDFwUXhlQkFmUGltdzZzQXZyc2Zzb09lOTJSeXU2VjdZSFFYSTA1SG1O?=
 =?utf-8?B?bDNlVG5ndVBIUDhDeUM0R0VPUTFCWWdzUEs3TkZKTm1BR2IzRkFvY1M5WGJ0?=
 =?utf-8?B?aDF1VlcyMHZUTGdaT0l2USs2QUJHSXlPOXJVRjdGeWc5VC9GTkhKQks4L01P?=
 =?utf-8?B?aWxsZVM2Zy9ETXdZbGIrbFRlMUxDcnJPcDNQeEpOSm5scGZwR2pUMFFLNHRC?=
 =?utf-8?B?TmxlRWIxalBLejc4ZkJqam5iQ3dyRlRFVVAwNldXUXV0NnlFb3NtdFR2S0pK?=
 =?utf-8?B?NjZSVlZGZG95cFhaanpTb3RaUkh6UCt0ZDBIRUwyeGZmSDFGV2tDVW9sa21t?=
 =?utf-8?B?cksyb21yRFhudjN3aEFpYUQrd0FOaXVpWmg5R2FTL2JBdlpLbHhwbm90ZjZs?=
 =?utf-8?B?clFOU2FxUEM1NlRSajREM3liYUtWSmg2MUFJUXBBTGxXOUg0MlVZaXoxZGg1?=
 =?utf-8?B?WVdsc1BZYjd3Vk0wV3JNRjNCRzdrMXZXT2RMU1E2cDJQVVdjREFia1NFUGI2?=
 =?utf-8?B?TFF0TE1kbGNLTkM2U2dhN1pTckd3UERXbGpNRzczN2gyT2RESm9YVmp0OUhn?=
 =?utf-8?B?dHU3THJPU3ptcWtnbVpDUllVcWVEem0xZGorMU5oQ21aV0ZEdkZpdEhTNW5O?=
 =?utf-8?B?dnFla0t0R1JJL3lQendlKzJob09jUWxYbUhSbm00K2FteVN2eHh1Vm5GdWti?=
 =?utf-8?B?RXc9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?NzJSN3VGQ0I1bnQ4VFZDaFJodTFtbnl5WG1xNVkzeHhvcGc0OEhQTjEyNlNk?=
 =?utf-8?B?bHhqaTRVRlBRVVF0SEJqQm9vbVNMZU03aktDdEp4bGtsckxiRW9TdzhTREN6?=
 =?utf-8?B?eG9mRmc4K1NBYnM4RVBhMFE0bXh2V1BZWTFtTHRFbGdzN0NldFdnSHdkc1VZ?=
 =?utf-8?B?TnlGbU5LTzFndkJSUnVDc0RaS0hock44ZkJSSnpFdWpKNFZZZkRlZ2t1Qy9H?=
 =?utf-8?B?Y09BVG02L3RlWW55T3J3WmJycjQwNk5EY2MzU3YxRzFPVFd5b2N5M2NwTHhF?=
 =?utf-8?B?MklCVzlBeSthaTdiTEZ3SGlqVGNLQnNIZ0hXM2FwNGZYdm5OYmIyQlhzV1cv?=
 =?utf-8?B?UVFUS0JHTHNxR3J5M3NXRHh2Vi9tendCREhaamIzcFYvekQydWI2RHVZTUE0?=
 =?utf-8?B?QXIwZnF4ZlhPOWhHOTgrSWQyM2FhUGxKclF6VU9HaS92RmprUFhLeG5DNE5C?=
 =?utf-8?B?MVliQi9nQVIyb1hGQXNSUGtSb2d0aEhpUTIrdlVTc0grc3RjSThwTm8vaVVX?=
 =?utf-8?B?YnpUaFlsRlR4SFBSMlZuSzNZRHZLVFJ6bUtybXdSUHUxajNsTFBRb3lEL2ZH?=
 =?utf-8?B?Rnp2M013czdnZG5aeWJXL0kyNGgySGlpOWxxZGtVOHNuMjFSbjZ5eFU4blVk?=
 =?utf-8?B?bEZWVkgyVFZvb3VwSDN1Y2lhb3FHWXNpOEtNTEZTZDFQbnI4K3hiSUI2Wm1s?=
 =?utf-8?B?N3lsbmc5a0p0RHBDa0w3NDBTNTVqTzJVVlE2VFZndUlhSVJFejRDTTZmdFhx?=
 =?utf-8?B?a1BjaWtFbWNFNFhhZkphTDNqRDVtZFJodFd3T2FCSlhIMFcySkxhVDBURk1L?=
 =?utf-8?B?bUU0NFUzYXMrdWF2UzZQamJ5U25nQUt6Q1kwUzJ0YWJ2UC8rZjdlcjg4Z0hB?=
 =?utf-8?B?RmhEdjZQME9xQVROTmZtMlhMVmFNNk55WlhyNnU2NktuOG5CdHZEMlVHUDR1?=
 =?utf-8?B?Mkltd3piNkhRT0dvZlg4bXlHYzR4TGg0L2psM1N0Sk1seGpFeUtEUzR0NW1J?=
 =?utf-8?B?NnU0azJnRlRFeEMwWXlrbTBwWktaYjZMQlJsQUlIWU1nVE5yUWN4ZEtRbnZ6?=
 =?utf-8?B?MjZDYVcvNE9aaTBOS3FvQWVUamxHWTgvWE9JNWFvcVp1TlpYZXFGTCtEOGxk?=
 =?utf-8?B?U1VhdWtVazdsUjZlMXlyRDluVjIrZThtWDJwMzVtWlo0VTh6V3pRVjlYOXgw?=
 =?utf-8?B?eWwzUXVvM1ZKZWlZVURJakZ2N0tHMFdURkRWMmZpV2Q0OHdUMkw3MmkxVGlx?=
 =?utf-8?B?QXd4ZWNTbFVmRDVrNVJHQ05FV0ZBK08vTG5XMU4rRkEwV1NtdGNueW5XbWlu?=
 =?utf-8?Q?KfoLUjUQePhoU=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3fe88fc8-7b63-49b7-def3-08dbef8f8b89
X-MS-Exchange-CrossTenant-AuthSource: CY8PR10MB7243.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Nov 2023 21:26:40.5497
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pua/l0VgC8qMnTe9rb5oGjmjmkoLuSxe3jY/i9t74KJNyuq8wHfhfIFAgNpkGCJFbKqXauhqqpNXFs8DywVtBzgoHUOQ1uJ459O+QVe1aig=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5074
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-11-27_19,2023-11-27_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 phishscore=0 mlxscore=0
 malwarescore=0 adultscore=0 suspectscore=0 spamscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000
 definitions=main-2311270149
X-Proofpoint-ORIG-GUID: LyHbRZmStpwrO6zn2TvSzH1gVWrSDRjL
X-Proofpoint-GUID: LyHbRZmStpwrO6zn2TvSzH1gVWrSDRjL
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Mon, 27 Nov 2023 13:33:06 -0800 (PST)

On 11/23/23 2:19 AM, Dinghao Liu wrote:
> When an error occurs in the for loop of beiscsi_init_wrb_handle(),
> we should free phwi_ctxt->be_wrbq before returning an error code
> to prevent potential memleak.
> 
> Fixes: a7909b396ba7 ("[SCSI] be2iscsi: Fix dynamic CID allocation Mechanism in driver")
> Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
> ---
>  drivers/scsi/be2iscsi/be_main.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c
> index e48f14ad6dfd..06acb5ff609e 100644
> --- a/drivers/scsi/be2iscsi/be_main.c
> +++ b/drivers/scsi/be2iscsi/be_main.c
> @@ -2710,6 +2710,7 @@ static int beiscsi_init_wrb_handle(struct beiscsi_hba *phba)
>  		kfree(pwrb_context->pwrb_handle_base);
>  		kfree(pwrb_context->pwrb_handle_basestd);
>  	}
> +	kfree(phwi_ctxt->be_wrbq);
>  	return -ENOMEM;
>  }
>  

Reviewed-by: Mike Christie <michael.christie@oracle.com>