Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp3421369rdh; Mon, 27 Nov 2023 14:01:25 -0800 (PST) X-Google-Smtp-Source: AGHT+IFcN8efc8Ozj4NfVTgtFO5FBIXefU0OIOU0w0s4REzsbcZxGZ5R3sNHlPdi530DvezTnS6+ X-Received: by 2002:a05:6870:d252:b0:1f9:f57e:cc99 with SMTP id h18-20020a056870d25200b001f9f57ecc99mr18096346oac.12.1701122484998; Mon, 27 Nov 2023 14:01:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701122484; cv=none; d=google.com; s=arc-20160816; b=Joz17rgzcTspEk8deDnMl0t2PqyZ9sjn0qoLnjqUzL5Hp78jiMJ6+lEL7TycHvZohm CIWMU+jBevntlPPAIixoNda2jvw5cL9nF6l6bYdQ9sPHyMkND7KQyRQ40d1Tl7E1OvCK o2RdVtphMusB0N5f5budcEIZCJ2nWx2uc0+xuiV3n21EZB4r8A1qeqW+aoX2rbcHfAyz yTz2C22yJXf2Lmj0Ns6PDtb8bJ8lzqluUyNzgSj9UJ/mpoZMOu3VIFSl9/Cv9FQzm5de TMZigsqZzbpAKRmc6TFGZxFJqB5yn1FAn3Xiqw4oy/f7kCUCPFo6PTnwycKj2aHBgGqV zVaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=ddB+joJVyJkVMZQ5uEvlccygFHcTTPHg0SEvp7DA/fs=; fh=+v6iOBhBPepiTm5jfh5hb/DbZOKRJ3o62f2r0DhfAo4=; b=wt14CiIc+q4W6+sZ9Hk8HMz8KL40y+KftvaDiHteF9XNZD4ROUAnLOi/cE7uN9cFyc obsJbimzU5aBQuLSiCToc0iD3CkGFcyedZkyXdfeagk2jQBNt62taYOnrlUSDsj/GDNU 8JvFNy+smg/sBy/W36ze9Xq05CMKSlJMGCTvoyl96XhpCueb9GoL2bKRqFE8z51C8YVI DtjAp737gRmEGXGg7R5KrVyTMpu1/SUdIxxUnBH/LemuX47ZMAl1xDLQQnsEL8E/vAnG EVd704Y2eW06kefvVGicnGmWRZ+9TfR7Ss2BNDD5VFG//IAK6lOlh1SeUtPyABtHfXYC EL0Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=DuTC72HS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id g9-20020a056870214900b001f5ae4e06b4si4223007oae.140.2023.11.27.14.01.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Nov 2023 14:01:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=DuTC72HS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 189898078E3A; Mon, 27 Nov 2023 14:00:17 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233172AbjK0WAE (ORCPT + 99 others); Mon, 27 Nov 2023 17:00:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231437AbjK0WAC (ORCPT ); Mon, 27 Nov 2023 17:00:02 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7AC341A1 for ; Mon, 27 Nov 2023 14:00:09 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D392AC433C8; Mon, 27 Nov 2023 22:00:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701122409; bh=FFALWKc/ZBfqGfDdhBIDp6jyuxWJOXHiknj8f6bxGxw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DuTC72HSX5/ni6VtI6ee1ReyY5DM23etTVmz+W2dS1CZNxpRduOoSrK+NKhE1t792 oN+W8RptKeRvwXtbiTZR/253B0TKUwphknKx2yOWKz7gRqJ6sCg0MgfkGnfJYhrFVw cv2AGseVPutOzVdNMRzH+K5rmJ2fLL8LhiVFt2CWRvm4ezgw9dLW7KWDZaZmiqx1WL DPTgywCoQW2OpU83HWGVdP4AWY1nKjDGkUKjCeZPuL7GPW0ZvziMmNN2504RSszbh8 OrUdNYc2z/eLFoez7Ct34ShdGO5QpwiAY7nC/imxdxohqFcqLNikeQEYhsH/oTbl+3 W8O3HvqFg5Q5A== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 3B4BF40094; Mon, 27 Nov 2023 19:00:06 -0300 (-03) Date: Mon, 27 Nov 2023 19:00:06 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , Nick Terrell , Kan Liang , Andi Kleen , Kajol Jain , Athira Rajeev , Huacai Chen , Masami Hiramatsu , Vincent Whitchurch , "Steinar H. Gunderson" , Liam Howlett , Miguel Ojeda , Colin Ian King , Dmitrii Dolgov <9erthalion6@gmail.com>, Yang Jihong , Ming Wang , James Clark , K Prateek Nayak , Sean Christopherson , Leo Yan , Ravi Bangoria , German Gomez , Changbin Du , Paolo Bonzini , Li Dong , Sandipan Das , liuwenyu , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Subject: Re: [PATCH v4 04/53] perf mmap: Lazily initialize zstd streams Message-ID: References: <20231102175735.2272696-1-irogers@google.com> <20231102175735.2272696-5-irogers@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231102175735.2272696-5-irogers@google.com> X-Url: http://acmel.wordpress.com X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Mon, 27 Nov 2023 14:00:18 -0800 (PST) Em Thu, Nov 02, 2023 at 10:56:46AM -0700, Ian Rogers escreveu: > Zstd streams create dictionaries that can require significant RAM, > especially when there is one per-CPU. Tools like perf record won't use > the streams without the -z option, and so the creation of the streams > is pure overhead. Switch to creating the streams on first use. > > Signed-off-by: Ian Rogers Thanks, applied to perf-tools-next. - Arnaldo