Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Message-ID: <94429ea4-c6a1-4437-8642-3a24930c7ad7@linuxfoundation.org>
Date:   Mon, 27 Nov 2023 15:12:57 -0700
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2] tools cpupower bench: Override CFLAGS assignments
Content-Language: en-US
To:     Stanley Chan <schan@cloudflare.com>, linux-pm@vger.kernel.org
Cc:     kernel-team <kernel-team@cloudflare.com>,
        Thomas Renninger <trenn@suse.com>,
        Shuah Khan <shuah@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
        linux-kernel@vger.kernel.org,
        Shuah Khan <skhan@linuxfoundation.org>
References: <20231127212049.455008-1-schan@cloudflare.com>
From:   Shuah Khan <skhan@linuxfoundation.org>
In-Reply-To: <20231127212049.455008-1-schan@cloudflare.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/27/23 14:20, Stanley Chan wrote:
> Allow user to specify outside CFLAGS values as make argument
> 
> Corrects an issue where CFLAGS is passed as a make argument for
> cpupower, but bench's makefile does not inherit and append to them.
> 
> Fixes: dbc4ca339c8d ("tools cpupower: Override CFLAGS assignments")

There is no need for this Fixes tag since this patch doesn't
fix the problem introduced by dbc4ca339c8d

This patch fixes the problem in bench/Makefile like dbc4ca339c8d
did in cpupower/Makefile.

In this case Fixes tag is incorrect. I removed the Fixes tag
and applied it to

https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux.git/log/?h=cpupower

thanks,
-- Shuah