Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
MIME-Version: 1.0
References: <20231127193703.1980089-2-nphamcs@gmail.com> <20231127224650.2636224-1-nphamcs@gmail.com>
In-Reply-To: <20231127224650.2636224-1-nphamcs@gmail.com>
From:   Nhat Pham <nphamcs@gmail.com>
Date:   Mon, 27 Nov 2023 15:40:57 -0800
Message-ID: <CAKEwX=Pi4xMmZB2S-vrYDWdPvofGKF_Y+U80Vs__p9Hd57-A6Q@mail.gmail.com>
Subject: Re: [PATCH v6 1/6] list_lru: allows explicit memcg and NUMA node
 selection (fix)
To:     akpm@linux-foundation.org
Cc:     hannes@cmpxchg.org, cerasuolodomenico@gmail.com,
        yosryahmed@google.com, sjenning@redhat.com, ddstreet@ieee.org,
        vitaly.wool@konsulko.com, mhocko@kernel.org,
        roman.gushchin@linux.dev, shakeelb@google.com,
        muchun.song@linux.dev, chrisl@kernel.org, linux-mm@kvack.org,
        kernel-team@meta.com, linux-kernel@vger.kernel.org,
        cgroups@vger.kernel.org, linux-doc@vger.kernel.org,
        linux-kselftest@vger.kernel.org, shuah@kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Actually, please ignore this fixlet. I will send a v7 instead to
prevent further confusion.

On Mon, Nov 27, 2023 at 2:46=E2=80=AFPM Nhat Pham <nphamcs@gmail.com> wrote=
:
>
> The original patch missed a list_lru_del() -> list_lru_del_obj()
> conversion. This patch fixed that.
>
> Signed-off-by: Nhat Pham <nphamcs@gmail.com>
> ---
>  drivers/android/binder_alloc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/android/binder_alloc.c b/drivers/android/binder_allo=
c.c
> index e80669d4e037..f69d30c9f50f 100644
> --- a/drivers/android/binder_alloc.c
> +++ b/drivers/android/binder_alloc.c
> @@ -234,7 +234,7 @@ static int binder_update_page_range(struct binder_all=
oc *alloc, int allocate,
>                 if (page->page_ptr) {
>                         trace_binder_alloc_lru_start(alloc, index);
>
> -                       on_lru =3D list_lru_del(&binder_alloc_lru, &page-=
>lru);
> +                       on_lru =3D list_lru_del_obj(&binder_alloc_lru, &p=
age->lru);
>                         WARN_ON(!on_lru);
>
>                         trace_binder_alloc_lru_end(alloc, index);
> --
> 2.34.1