Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp3507343rdh; Mon, 27 Nov 2023 16:35:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IGdmI8DhhzKOGPp76vBXldgXa3VZABDc5k6o3UGiP4q76f9CK+Nw6PPw8PBLCsImlTsM8/a X-Received: by 2002:a05:6a20:4418:b0:18b:37b4:cb6b with SMTP id ce24-20020a056a20441800b0018b37b4cb6bmr13861925pzb.27.1701131703270; Mon, 27 Nov 2023 16:35:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701131703; cv=none; d=google.com; s=arc-20160816; b=ly7jt7AD/ysdVXhr+mZ4dLa9uquhUbGZZM5N6pVHvkTw2UGG+I6Sc3rB/iadNuSibo NWTkwjHdtCaHlKad6RFnI8sUD2c7/bgVEgxvDcx6OHKqijUAfC9U8WzCCORrBTg0NX5N 50GZ8OELoHxLRr3fFl93cwEDU9znf3YglMM8cb3Hvfu70UQ7gnKHzm/7BiV1jyD76aJX dy7sCM0fz0lb/dETlvhQxyb5k8J5RgcFSotxaWc6o0zlD/aymGeH2mAa/64uFSBE2huV QgXFi0MZkmNz0sniQyiFM4etdL70V2ntdF71ke6lz7IyhcHWdz0/2FzmMJpj1VMlRpON cxeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=AhnUEdFFWqGuqKk7HcQygs9znr/gnHSS65isK2aLNIQ=; fh=2l4y01x6BcabbUgY30MsQPP8rtOBAeTmXuxIOgbyRvY=; b=X9cjYY58bK837hUYcngRr2oklfNcKEZutJYAOyFAR2x4hJUUonhD7IO6Kg8QLa3qFC JpUkMhAkRitMUSHgVeOfR1eVH3erhVwhOc/ZQ4rc6+sNDEHTPqzJPfveKk2H2N9pPcZc PiiBFRem18X7aAWZ873u7ON0lFIZnmuHJcySI0pdNIF3euxjA6+ZinsQmfI9os6chv6d ++nj5FMUgsbGORDf5H29Bbz0CVQAC41/dij5HjVwUsz69MBgWOEWX1amM47A1CfldYV2 gY8NGmfn1Aat9jkKtYk1AHQmBkuXYkABiET4CEG+v+YoVj5vwbBrNsGLcfp/RcBx43KP 4apA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=AYy7QYf+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id a38-20020a056a001d2600b006cbee42fbb9si10198608pfx.119.2023.11.27.16.34.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Nov 2023 16:35:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=AYy7QYf+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 82C1A80A4F40; Mon, 27 Nov 2023 16:34:51 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234242AbjK1Aeh (ORCPT + 99 others); Mon, 27 Nov 2023 19:34:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56060 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234239AbjK1Aeg (ORCPT ); Mon, 27 Nov 2023 19:34:36 -0500 Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4D039D62 for ; Mon, 27 Nov 2023 16:34:41 -0800 (PST) Received: by mail-pf1-x433.google.com with SMTP id d2e1a72fcca58-6cbe5b6ec62so3841859b3a.1 for ; Mon, 27 Nov 2023 16:34:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1701131680; x=1701736480; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AhnUEdFFWqGuqKk7HcQygs9znr/gnHSS65isK2aLNIQ=; b=AYy7QYf+oxjKLHl7ebER8TWBRE7sFj2W3Ya6tRqK/J4hi9ekwxJfIzRe805o0RyRri iYTOy3iuOqf9qcARwoQhMl2gwz4wO0t+nNiIrGGfVBvYhuxdsPAmoJd1fq99qwl5C3y1 F82e49ZcFss0zdDxcrQWu+JX031MpUN6C3EZ4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701131680; x=1701736480; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AhnUEdFFWqGuqKk7HcQygs9znr/gnHSS65isK2aLNIQ=; b=MC8tOHtHm6yx4X7kf4kGPZCW7ympURnLZ2l0VSsuyZoFwvaQWC4C6TC3sQpnAZOarw +S+rc6ZDmT/tfWV72xJZBVFhRL0rbtkpZJW5pO0HdCLhbqfWKkrRKc7vROPmOVclIMyN /I7HW//ilZYOzgKEaEBGcy5eOUtQ9KjWRd7CitVLdgQ1hmKIci+Ih3gdZJzbrEPJ1ZJl S5w4ekE/+icvCmZIKm4/eoNFuon5Iu4PNdaZgksCYNdpg+4A8EeNLmh6un4UZz8HSZYw hf8ydRC9A16dVDnTVwG2ALTIV3thbLKWHPPDWJIxsNEAcZk39d+RsAZDgugRfpbhBWbP 3Tgg== X-Gm-Message-State: AOJu0Yx3NVZinpnD5x3/5EarxOFNPlkQXDq/L+HPe0Fnj3MdQfQe9qqj 05Vhs0n8Vog/VXvDQ8+gsJ+Z+Oill9XCZ/ROxkw1TQ== X-Received: by 2002:a05:6a21:a5a0:b0:18a:e40c:682f with SMTP id gd32-20020a056a21a5a000b0018ae40c682fmr15260148pzc.41.1701131680675; Mon, 27 Nov 2023 16:34:40 -0800 (PST) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id i23-20020aa787d7000000b006cb4b7ffe2bsm7647456pfo.195.2023.11.27.16.34.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Nov 2023 16:34:40 -0800 (PST) From: Kees Cook To: "Gustavo A. R. Silva" Cc: Kees Cook , linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] gcc-plugins: randstruct: Update code comment in relayout_struct() Date: Mon, 27 Nov 2023 16:34:36 -0800 Message-Id: <170113167459.1670911.15084763564199264156.b4-ty@chromium.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 27 Nov 2023 16:34:51 -0800 (PST) On Sat, 25 Nov 2023 15:49:12 -0600, Gustavo A. R. Silva wrote: > Update code comment to clarify that the only element whose layout is > not randomized is a proper C99 flexible-array member. This update is > complementary to commit 1ee60356c2dc ("gcc-plugins: randstruct: Only > warn about true flexible arrays") > > Applied to for-linus/hardening, thanks! [1/1] gcc-plugins: randstruct: Update code comment in relayout_struct() https://git.kernel.org/kees/c/d71f22365a9c Take care, -- Kees Cook