Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
From:   Angus Chen <angus.chen@jaguarmicro.com>
To:     tglx@linutronix.de
Cc:     linux-kernel@vger.kernel.org,
        Angus Chen <angus.chen@jaguarmicro.com>
Subject: [PATCH] genirq: Fix irqs_unhandled in note_interrupt
Date:   Tue, 28 Nov 2023 10:10:43 +0800
Message-Id: <20231128021043.2099-1-angus.chen@jaguarmicro.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?LkbBUi7m0EpgCoiN9cZSKL0YAWiwdxEHmc4qROS0lmega7n0GTITP9SxDaGb?=
 =?us-ascii?Q?H7PBIBJV39ACdQkEPydwmAUJIwcPXt/0UtNKgAxVJbKYhky/ZgHR3+nBhWkb?=
 =?us-ascii?Q?5ht/3Wnm105H672QUSRAMSvEx2aXJVMknbce3PlhN7wxk6MJH+Vb6LWFkSVv?=
 =?us-ascii?Q?UFAxHUO10IqS0d7W/OrFYvtg+J88SplYGyU0k9SGXRYE5KmQU9RozPGbHoZI?=
 =?us-ascii?Q?4qjTzqe+mQ61qPSZuF7D01F+G68UiBBVlJzcDNdrpLHrBxOAvewfsZfCZNMO?=
 =?us-ascii?Q?ALVibJwSyqLH1i8uNbw2/iNh2OOeMaU9pwgHb5adXpixU6Z3ho9oZBIwp/yr?=
 =?us-ascii?Q?RKaY0DN1NJuefgGTvzAGUs8oyX3XTX1mfpdg/Io+L8FKsO/pb8+j0d79Co91?=
 =?us-ascii?Q?TZU7/lUahCWsl1pLhz2A4nvacAD5jDd/mZBABEBqAWKgyRIpw8uRnSLwvv5J?=
 =?us-ascii?Q?2j6z65a+w5WkwAZt/Q4njf701CTBzRX1y3CvsRMmsIX2MXaHnHzQ95Z136P1?=
 =?us-ascii?Q?v03NNofsh1ekzX3kdBMQSKZp4TJN65Ym5hVH1F2s3pC5U25xx8JcMkZ6Px7H?=
 =?us-ascii?Q?8pKV8X61Xq6nXawoGM0+cNbpaCS4sW7v4tTjWGx44mbRhm+CKeO6QaaK9FVa?=
 =?us-ascii?Q?8J9AvCSouV4fPRkFCpoqqETqKhwz6CqKQlF/JSYosEFpGtu+yhitOALjJz1K?=
 =?us-ascii?Q?y5/tgjRj7npDFfOtqG+T7M/sRS5hYgXP6pQd9qFN4dbYK/7/DKsm/rVCKuDF?=
 =?us-ascii?Q?W+tPq9mmO5HOzyqKy/LdY+YqmpFzWZWtz1pNj/Xz++s6x3VCQ+T4RGes/kTA?=
 =?us-ascii?Q?bicJlgAhBiIndOl+wXnl7uO4N2C/KC7PXp8ojzVfCZLnyluAAvRhTqu3ChlT?=
 =?us-ascii?Q?x78yYCxda/+QAgXGxUb50HZD7yzHsFOZBqyxDcWpdP2uerSO+IeMYINUxUVd?=
 =?us-ascii?Q?Ho95fV3qIvUqveICd+dw1PfAIgoJUcxPiOX9yMXt+/3G9VGjCDUWdcxuZg+1?=
 =?us-ascii?Q?PPPY9x82gxl25mxaqQGU5eO4gEU92P808fMcsb2+AG34mViUmK7hM/RFrCMz?=
 =?us-ascii?Q?r52JEvkZaKimOCXzW+jPw1PUwCpMBNCo7IZYoqaVhA95xHZGKP8O3hMlp0of?=
 =?us-ascii?Q?XKFmFAsb9IwNJKoFE4NBWvC7toaX++07dZMzNx3xMQKb0SrBzkPizbsW6KOr?=
 =?us-ascii?Q?m1sXXkGJAGoZedgI06Tr/FGm6dUQIcqddZ+PeyayDA2bxV8hwqUJ2Xx+WAAX?=
 =?us-ascii?Q?m1R0dSKwnThAdxT+pnisAGWWrS9UlwKvF02amWRg320kP+VCGgRSvxl0A9lj?=
 =?us-ascii?Q?+IDGiHwwVQOzZ1KXWmLryMpt9tTcUeCQZN2IR1nfTu0ZxwNj1JQIkixYvX5H?=
 =?us-ascii?Q?+d4P3F3r3Z6TkDGH8ulVFVflwpTUwVE4nIu2Rqizim6RFaKBfMmBygkh03RT?=
 =?us-ascii?Q?EGPhbVLLsuoTlF0vVOW8d+rO7rUNWoDb5XjheuWcyJIVv3DCaUvE9H3l9Zz8?=
 =?us-ascii?Q?mY91Nag6yKUu4yM0LCLZiBPVW4XiMcnMWgdZtYwtSx6TYHKw2tIj10A2MgCj?=
 =?us-ascii?Q?WWTVzmp8rwqTH8SRsOGDXZwJkjwBm//SbaHTnowc8y+/cmSySCjX4Vh16NIo?=
 =?us-ascii?Q?Zg=3D=3D?=
X-OriginatorOrg: jaguarmicro.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a58b3d4f-b9ab-42fb-14cd-08dbefb745af
X-MS-Exchange-CrossTenant-AuthSource: TY2PR06MB3424.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2023 02:11:03.2363
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 1e45a5c2-d3e1-46b3-a0e6-c5ebf6d8ba7b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5QzsZBZ1tNgj4pwYMKSdP0gap4x24711VLmv9ElUlS1pwUtAqUmsRXKpFy7eGWRuNfpZ+1RlOrUv8KYgjDjRWhCZUIrtWOURQEHoG495DTc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PUZPR06MB5954
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Mon, 27 Nov 2023 18:11:54 -0800 (PST)

Commit 4f27c00bf80f ("Improve behaviour of spurious IRQ detect")
introduced a age of last_unhandled,after irq_count reached 100000,
we set irqs_unhandled = 0,but we didn't clear last_unhandled.
So we can see the print of irq_spurious_proc_show is not consistent.
Like below:
root@jmkernel:~# cat /proc/irq/138/spurious
count 99998
unhandled 1
last_unhandled 1543930240 ms

root@jmkernel:~# cat /proc/irq/138/spurious
count 0
unhandled 0
last_unhandled 1548915240 ms

we can set last_unhandled=1 as a prompting message.

Signed-off-by: Angus Chen <angus.chen@jaguarmicro.com>
---
 kernel/irq/spurious.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/irq/spurious.c b/kernel/irq/spurious.c
index 02b2daf07441..e883df04bdf1 100644
--- a/kernel/irq/spurious.c
+++ b/kernel/irq/spurious.c
@@ -428,7 +428,7 @@ void note_interrupt(struct irq_desc *desc, irqreturn_t action_ret)
 		mod_timer(&poll_spurious_irq_timer,
 			  jiffies + POLL_SPURIOUS_IRQ_INTERVAL);
 	}
-	desc->irqs_unhandled = 0;
+	desc->irqs_unhandled = 1;
 }
 
 bool noirqdebug __read_mostly;
-- 
2.34.1