Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Message-ID: <90c4bc5d-fd09-46ba-87af-6763a46c2276@intel.com>
Date:   Tue, 28 Nov 2023 11:06:52 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 2/3] vfio: Add VFIO_DEVICE_PASID_[AT|DE]TACH_IOMMUFD_PT
Content-Language: en-US
To:     "Duan, Zhenzhong" <zhenzhong.duan@intel.com>,
        "joro@8bytes.org" <joro@8bytes.org>,
        "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
        "jgg@nvidia.com" <jgg@nvidia.com>,
        "Tian, Kevin" <kevin.tian@intel.com>,
        "robin.murphy@arm.com" <robin.murphy@arm.com>,
        "baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>
CC:     "cohuck@redhat.com" <cohuck@redhat.com>,
        "eric.auger@redhat.com" <eric.auger@redhat.com>,
        "nicolinc@nvidia.com" <nicolinc@nvidia.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "mjrosato@linux.ibm.com" <mjrosato@linux.ibm.com>,
        "chao.p.peng@linux.intel.com" <chao.p.peng@linux.intel.com>,
        "yi.y.sun@linux.intel.com" <yi.y.sun@linux.intel.com>,
        "peterx@redhat.com" <peterx@redhat.com>,
        "jasowang@redhat.com" <jasowang@redhat.com>,
        "shameerali.kolothum.thodi@huawei.com" 
        <shameerali.kolothum.thodi@huawei.com>,
        "lulu@redhat.com" <lulu@redhat.com>,
        "suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
        "joao.m.martins@oracle.com" <joao.m.martins@oracle.com>,
        "Zeng, Xin" <xin.zeng@intel.com>,
        "Zhao, Yan Y" <yan.y.zhao@intel.com>
References: <20231127063909.129153-1-yi.l.liu@intel.com>
 <20231127063909.129153-3-yi.l.liu@intel.com>
 <SJ0PR11MB6744B5CAC867EE643958078D92BDA@SJ0PR11MB6744.namprd11.prod.outlook.com>
From:   Yi Liu <yi.l.liu@intel.com>
In-Reply-To: <SJ0PR11MB6744B5CAC867EE643958078D92BDA@SJ0PR11MB6744.namprd11.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L2duRkFlbDNJbEttemM1V3BQMVVYTGtVOVpobUZCTG1FV1ZZR2k4alVZbTdE?=
 =?utf-8?B?T3NJZVpoVkZjeWUzVjFRSXNxOVlwaFV5UEtaV1E3ZEFmSm16aGlWcXQ0WTNo?=
 =?utf-8?B?bkJCaExUbEQwRG9oQitFT0ZweHZ2ZU4zRUZWYlovdFZRNlBkTDBEemxQWDA5?=
 =?utf-8?B?Q0dPcTIvRFFrOWJ5bGw4UTRTT20yNGdVcTRiNTBzSGNHcTdlMnJncHJIbTE5?=
 =?utf-8?B?bFdmMWg2eEJmVk1EK05WdWJkK1ZHbjBOZUl5ZnNycXg5ZUhQSzZkQkhkdVJY?=
 =?utf-8?B?SUJFbFVxTjJ0NThVZHc5V2dTTnROQURGTFhCY29sWjQxTC9hRE8xTGx5SUlJ?=
 =?utf-8?B?c0tVT2ZjUHJYU2NFQ0tWZHZjbldSTkhKSVZidmJIeCt0a3BGMmRTa2p5NTVn?=
 =?utf-8?B?aXR6emdvWDlWM0dIWHZHMU1WeGdTLyttK0NlTXBSY213MWlGcmwwQW52TWZa?=
 =?utf-8?B?amNIODJaTGRGVzhBTnpuVyt4THpvNGlyUjBsaDYxYlVxRHZRZ2RWVk1BcFZI?=
 =?utf-8?B?TmpJalFWSkkzTUE4NGovcmF5RzB0U2ZQNllDNm52SzRQeXdCb2NOUXUvMVJW?=
 =?utf-8?B?UDN3eVd1a3gxSnlJcW9ONFdTdGgrWGZ4dXJubHN1Qk82Yk1GeDFJQzlBZHRC?=
 =?utf-8?B?ZGJTUmxoZGpicE43N2pwdTd0QnFoNGxrZkxrQUY4WlhKTzRnNjAvU1RrSU5x?=
 =?utf-8?B?QlB0SHdxenZUbGFjYmsvZVZpaFZOSDV5ZWV6L2VraWc4NW50Y1ZyangzTXBw?=
 =?utf-8?B?d1hHVW9CQnR6RWt2cWxVajhvMUtRblZ2QitRUDBhRUMyODR2cm1HSWZzdTl1?=
 =?utf-8?B?OWRoZmlBeTNSVFRJRTM4K2FnYkFKbTdBQlpIM0NsMmczaSthZS84N2M1QytK?=
 =?utf-8?B?Yy9KM3RCVHhCQmM3SzMyTGtGZ3JTSGpyazhiWktWVDlJRjZhalUydm9JRnFM?=
 =?utf-8?B?aExHdFlUWmRHcW82QzdvSG9mZ2JxMkYzZ3JmcUFRZEV3N3NYMnVwc1JBZklk?=
 =?utf-8?B?ZDU4M3UzRXh4c1pjYlZtZ0ZPbENnVURycjk0Qm15cHhiWjBySmFZNkhQYXhY?=
 =?utf-8?B?K1o4Z1grVEtLcHBMWU1tTUs2bGU2QVFDaGtkbE1COEVaek9GMm4yeXd4ZVpm?=
 =?utf-8?B?VHRLdnVFWWMyd1lHbXJFZWlDSEIxMkZHRFJ4dWVPc0Q4NVpSWkZOVWszYTBa?=
 =?utf-8?B?MmpyTzE4NXFROFBJYTBoeUxoeDh6Tmc0cUQ1dlliOGNYanhuN3k2bEk5YkRy?=
 =?utf-8?B?Y0IvQXlnQm9pa0Y4TnE1akd5QndQbEVFSkNpN0JuVzFJWm1SbDFkY1ROaWFH?=
 =?utf-8?B?bWdDdFhQYTdKMWdIdTgxbHRDZlVraS9VenFLOXZNOVQ5dW1xZ21icjA3T1E4?=
 =?utf-8?B?a3VDamlxYVdCL3lwRFlPTTJNU3J1cjlUMnlNc0hHdjVVT0JVQzB2Q3J2KzJl?=
 =?utf-8?B?ZWRIME4yVG1JeklDMVc0VXZLOXhhSW5TWUxuUURhU1REdGpEMVBaRDh0MjQ1?=
 =?utf-8?B?QmR2ZjJzdmhNRUZJeDJpTmcybng2aXplLzNzSzh4ajhoTGhRVjRWbDUyL2VL?=
 =?utf-8?B?WEFaaVBiOEN6S3dxTnl1dkw5b1hxeXNRVlViY1pDdlYvUmVZWWwwMEhIOVdp?=
 =?utf-8?B?cDJTck1QaVVqcDIzR0ZaNXo0MGtGcDlFZXl4ZEZxamVRaDcxSC9wUGx5ZG1L?=
 =?utf-8?B?QmRHdW9xQ0lzZUJuNXBiVG5uZHNwYm83THdUZHZLbTU3WkNrU0ZtL2pTOFJs?=
 =?utf-8?B?ZXNDTlZPbDI4TVI4d1U3cW9zTnNBUVc0Mkw1Q2JNNHlFWXIvL3hhSW81aDNG?=
 =?utf-8?B?dGV0YklENzZjQlRUQ1hUU3YzYS9LTDhKUzJRSHEyTStoclRtNTlXYkh5Y2ZD?=
 =?utf-8?B?bm9kelY1T3dEU2IvWVZTYkhianlsOHhsbitTVmdSb0dXb0NLTVJVckFwMExX?=
 =?utf-8?B?dG0vbHpxMGF1eUlZMnhDNnlUZmVLa2Q5VXVlVkMrSnRraVJla3lwZ01tRXJT?=
 =?utf-8?B?Uzc1SitxU2lnWTI5K2lwZmVXV3pmZVdSdWMxRGxyaDNaWXp6YnczK3dwUERE?=
 =?utf-8?B?OERCbjNsQlpYZ2Z4enNCVTErWTU4alNZNFlzRU1sMTh1YzRSc2hpZzIzNnd4?=
 =?utf-8?Q?FesqWYCTADHSq5InkPT7RwrKI?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 927cbaa6-3037-4a57-cb8b-08dbefbeb9c0
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7529.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2023 03:04:25.3041
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JopuHqu95AAV4m1Q4gbEFYpj9ZmzuZAB6X0Iv0bW4EHmn8rTG0K2sk2WES9kctxdY9YaZ6qea94c6VYy4CaA5g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB8587
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Mon, 27 Nov 2023 19:04:41 -0800 (PST)


On 2023/11/27 14:50, Duan, Zhenzhong wrote:
> 
> 
>> -----Original Message-----
>> From: Liu, Yi L <yi.l.liu@intel.com>
>> Sent: Monday, November 27, 2023 2:39 PM
>> Subject: [PATCH 2/3] vfio: Add
>> VFIO_DEVICE_PASID_[AT|DE]TACH_IOMMUFD_PT
>>
>> This adds ioctls for the userspace to attach a given pasid of a vfio
>> device to/from an IOAS/HWPT.
>>
>> Signed-off-by: Yi Liu <yi.l.liu@intel.com>
>> ---
>> drivers/vfio/device_cdev.c | 45 +++++++++++++++++++++++++++++++
>> drivers/vfio/vfio.h        |  4 +++
>> drivers/vfio/vfio_main.c   |  8 ++++++
>> include/uapi/linux/vfio.h  | 55 ++++++++++++++++++++++++++++++++++++++
>> 4 files changed, 112 insertions(+)
>>
>> diff --git a/drivers/vfio/device_cdev.c b/drivers/vfio/device_cdev.c
>> index e75da0a70d1f..c2ac7ed44537 100644
>> --- a/drivers/vfio/device_cdev.c
>> +++ b/drivers/vfio/device_cdev.c
>> @@ -210,6 +210,51 @@ int vfio_df_ioctl_detach_pt(struct vfio_device_file *df,
>> 	return 0;
>> }
>>
>> +int vfio_df_ioctl_pasid_attach_pt(struct vfio_device_file *df,
>> +				  struct vfio_device_pasid_attach_iommufd_pt
>> __user *arg)
>> +{
>> +	struct vfio_device *device = df->device;
>> +	struct vfio_device_pasid_attach_iommufd_pt attach;
>> +	unsigned long minsz;
>> +	int ret;
>> +
>> +	minsz = offsetofend(struct vfio_device_pasid_attach_iommufd_pt, pt_id);
>> +
>> +	if (copy_from_user(&attach, arg, minsz))
>> +		return -EFAULT;
>> +
>> +	if (attach.argsz < minsz || attach.flags)
>> +		return -EINVAL;
>> +
>> +	mutex_lock(&device->dev_set->lock);
>> +	ret = device->ops->pasid_attach_ioas(device, attach.pasid,
>> &attach.pt_id);
>> +	mutex_unlock(&device->dev_set->lock);
>> +
>> +	return ret;
>> +}
>> +
>> +int vfio_df_ioctl_pasid_detach_pt(struct vfio_device_file *df,
>> +				  struct vfio_device_pasid_detach_iommufd_pt
>> __user *arg)
>> +{
>> +	struct vfio_device *device = df->device;
>> +	struct vfio_device_pasid_detach_iommufd_pt detach;
>> +	unsigned long minsz;
>> +
>> +	minsz = offsetofend(struct vfio_device_pasid_detach_iommufd_pt, flags);
> 
> Pasid isn't copied, should use pasid here?

good catch! will fix it.

-- 
Regards,
Yi Liu