Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
From:   Subbaraya Sundeep Bhatta <sbhatta@marvell.com>
To:     Jakub Kicinski <kuba@kernel.org>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "edumazet@google.com" <edumazet@google.com>,
        Sunil Kovvuri Goutham <sgoutham@marvell.com>,
        Geethasowjanya Akula <gakula@marvell.com>,
        Hariprasad Kelam <hkelam@marvell.com>
Subject: RE: [EXT] Re: [PATCH net] octeontx2-af: Check return value of
 nix_get_nixlf before using nixlf
Thread-Topic: [EXT] Re: [PATCH net] octeontx2-af: Check return value of
 nix_get_nixlf before using nixlf
Thread-Index: AQHaH71bnglX5YY3uU+OhgAFWZgyArCPDyIAgAACvfA=
Date:   Tue, 28 Nov 2023 03:13:02 +0000
Message-ID: <CO1PR18MB466672C69AB420D424C7457AA1BCA@CO1PR18MB4666.namprd18.prod.outlook.com>
References: <1700930098-5483-1-git-send-email-sbhatta@marvell.com>
 <20231127190222.293afaec@kernel.org>
In-Reply-To: <20231127190222.293afaec@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?djj9Tseg8zMxn58xI3Ri3Ou3aMR6+hcIjgAylTJmYy1JSS2U4myJt8IlZOnv?=
 =?us-ascii?Q?JlA83rshJJxiWuqas+cXkPJSClE4XmbMCLTmChvigklFQELkykch0C+Ewb8h?=
 =?us-ascii?Q?sdHo9TCk68KkraItaW8fuWiGap60gFoSpD8aLcoyuSTd64dsUX46GPw7tYmw?=
 =?us-ascii?Q?VLz+xy4+A0PSJ3AbpQFVHgTgpE60zpcKvkMAraTchH3wAnf81xnLkpND28z0?=
 =?us-ascii?Q?cHjhgIzkIl/qvL6a/uGxqnLU3+kGVbbEPc1MpqLRz8v21jEzFC8bpulr9AR8?=
 =?us-ascii?Q?gFjaLS5zrnX1q5rbwWT3bPXCSFL1VyD5CAg8uLEs65s8IypkIAsdX94jlTyO?=
 =?us-ascii?Q?CR8i/OgpZby34v4Bkjfo/UZS3hTjVfUtr9JSYKc5eidf4BHIunwZAmpoZ6SQ?=
 =?us-ascii?Q?XD8ClLbrKZZ+F4hiz7wds1uvwUTpiqTX5KZdDO7Xc4dRrndKCvf7V9i3kKey?=
 =?us-ascii?Q?D2DOkaU07lZMP/2JYS8wgX9ZZ/SDPjOI7jjFo0wp/3+p4u+vAVC/FmOsnkfk?=
 =?us-ascii?Q?r32/eeiSR1zdtbtxEKYwWIdFk/jgQijJULiOAHG7Kaeja6TKkX5MWJ9snPsK?=
 =?us-ascii?Q?G6CqHXZ37gwRynBoi+nMx2Q9gq/wqaKP3V6sbo7oGya2+mHoUzNFfRSe4ciM?=
 =?us-ascii?Q?T6L/9zsHBGvTlwGDIITqmx+PpqHX/+WMqkFwrfR8YrVHcURpehJWEO+k5vj5?=
 =?us-ascii?Q?B5uizmCLFcJoOw4oQVoU29C7xSE5n9flZWcPIvYHHzxBhbMMqpdbRsW1VL0H?=
 =?us-ascii?Q?s+jzHLZbn5YscghmV+qpDBOsSsIy64L80Fp4Ekn4k8PU7EnRBEVNYVBQvQwn?=
 =?us-ascii?Q?l/Lhz5ekc2ToEA7bI/pxOsTH2vPfuiLCzYfRfCsKcWgU7LP5DlAOtZ7Pwuif?=
 =?us-ascii?Q?6XnI/OYgZvTocPf9+G9/MOGaYHCEcUrSaz63A/Z0TMVmJd5IH9W6HmNrGbrC?=
 =?us-ascii?Q?Bi8SnIibGdcxXMuK6bB61NeEou1mwWTA4hH8ZO1VC7OVN67d4/K314dUVdlR?=
 =?us-ascii?Q?4it9Mluf1qAp2AwLNUZa+SFoDeXqfF+iYp6ezx0NahhSsMw/MP/i6/eP4MIk?=
 =?us-ascii?Q?R25uWtAub2GC9jh60a8zNGPp6RFF/rK4s8TOXDZZpM0hwhk57El7Mi5L//ve?=
 =?us-ascii?Q?MFUGO+StQZ02gQR8BIrC3HbKQ0sxZFJhkIxKoIDlh32OIor5hmBC6JD5JzrM?=
 =?us-ascii?Q?sdFQQwWjT98wnGQqy1B7ANYMctBFlVeQLKgopuIqjToHLwOjE3tC5HJ3GWcH?=
 =?us-ascii?Q?eDMqnRERhmFP1PDpzOLGLf7jT7obo0AQ/qAWS4nwtnLQsnyMm0iSyZaMcI80?=
 =?us-ascii?Q?/wxilKiI4BjBGoeAmDNjVu8f31nUb6R7byROv//3ttX/wUtArvuKc8U0xGdo?=
 =?us-ascii?Q?3lZZdUYMmPIYFnTlS6TCSOmaR7wKxrLqPsAJMq+93BcDHG9h4y6qlptzTVK9?=
 =?us-ascii?Q?+wcV5yENIq/W4kbFlaKpKA/5tAoBb001yrfgq6SwXVVAj5orwj7uemhzIRkQ?=
 =?us-ascii?Q?YnYLtPK750UjMZQvxQRO87k3baoRhxH1Lsuu15bSI+a5ZTe0a88C8Bol2OnJ?=
 =?us-ascii?Q?oI56NBWMknHctf3DFvY=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO1PR18MB4666.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 006f1b78-7801-4b82-8e17-08dbefbfeec8
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Nov 2023 03:13:02.6933
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 1Vph8Jm6l2eHqoUjccbsaW2lXIZ3EYH7s87xZAyKuMoA81hJYTdbtqLwic+Fmc+DgvciE19qPwyQIdMpz40RBQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR18MB5315
X-Proofpoint-ORIG-GUID: sJkM5lJ4yps1bIGq-IDH-cAzl9MV14JI
X-Proofpoint-GUID: sJkM5lJ4yps1bIGq-IDH-cAzl9MV14JI
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-11-28_01,2023-11-27_01,2023-05-22_02
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Mon, 27 Nov 2023 19:13:28 -0800 (PST)

Hi Jakub,

>-----Original Message-----
>From: Jakub Kicinski <kuba@kernel.org>
>Sent: Tuesday, November 28, 2023 8:32 AM
>To: Subbaraya Sundeep Bhatta <sbhatta@marvell.com>
>Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org;
>davem@davemloft.net; pabeni@redhat.com; edumazet@google.com; Sunil
>Kovvuri Goutham <sgoutham@marvell.com>; Geethasowjanya Akula
><gakula@marvell.com>; Hariprasad Kelam <hkelam@marvell.com>
>Subject: [EXT] Re: [PATCH net] octeontx2-af: Check return value of
>nix_get_nixlf before using nixlf
>
>----------------------------------------------------------------------
>On Sat, 25 Nov 2023 22:04:58 +0530 Subbaraya Sundeep wrote:
>> If a NIXLF is not attached to a PF/VF device then nix_get_nixlf
>> function fails and returns proper error code. But
>> npc_get_default_entry_action does not check it and uses garbage value
>> in subsequent calls. Fix this by cheking the return value of
>> nix_get_nixlf.
>>
>> Fixes: 967db3529eca ("octeontx2-af: add support for multicast/promisc
>> packet replication feature")
>
>You need to run the patch thru scripts/get_maintainer, here you missed CCi=
ng
>Naveen, who authored 967db3529eca.
>Also lcherian@marvell.com and jerinj@marvell.com LMK if these people are
>no longer at marvell, I can add their addresses to our ignore list.
>
>Same goes for the pauseparam patch, you'll need to repost the two.

Sure will do it.

Thanks,
Sundeep
>--
>pw-bot: cr